Review main Abandoned

74189[TASK] Fix usage of fieldsets

Benjamin Kott CR 0 V 0 Easy +6 −3 updated 04/07/22, 14:12

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 68

  1. Benjamin Kott uploaded patch set 1 04/05/22, 19:38

  2. core-ci voted on patch set 1 V -1 04/05/22, 20:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25556

  3. Michael Telgkamp uploaded patch set 2 04/06/22, 17:43

  4. Christian Kuhn commented on patch set 2 04/06/22, 17:46

    maybe add a comment? why is fieldset invalid in this particular case?
  5. core-ci voted on patch set 2 V -1 04/06/22, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25686

  6. Benjamin Franzke commented on patch set 2 CR -1 04/07/22, 12:42

    PaletteAndSingleContainer.php:364

    We should rather replace <h4> with <legend> instead of removing <fieldset>. Fieldset is semantically correct and if it is removed, also all variable names and the method name "fieldSetWrap" should be adapted.
  7. Michael Telgkamp commented on patch set 2 CR -1 04/07/22, 14:11

    Reply Unresolved

    There will be another patch for the changes started here.

    PaletteAndSingleContainer.php:364 Reply Unresolved

    This patch will be abandoned, the idea is to fix the connection between labels, legends and form fields in a broader way. This will be handled in https://forge.typo3.org/issues/97330 Fieldsets will only be used when required. Currently all form fields (also single form fields) are surrounded by a fieldset, which is not useful. The plan is to have fieldsets only arround groups of fields that need to be grouped (checkboxes, radio buttons, complex field groups like the multi-groups) where the legend of the fieldset describes all form items inside. All other form elements will not be surrounded by fieldsets.
  8. Benjamin Kott abandoned the change 04/07/22, 14:12

    as discussed with michael t - will be solved in different patch