74191[!!!][TASK] Remove context sensitive help
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 310
- Build/phpstan/phpstan-baseline.neon+0 −20
- Build/Sources/TypeScript/backend/context-help.ts8+0 −104
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+0 −4
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+0 −12
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+1 −4
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php+1 −4
- typo3/sysext/backend/Classes/Controller/BackendController.php+0 −1
- typo3/sysext/backend/Classes/Controller/ContextHelpAjaxController.phpdeleted+0 −74
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+0 −10
- typo3/sysext/backend/Classes/Controller/HelpController.phpdeleted+0 −195
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+0 −7
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+0 −6
- typo3/sysext/backend/Classes/Domain/Repository/TableManualRepository.phpdeleted+0 −429
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php+1 −2
- typo3/sysext/backend/Classes/Form/Container/FlexFormNoTabsContainer.php+0 −17
- typo3/sysext/backend/Classes/Form/Container/FlexFormTabsContainer.php+0 −16
- typo3/sysext/backend/Classes/Form/Container/FullRecordContainer.php2+0 −6
- typo3/sysext/backend/Classes/Form/Container/ListOfFieldsContainer.php+0 −6
- typo3/sysext/backend/Classes/Form/Container/PaletteAndSingleContainer.php+1 −2
- typo3/sysext/backend/Classes/Form/Element/CategoryElement.php+0 −5
Show 290 more files
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php4+32 −2
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+0 −5
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/HelpButton.php6+16 −6
- typo3/sysext/backend/Classes/Template/Components/ButtonBar.php4+7 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php6+6 −130
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+0 −6
- typo3/sysext/backend/Configuration/Backend/Modules.php+0 −14
- typo3/sysext/backend/Configuration/Backend/Routes.php+0 −5
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_mod_help_cshmanual.xlfdeleted+0 −17
- typo3/sysext/backend/Resources/Private/Language/locallang_pages_new_csh.xlfdeleted+0 −32
- typo3/sysext/backend/Resources/Private/Language/locallang_pages_sort_csh.xlfdeleted+0 −37
- typo3/sysext/backend/Resources/Private/Partials/ContextSensitiveHelp/Manual.htmldeleted+0 −48
- typo3/sysext/backend/Resources/Private/Partials/ContextSensitiveHelp/TableOfContents.htmldeleted+0 −33
- typo3/sysext/backend/Resources/Private/Templates/ContextSensitiveHelp/All.htmldeleted+0 −25
- typo3/sysext/backend/Resources/Private/Templates/ContextSensitiveHelp/Detail.htmldeleted+0 −22
- typo3/sysext/backend/Resources/Private/Templates/ContextSensitiveHelp/Index.htmldeleted+0 −24
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/HelpToolbarItemDropDown.html+11 −1
- typo3/sysext/backend/Resources/Public/Images/Csh/PagesNew_1.pngdeletedbinary
- typo3/sysext/backend/Resources/Public/Images/Csh/PagesNew_2.pngdeletedbinary
- typo3/sysext/backend/Resources/Public/Images/Csh/PagesSort.pngdeletedbinary
- typo3/sysext/backend/Resources/Public/JavaScript/context-help.js+1 −1
- typo3/sysext/backend/Tests/Functional/Form/MfaInfoElementTest.php+0 −1
- typo3/sysext/backend/Tests/Unit/Form/Container/PaletteAndSingleContainerTest.php+0 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaLanguageTest.php+0 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+0 −1
- typo3/sysext/backend/ext_tables.php+0 −13
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+0 −6
- typo3/sysext/beuser/Tests/Functional/ViewHelpers/MfaStatusViewHelperTest.php+0 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+0 −2
- typo3/sysext/core/Classes/Hooks/TcaItemsProcessorFunctions.php+1 −8
- typo3/sysext/core/Classes/Localization/LanguageService.php2+0 −69
- typo3/sysext/core/Classes/Migrations/TcaMigration.php2+21 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php2+2 −10
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97312-RemoveContextSensitiveHelp.rst20new+88 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-97312-DeprecateCSH-relatedMethods.rstnew+49 −0
- typo3/sysext/core/Resources/Private/Language/locallang_csh_be_groups.xlfdeleted+0 −330
- typo3/sysext/core/Resources/Private/Language/locallang_csh_be_users.xlfdeleted+0 −279
- typo3/sysext/core/Resources/Private/Language/locallang_csh_corebe.xlfdeleted+0 −908
- typo3/sysext/core/Resources/Private/Language/locallang_csh_pages.xlfdeleted+0 −348
- typo3/sysext/core/Resources/Private/Language/locallang_csh_sysfilem.xlfdeleted+0 −79
- typo3/sysext/core/Resources/Private/Language/locallang_csh_sysfilereference.xlfdeleted+0 −41
- typo3/sysext/core/Resources/Private/Language/locallang_csh_sysfilestorage.xlfdeleted+0 −53
- typo3/sysext/core/Resources/Private/Language/locallang_csh_sysnews.xlfdeleted+0 −20
- typo3/sysext/core/Resources/Public/Images/cshimages/beuser_1.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/beuser_2.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/beuser_3.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/beuser_4.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_1.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_2.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_3.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_4.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_5.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_6.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_7.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_8.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_9.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_10.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_11.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_12.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_13.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_14.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_15.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_16.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_17.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_18.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_19.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/be_groups_20.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_1.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_2.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_3.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_4.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_5.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_6.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_7.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_8.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_9.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_10.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_11.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_12.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_13.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_14.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_15.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_16.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_17.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_18.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_19.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_20.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_21.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_22.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_23.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_24.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_25.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_26.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_27.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_28.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_29.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_30.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_31.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_32.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_33.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_34.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_36.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_37.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_38.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_39.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_40.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_41.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_42.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_43.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_44.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_46.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_47.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_48.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_49.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_50.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_51.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_52.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_53.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_54.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_55.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_56.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_57.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_58.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_59.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_64.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_65.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_67.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_68.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_69.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/core_70.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/filemount_1.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/hidden_page.gifdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/login.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/pages_1.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/pages_2.pngdeletedbinary
- typo3/sysext/core/Resources/Public/Images/cshimages/page_shortcut.gifdeletedbinary
- typo3/sysext/core/Tests/Acceptance/Application/ConfigurationModule/ConfigurationModuleProviderCest.php+0 −1
- typo3/sysext/core/Tests/Acceptance/Application/Site/SiteModuleCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/HelpCest.php+3 −7
- typo3/sysext/core/Tests/Unit/Hooks/TcaItemsProcessorFunctionsTest.php+0 −12
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+51 −0
- typo3/sysext/core/ext_tables.php+0 −16
- typo3/sysext/filelist/Classes/Controller/File/CreateFolderController.php+0 −10
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+0 −5
- typo3/sysext/filelist/Classes/Controller/File/FileUploadController.php+0 −5
- typo3/sysext/filelist/Classes/Controller/File/RenameFileController.php+0 −6
- typo3/sysext/filelist/Classes/Controller/File/ReplaceFileController.php+0 −5
- typo3/sysext/filelist/Classes/Controller/FileListController.php+0 −7
- typo3/sysext/filelist/Resources/Private/Templates/File/CreateFolder.html+3 −3
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+0 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/CshViewHelper.php2+9 −26
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Labels/CshViewHelper.php2+16 −20
- typo3/sysext/fluid/Tests/FunctionalDeprecated/ViewHelpers/Be/Labels/CshViewHelperTest.phprenamed+0 −0
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+0 −3
- typo3/sysext/frontend/Resources/Private/Language/locallang_csh_fe_groups.xlfdeleted+0 −71
- typo3/sysext/frontend/Resources/Private/Language/locallang_csh_fe_users.xlfdeleted+0 −137
- typo3/sysext/frontend/Resources/Private/Language/locallang_csh_systmpl.xlfdeleted+0 −133
- typo3/sysext/frontend/Resources/Private/Language/locallang_csh_ttcontent.xlfdeleted+0 −503
- typo3/sysext/frontend/Resources/Private/Language/locallang_csh_weblayout.xlfdeleted+0 −190
- typo3/sysext/frontend/Resources/Public/Images/cshimages/fegroups_3.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/fegroups_4.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/feusers_1.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/feusers_2.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/localizationoverview.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/localizationoverview1.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_1.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_2.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_4.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_5.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_6.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_7.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_9.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_10.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_11.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_12.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_13.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_14.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagemodule_15.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagetree_overview_1.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagetree_overview_4.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagetree_overview_5.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagetree_overview_6.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagetree_overview_7.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagetree_overview_8.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/pagetree_overview_9.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/systemplate.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/systemplate1.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/systemplate2.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/ttcontent_1.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/ttcontent_2.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/ttcontent_3.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/ttcontent_4.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/ttcontent_5.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/ttcontent_6.pngdeletedbinary
- typo3/sysext/frontend/Resources/Public/Images/cshimages/ttcontent_7.pngdeletedbinary
- typo3/sysext/frontend/ext_tables.php+0 −6
- typo3/sysext/impexp/Resources/Private/Language/locallang_csh.xlfdeleted+0 −366
- typo3/sysext/impexp/Resources/Private/Language/locallang_csh_tx_impexp_presets.xlfdeleted+0 −23
- typo3/sysext/impexp/Resources/Private/Partials/Export/AdvancedOptions.html2+4 −7
- typo3/sysext/impexp/Resources/Private/Partials/Export/Configuration.html+17 −31
- typo3/sysext/impexp/Resources/Private/Partials/Export/Save.html+3 −9
- typo3/sysext/impexp/Resources/Private/Partials/Import/Import.html+5 −15
- typo3/sysext/impexp/Resources/Private/Partials/Import/Upload.html2+1 −5
- typo3/sysext/impexp/Resources/Public/Images/cshimages/diffview.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/excludebox.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/export.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/export1.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/export2.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/extdep.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/fileformat.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/htmlcss.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/impexp.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/impexp_misc.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/impexp_misc1.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/impexp_misc2.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/impexp_misc3.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/impexp_misc4.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/import.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/import_selectfile.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/metadata.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/pagetreecfg.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/phpext.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/references.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/references1.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/references2.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/singlerecord.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/static.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/static1.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/tablelist.pngdeletedbinary
- typo3/sysext/impexp/Resources/Public/Images/cshimages/update.pngdeletedbinary
- typo3/sysext/impexp/ext_tables.php2deleted+0 −10
- typo3/sysext/indexed_search/Classes/Hook/AvailableTcaTables.php+1 −4
- typo3/sysext/indexed_search/Resources/Private/Language/locallang_csh_indexcfg.xlfdeleted+0 −160
- typo3/sysext/indexed_search/ext_tables.php+0 −1
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+0 −3
- typo3/sysext/info/Classes/Controller/PageInformationController.php+0 −13
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+0 −2
- typo3/sysext/info/Resources/Private/Language/locallang_csh_tsconfigInfo.xlfdeleted+0 −60
- typo3/sysext/info/Resources/Private/Language/locallang_csh_webinfo.xlfdeleted+0 −116
- typo3/sysext/info/Resources/Private/Language/locallang_csh_web_info.xlfdeleted+0 −23
- typo3/sysext/info/Resources/Private/Partials/PageTsConfig/Page.html+0 −3
- typo3/sysext/info/Resources/Private/Templates/PageInformation.html+0 −1
- typo3/sysext/info/Resources/Private/Templates/TranslationStatus.html+0 −1
- typo3/sysext/info/Resources/Public/Images/cshimages/pagetree_overview_10.pngdeletedbinary
- typo3/sysext/info/ext_tables.phpdeleted+0 −10
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayGlobalMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+14 −0
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php+7 −7
- typo3/sysext/linkvalidator/Resources/Private/Language/Module/locallang_csh.xlfdeleted+0 −65
- typo3/sysext/linkvalidator/ext_tables.phpdeleted+0 −12
- typo3/sysext/lowlevel/Configuration/Services.yaml+2 −12
- typo3/sysext/lowlevel/Resources/Private/Language/locallang.xlf+0 −3
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −5
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php2+3 −5
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+0 −14
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Resources/Private/Language/locallang_csh_scheduler.xlfdeleted+0 −139
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditAdditionalFields.html+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditDescriptionField.html+2 −2
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditDisableField.html+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditFrequencyField.html+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditMultipleField.html+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditStartEndFields.html+2 −2
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditTaskGroupField.html+1 −1
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditTypeField.html+1 −1
- typo3/sysext/scheduler/Resources/Private/Templates/AddTaskForm.html+1 −1
- typo3/sysext/scheduler/ext_tables.phpdeleted+0 −13
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php2+1 −32
- typo3/sysext/setup/Resources/Private/Language/locallang_csh_mod.xlfdeleted+0 −188
- typo3/sysext/setup/Resources/Public/Images/cshimages/lang.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/rte.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/setup1.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/setup2.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/setup3.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/setup4.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/setup6.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/setup7.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/setup8.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/setup9.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/setup10.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/setup11.pngdeletedbinary
- typo3/sysext/setup/Resources/Public/Images/cshimages/setup12.pngdeletedbinary
- typo3/sysext/setup/ext_tables.php+0 −24
- typo3/sysext/sys_note/Resources/Private/Language/locallang_csh_sysnote.xlfdeleted+0 −35
- typo3/sysext/sys_note/ext_tables.php+0 −1
- typo3/sysext/workspaces/Resources/Private/Language/locallang_csh_sysws_stage.xlfdeleted+0 −26
- typo3/sysext/workspaces/ext_tables.phpdeleted+0 −9
Review log 4262
Show 2237 earlier messages
-
Michael Telgkamp uploaded patch set 1 04/05/22, 20:14
-
Torben Hansen updated the commit message in patch set 2 04/05/22, 20:19
-
core-ci voted on patch set 1 V -1 04/05/22, 20:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25558
-
Michael Telgkamp uploaded patch set 3 04/05/22, 20:32
-
core-ci voted on patch set 2 V -1 04/05/22, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25559
-
Oli Bartsch commented on patch set 3 04/05/22, 20:37
-
Michael Telgkamp uploaded patch set 4 04/05/22, 20:41
-
core-ci voted on patch set 3 V -1 04/05/22, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25560
-
core-ci voted on patch set 4 V -1 04/05/22, 20:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25561
-
Benni Mack commented on patch set 4 04/05/22, 21:11
I like this one in general! I added a few remarksButtonBar.php:156please add a trigger_error() call here.HelpButton.php:36I guess we need to keep this one, in a way to NOT render any content in v12. and mark it as deprecated with trigger_error()BackendUtility.php:1892the method is internal and can be removed directlyBackendUtility.php:1906the method is internal, can be removed directlyLanguageService.php:208needs a trigger_error() callBreaking-97312-RemoveContextSensitiveHelp.rst:34we should also list the removed entry points and moduleBreaking-97312-RemoveContextSensitiveHelp.rst:36Can you provide an example here? -
Michael Telgkamp uploaded patch set 5 04/05/22, 22:17
-
core-ci voted on patch set 5 V -1 04/05/22, 22:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25567
-
Michael Telgkamp uploaded patch set 6 04/06/22, 07:22
-
core-ci voted on patch set 6 V -1 04/06/22, 07:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25578
-
Benni Mack uploaded patch set 7 04/06/22, 08:32
-
Benni Mack uploaded patch set 8 04/06/22, 08:41
-
core-ci voted on patch set 7 V -1 04/06/22, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25591
-
core-ci voted on patch set 8 V -1 04/06/22, 08:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25594
-
Michael Telgkamp uploaded patch set 9 04/06/22, 10:06
-
core-ci voted on patch set 9 V -1 04/06/22, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25610
-
Michael Telgkamp uploaded patch set 10 04/06/22, 10:26
-
core-ci voted on patch set 10 V -1 04/06/22, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25616
-
Michael Telgkamp uploaded patch set 11 04/06/22, 11:13
-
core-ci voted on patch set 11 V +1 04/06/22, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25621
-
Michael Telgkamp commented on patch set 9 04/06/22, 11:24
Thank you for the helping comments. I tried to adjust everything mentioned.ButtonBar.php:156ReplyTrigger call is addedHelpButton.php:36ReplyThe class is added with a deprecation warning in the render() methodBackendUtility.php:1892ReplyThe method is removed and the removal is mentioned in the rst.BackendUtility.php:1906ReplyThe method is removed and the removal is mentioned in the rst.LanguageService.php:208ReplyAs the method was @internal the method is removed and the removal is mentioned in the rst.Breaking-97312-RemoveContextSensitiveHelp.rst:34Replythe rst is adjusted.Breaking-97312-RemoveContextSensitiveHelp.rst:36Replyan example is addedext_tables.php:1ReplyThe file is now removed. -
Oli Bartsch commented on patch set 11 04/06/22, 12:47
Please add proper line breaks to the commit message.runTests.sh:246I think this was not commited intentionally?context-help.ts:16unusedcontext-help.ts:17unusedcontext-help.ts:21unusedcontext-help.ts:77According to the comment, this might also be removed.FullRecordContainer.php:42This should get a TCAMigration. Additionally, EXT:frontend/Configuration/TCA/tt_content.php still defines the property.SelectCheckBoxElement.php:274We might use the description from removed BackendUtility::wrapInHelp() here?ButtonBar.php:155This needs an entry in the extension scanner (MethodCallMather)HelpButton.php:36The whole class should be deprecated. Triggering an error could IMO be done in the constructor. This then also needs a extension scanner entry (ClassNameMatcher).HelpButton.php:152Let's move the trigger_error to the __construct() since the whole class should be deprecated.BackendUtility.php:1895Needs an entry in the extension scanner (MethodCallStaticMatcher)ExtensionManagementUtility.php:832Any reason for not adding a trigger_error() here? Needs an entry in the extension scanner (MethodCallStaticMatcher)Breaking-97312-RemoveContextSensitiveHelp.rst:5Those should match the ending of the titleBreaking-97312-RemoveContextSensitiveHelp.rst:12Since this is an internal class, no mention necessary.Breaking-97312-RemoveContextSensitiveHelp.rst:18Since this is an internal class, no mention necessary.Breaking-97312-RemoveContextSensitiveHelp.rst:21Since this is an internal class, no mention necessary.Breaking-97312-RemoveContextSensitiveHelp.rst:22$GLOBALS['TCA_DESCR'] needs to be removed properly. This includes: - Extension scanner entry (ArrayGlobalMatcher) - Remove from Bootsrap::unsetReservedGlobalVariables() - Remove from ConfigurationModuleProviderCest::dropDownPagesDataProvider() - Remove corresponding configuration provider from EXT:lowlevel/Configuration/Services.yaml with the corresponding locallang label - TcaItemsProcessorFunctionsTest still fills this array in test casesBreaking-97312-RemoveContextSensitiveHelp.rst:34Since this is an internal method, no mention necessary.Breaking-97312-RemoveContextSensitiveHelp.rst:38Since this methods are internal, no mention necessary.CshViewHelper.php:87Would suggest sth like: __CLASS__ only returns the $renderChildrenClosure() in TYPO3 v12 as compatibility layer and will be completely removed in TYPO3 v13.CshViewHelper.php:83Lets use __CLASS__ hereCshViewHelperTest.php:41If this is still done in the viewHelper, the test should not be removed but moved to /Tests/FunctionalDeprecated/AdvancedOptions.html:22Why do we remove this label here completely?Upload.html:11Why do we remove this label here completely?DatabaseRecordList.php:666This "if" looks superfluous now.SetupModuleController.php:667This is no longer used. Is this correct? Then we should drop the method. -
Michael Telgkamp uploaded patch set 12 04/06/22, 14:43
-
Michael Telgkamp updated the commit message in patch set 13 04/06/22, 14:44
-
Michael Telgkamp updated the commit message in patch set 14 04/06/22, 14:46
-
Michael Telgkamp commented on patch set 14 04/06/22, 14:56
Reply
DonerunTests.sh:246ReplyDonecontext-help.ts:16ReplyDonecontext-help.ts:17ReplyDonecontext-help.ts:21ReplyDonecontext-help.ts:77ReplyDoneFullRecordContainer.php:42ReplyDoneSelectCheckBoxElement.php:274ReplyI adjusted the description and renamed the variable to fit better to the usage.ButtonBar.php:155ReplyDoneHelpButton.php:36ReplyDoneHelpButton.php:152ReplyDoneBackendUtility.php:1895ReplyDoneExtensionManagementUtility.php:832ReplyThe reason is that this function is called on every page load and might flood the deprecation logs.Breaking-97312-RemoveContextSensitiveHelp.rst:5ReplyDoneBreaking-97312-RemoveContextSensitiveHelp.rst:12ReplyDoneBreaking-97312-RemoveContextSensitiveHelp.rst:18ReplyDoneBreaking-97312-RemoveContextSensitiveHelp.rst:21ReplyDoneBreaking-97312-RemoveContextSensitiveHelp.rst:22ReplyDoneBreaking-97312-RemoveContextSensitiveHelp.rst:34ReplyDoneBreaking-97312-RemoveContextSensitiveHelp.rst:38ReplyDoneCshViewHelper.php:87ReplyDoneCshViewHelper.php:83ReplyDoneCshViewHelperTest.php:41ReplyDoneAdvancedOptions.html:22ReplyThis was an error, Label is added again, but without buttons.cshUpload.html:11ReplyThis was an error, Label is added again, but without buttons.cshDatabaseRecordList.php:666ReplyDoneSetupModuleController.php:667ReplyDone -
core-ci voted on patch set 12 V +1 04/06/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25657
-
core-ci voted on patch set 13 V -1 04/06/22, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25658
-
core-ci voted on patch set 14 V +1 04/06/22, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25660
-
Andreas Kienast commented on patch set 14 CR -1 04/06/22, 15:08
on it -
Andreas Kienast uploaded patch set 15 04/06/22, 15:12
-
core-ci voted on patch set 15 V +1 04/06/22, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25664
-
Andreas Kienast commented on patch set 15 CR -1 04/06/22, 15:45
still on it
-
Andreas Kienast uploaded patch set 16 04/06/22, 16:28
-
Andreas Kienast commented on patch set 16 V +1 CR +1 04/06/22, 16:29
Looks fine to me now. -
core-ci voted on patch set 16 V +1 04/06/22, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25674
-
Oliver Hader commented on patch set 16 04/06/22, 17:35
Breaking-87193-DeprecatedFunctionalityRemoved.rst:97This line should be kept, shouldn't it? Since it refers to docs of TYPO3 v10.0. -
Michael Telgkamp uploaded patch set 17 04/06/22, 17:47
-
Michael Telgkamp commented on patch set 17 04/06/22, 17:48
Breaking-87193-DeprecatedFunctionalityRemoved.rst:97ReplyDone -
Oliver Hader voted on patch set 17 CR +1 04/06/22, 17:49
-
core-ci voted on patch set 17 V +1 04/06/22, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25688
-
Oliver Hader voted on patch set 17 V +1 04/06/22, 18:08
-
Georg Ringer voted on patch set 17 V +1 CR +1 04/06/22, 18:13
-
Oli Bartsch commented on patch set 16 CR -1 04/06/22, 18:36
Thanks for all the adjustments! Had a second look, giving -1 because of the missing TCA migration tests.SelectCheckBoxElement.php:280This annotation can be dropped since the method is already protected.TcaMigration.php:1098Let's also remove ['interface'] if it gets empty due to removal of "always_description" Please also cover this with a test.Breaking-97312-RemoveContextSensitiveHelp.rst:11Could we please add some sort of actual description about the why and how? -
Oli Bartsch voted on patch set 17 CR -1 04/06/22, 18:37
-
Michael Telgkamp uploaded patch set 18 04/06/22, 19:19
-
Michael Telgkamp commented on patch set 17 04/06/22, 19:20
SelectCheckBoxElement.php:280ReplyDoneTcaMigration.php:1098ReplyDoneBreaking-97312-RemoveContextSensitiveHelp.rst:11ReplyDone -
core-ci voted on patch set 18 V +1 04/06/22, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25699
-
Oli Bartsch uploaded patch set 19 04/06/22, 19:42
-
Oli Bartsch commented on patch set 19 V +1 CR +1 04/06/22, 19:43
Great patch, thanks a lot! -
core-ci voted on patch set 19 V +1 04/06/22, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25701
-
Stefan Bürk commented on patch set 19 V +1 CR +1 04/06/22, 21:03
Thanks for the work on this patch, Michael (and others). -
Georg Ringer voted on patch set 19 V +1 CR +1 04/07/22, 03:57
-
Andreas Kienast uploaded patch set 20 04/07/22, 06:34
-
Andreas Kienast voted on patch set 20 V +1 CR +1 04/07/22, 06:35
-
core-ci voted on patch set 20 V +1 04/07/22, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25707
-
Oli Bartsch voted on patch set 20 V +2 CR +2 04/07/22, 07:20
-
Oli Bartsch merged patch set 21 04/07/22, 07:20
ext_tables.php:1