Review 10.4 Merged

74194[BUGFIX] Align functional splitting to chunk execution

Christian Kuhn CR +2 V +2 Easy +6 −2 updated 04/06/22, 10:53

Commit message

The check for doing the functional test splitting
script and running the selected chunk used similar
but different minimum chunk value to check against.
Thus the splitting script has not been executed in
all chunk execution contexts.

This patch uses now exactly the same check in the
'Build/Scripts/runTests.sh' like it is defined in
the corresponding docker-compose service config.

Furthermore all previous created functional split
files are now removed to avoid leftovers, which
occured if re-run has lower chunksize defined.

Example which is now properly fixed:

> Build/Scripts/runTests.sh -s functional -c 1/1

Example with partial part files from previous run:

> Build/Scripts/runTests.sh -s functional -c 1/10
> Build/Scripts/runTests.sh -s functional -c 1/8

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 04/06/22, 08:50

  2. core-ci voted on patch set 1 V +1 04/06/22, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25598

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 04/06/22, 09:08

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 04/06/22, 09:12

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 04/06/22, 10:53

  6. Christian Kuhn merged patch set 2 04/06/22, 10:53