Review main Merged

74195[BUGFIX] Fix duration determination in Notification.showMessage()

Andreas Kienast CR +2 V +2 Easy +5 −4 updated 04/07/22, 11:45

Commit message

The determination of the duration used in Notification.showMessage() now
takes `SeverityEnum.error` into account and sets the duration to 0,
which is the same behavior when using `Notification.error()`.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Andreas Kienast uploaded patch set 1 04/06/22, 09:29

  2. Andreas Kienast uploaded patch set 2 04/06/22, 09:38

  3. core-ci voted on patch set 1 V +1 04/06/22, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25603

  4. core-ci voted on patch set 2 V +1 04/06/22, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25606

  5. Andreas Kienast uploaded patch set 3 04/06/22, 09:52

  6. core-ci voted on patch set 3 V +1 04/06/22, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25608

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 04/06/22, 10:21

  8. Benjamin Franzke voted on patch set 3 V +2 CR +2 04/07/22, 11:45

  9. Benjamin Franzke merged patch set 4 04/07/22, 11:45