74196[TASK] Render notification when saving a record succeeded
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Björn Jacob +1
-
Verified V +2 Done
- Oli Bartsch +2
- Björn Jacob +1
- core-ci +1 CI
Issues 1
Files 3
Review log 4052
Show 2127 earlier messages
-
Andreas Kienast uploaded patch set 1 04/06/22, 09:37
-
core-ci voted on patch set 1 V -1 04/06/22, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25605
-
Andreas Kienast uploaded patch set 2 04/06/22, 09:54
-
core-ci voted on patch set 2 V +1 04/06/22, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25609
-
Oli Bartsch voted on patch set 2 V +1 CR +1 04/06/22, 10:20
-
Oli Bartsch voted on patch set 2 V 0 CR 0 04/06/22, 10:20
-
Oli Bartsch commented on patch set 2 V -1 04/06/22, 11:00
We should also handle "edge cases", such as multiple record edit. -
Björn Jacob commented on patch set 2 V -1 04/06/22, 11:26
Saving an empty content element of type "Text" returns some markup in the flash message. Will add a screenshot to the issue. -
Andreas Kienast uploaded patch set 3 04/06/22, 13:57
-
Andreas Kienast commented on patch set 3 CR -1 04/06/22, 13:58
Still needs more thoughts regarding mass edit -
core-ci voted on patch set 3 V -1 04/06/22, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25649
-
Oliver Klee wrote 04/06/22, 14:10
Removed cc Oliver Klee. -
Andreas Kienast uploaded patch set 4 04/06/22, 14:41
-
core-ci voted on patch set 4 V +1 04/06/22, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25655
-
Oli Bartsch commented on patch set 4 V +1 04/06/22, 15:40
WorksEditDocumentController.php:403I personally would prefer to encapsulate this into an own method. Keeps the mainAction clean, which IMO is important to quickly grasp the flow of this monster.EditDocumentController.php:716Is this a left over comment?EditDocumentController.php:733Any reason for not using "implode(LF, $messages)"?locallang_alt_doc.xlf:154Since this message might be used several times, I suggest to end it with a full stop.DataHandler.php:9205This reads like this list might differ from the log error messages. Suggest to add a "the": a list of the erroneous recordsDataHandler.php:9230Do we really need this? This would be the only place in core with such early return. In case no rows are in the result the "while" will be skipped anyways and the empty $affectedRecords array is returned right away. -
Oli Bartsch commented on patch set 4 V 0 04/06/22, 16:09
Reply
Checked in more detail and this now might lead to false notifications, e.g. when duplicating a record while selecting the "No, just duplicate the original" action. Also the added flash messages are not properly resolved in case the return target is not "record_edit". For example edit a record, click on "Close" > "Save & Close". The flash message will then be added to the redirect target module and not displayed as notification. -
Andreas Kienast uploaded patch set 5 04/29/22, 10:10
-
Andreas Kienast commented on patch set 5 04/29/22, 10:12
Reply
I have no idea how to solve the "Save & Close" case properly without introducing "global" notifications :/. -
core-ci voted on patch set 5 V -1 04/29/22, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26652
-
Oliver Klee commented on patch set 5 04/29/22, 12:33
EditDocumentController.php:2367Please let's have a PHP type annotation for the parameter (also for isDuplicateAction). Probably something along the lines of array<string, string> or array<string, int> or array<string, string|int>.EditDocumentController.php:2376We can have an array type declaration here.DataHandler.php:9208Please let's have a PHPDoc type annotation for the return type with more details: array<int, non-empty-string> -
Andreas Kienast commented on patch set 5 CR -2 05/09/22, 17:35
-2 for now, I came up with another idea how to solve the notification vs. flash message thing -
Andreas Kienast uploaded patch set 6 05/09/22, 19:18
-
Andreas Kienast commented on patch set 6 CR -2 05/09/22, 19:18
PS 6 is meant to be tested with https://review.typo3.org/c/Packages/TYPO3.CMS/+/74582 -
core-ci voted on patch set 6 V -1 05/09/22, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27050
-
Andreas Kienast rebased onto patch set 7 06/21/22, 10:55
-
Andreas Kienast voted on patch set 7 CR 0 06/21/22, 10:55
-
core-ci voted on patch set 7 V +1 06/21/22, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28297
-
Andreas Kienast commented on patch set 7 06/22/22, 06:55
Reply
DoneEditDocumentController.php:403ReplyDoneEditDocumentController.php:716ReplyDoneEditDocumentController.php:733ReplyDoneEditDocumentController.php:2367ReplyDoneEditDocumentController.php:2376ReplyDonelocallang_alt_doc.xlf:154ReplyDoneDataHandler.php:9205ReplyDoneDataHandler.php:9208ReplyDoneDataHandler.php:9230ReplyDone -
Nikita Hovratov uploaded patch set 8 06/23/22, 19:33
-
Nikita Hovratov commented on patch set 8 06/23/22, 19:37
I like this change! I wonder why we didn't add it long time ago. Would be cool to have this for Site Configuration, too! -
core-ci voted on patch set 8 V +1 06/23/22, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28367
-
Oli Bartsch commented on patch set 8 V -1 06/24/22, 12:41
Some problems I encountered: * Inline relations are added to the notification as well but their record title seems to be not resolves properly * Editing a record, clicking on "+ new" and selecting "no, just add" triggers the notification, while the record is actually not saved -
Andreas Kienast uploaded patch set 9 06/24/22, 13:23
-
Andreas Kienast uploaded patch set 10 06/24/22, 13:25
-
core-ci voted on patch set 9 V +1 06/24/22, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28388
-
core-ci voted on patch set 10 V +1 06/24/22, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28389
-
Oliver Klee wrote 06/24/22, 13:59
Removed cc Oliver Klee. -
Anne Feldten voted on patch set 10 V +1 06/24/22, 15:14
-
Felix P. commented on patch set 10 V +1 06/24/22, 15:29
Should a notification be triggered when you copy & paste a record? like a content element. -
Andreas Kienast commented on patch set 10 06/24/22, 15:36
Reply
We can do that in a separate patch, if that's ok for you. I don't want to clutter this one more. -
Oli Bartsch commented on patch set 10 V -1 06/24/22, 22:38
Works great already! Just found one other edge case: Edit an existing record => Click "Duplicate" => Click "Yes, save and duplicate this record" => Instead of the record title, "[No Title]" is displayed in the notification. -
Andreas Kienast commented on patch set 10 07/01/22, 13:50
Reply
Nice, I get an exception instead _sad_ -
Andreas Kienast uploaded patch set 11 07/01/22, 13:57
-
core-ci voted on patch set 11 V +1 07/01/22, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28577
-
Andreas Kienast uploaded patch set 12 07/01/22, 15:15
-
Oli Bartsch commented on patch set 12 V +1 CR +1 07/01/22, 15:18
🥳 -
core-ci voted on patch set 12 V +1 07/01/22, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28589
-
Björn Jacob commented on patch set 12 V +1 CR +1 07/04/22, 19:52
Awesome. Works fine. -
Oli Bartsch voted on patch set 12 V +2 CR +2 07/04/22, 20:12
-
Oli Bartsch merged patch set 13 07/04/22, 20:13