Review main Merged

74199[TASK] Connect labels with its select fields in various modules

Georg Ringer CR +2 V +2 Normal +32 −20 updated 04/07/22, 03:57

Commit message

Extend BackendUtility::getDropdownMenu() for the possibility
to add the "id" of the select element. This allows to connect
a corresponding label, improving accessibility.

This is done for the info and template module.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1519

  1. Georg Ringer uploaded patch set 1 04/06/22, 12:07

  2. Georg Ringer commented on patch set 1 04/06/22, 12:07

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/06/22, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25630

  4. Oli Bartsch commented on patch set 1 04/06/22, 12:59

    Do you intend to improve corresponding places in ts_template as well?
  5. Georg Ringer commented on patch set 1 CR -2 04/06/22, 14:31

    Reply

    I can do
  6. Georg Ringer uploaded patch set 2 04/06/22, 16:24

  7. Georg Ringer voted on patch set 2 CR 0 04/06/22, 16:24

  8. core-ci voted on patch set 2 V +1 04/06/22, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25673

  9. Oli Bartsch commented on patch set 2 04/06/22, 16:41

    TypoScriptObjectBrowserController.php:241

    Let's add the id here, too. 'ts_browser_toplevel_' . $tsBrowserType
  10. Georg Ringer commented on patch set 2 04/06/22, 18:22

    TypoScriptObjectBrowserController.php:241 Reply

    havent found where this is used actually then and if there is a field for that? can you help?
  11. Oli Bartsch uploaded patch set 3 04/06/22, 19:02

  12. core-ci voted on patch set 3 V +1 04/06/22, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25698

  13. Oli Bartsch uploaded patch set 4 04/06/22, 19:24

  14. core-ci voted on patch set 4 V +1 04/06/22, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25700

  15. Oli Bartsch commented on patch set 4 V +1 CR +1 04/06/22, 19:51

    Reply

    Done

    TypoScriptObjectBrowserController.php:241 Reply

    Done
  16. Stefan Bürk voted on patch set 4 CR +1 04/06/22, 20:00

  17. Stefan Bürk voted on patch set 4 V +1 04/06/22, 20:16

  18. Georg Ringer voted on patch set 4 V +2 CR +2 04/07/22, 03:57

  19. Georg Ringer merged patch set 5 04/07/22, 03:57