74199[TASK] Connect labels with its select fields in various modules
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+5 −3
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+1 −1
- typo3/sysext/info/Classes/Controller/PageInformationController.php+2 −2
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+2 −2
- typo3/sysext/info/Resources/Private/Partials/PageTsConfig/Page.html+1 −1
- typo3/sysext/info/Resources/Private/Templates/PageInformation.html+6 −2
- typo3/sysext/info/Resources/Private/Templates/TranslationStatus.html+6 −2
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptConstantEditorController.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptObjectBrowserController.php3+3 −3
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditor.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateObjectBrowser.html+4 −2
Review log 1519
-
Georg Ringer uploaded patch set 1 04/06/22, 12:07
-
Georg Ringer commented on patch set 1 04/06/22, 12:07
This change is ready for review. -
core-ci voted on patch set 1 V +1 04/06/22, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25630
-
Oli Bartsch commented on patch set 1 04/06/22, 12:59
Do you intend to improve corresponding places in ts_template as well? -
Georg Ringer commented on patch set 1 CR -2 04/06/22, 14:31
Reply
I can do -
Georg Ringer uploaded patch set 2 04/06/22, 16:24
-
Georg Ringer voted on patch set 2 CR 0 04/06/22, 16:24
-
core-ci voted on patch set 2 V +1 04/06/22, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25673
-
Oli Bartsch commented on patch set 2 04/06/22, 16:41
TypoScriptObjectBrowserController.php:241Let's add the id here, too. 'ts_browser_toplevel_' . $tsBrowserType -
Georg Ringer commented on patch set 2 04/06/22, 18:22
TypoScriptObjectBrowserController.php:241Replyhavent found where this is used actually then and if there is a field for that? can you help? -
Oli Bartsch uploaded patch set 3 04/06/22, 19:02
-
core-ci voted on patch set 3 V +1 04/06/22, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25698
-
Oli Bartsch uploaded patch set 4 04/06/22, 19:24
-
core-ci voted on patch set 4 V +1 04/06/22, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25700
-
Oli Bartsch commented on patch set 4 V +1 CR +1 04/06/22, 19:51
Reply
DoneTypoScriptObjectBrowserController.php:241ReplyDone -
Stefan Bürk voted on patch set 4 CR +1 04/06/22, 20:00
-
Stefan Bürk voted on patch set 4 V +1 04/06/22, 20:16
-
Georg Ringer voted on patch set 4 V +2 CR +2 04/07/22, 03:57
-
Georg Ringer merged patch set 5 04/07/22, 03:57