74200[TASK] Revert "[TASK] Refresh the look of pagemodule"
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Mathias Schreiber +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Mathias Schreiber +1
- Lidia Demin +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 19
- Build/Sources/Sass/module/_page.scss+236 −196
- Build/Sources/Sass/typo3/_element_buttons.scss+0 −6
- Build/Sources/TypeScript/backend/layout-module/drag-drop.ts+1 −1
- Build/Sources/TypeScript/backend/layout-module/paste.ts+1 −1
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php+50 −40
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+9 −28
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+0 −11
- typo3/sysext/backend/Classes/View/PageLayoutView.php+25 −24
- typo3/sysext/backend/Classes/View/PageLayoutViewDrawEmptyColposContent.php+8 −4
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/ColumnHeader.html+2 −2
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/RecordDefault/Header.html+16 −12
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html+12 −10
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/drag-drop.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/paste.js+1 −1
- typo3/sysext/frontend/Classes/Preview/ImagePreviewRenderer.php+14 −0
- typo3/sysext/frontend/Classes/Preview/TextmediaPreviewRenderer.php+16 −2
- typo3/sysext/frontend/Classes/Preview/TextpicPreviewRenderer.php+16 −2
- typo3/sysext/frontend/Classes/Preview/TextPreviewRenderer.php+1 −1
Review log 2932
Show 67 earlier messages
-
Benjamin Franzke uploaded patch set 1 04/06/22, 13:40
-
Helmut Hummel voted on patch set 1 V +1 CR +1 04/06/22, 13:45
-
André Kraus commented on patch set 1 V -1 04/06/22, 13:51
The page pilot is available ux-testing.snowflake.ch/typo3 for a long time and broadly discussed around the world. -
Benjamin Franzke commented on patch set 1 CR -2 04/06/22, 13:52
We shouldn't merge this revert too quickly either. Let's see if there is activity to fix the issues and to catch up with communication of the global scope from the code sprint. -
Benjamin Kott commented on patch set 1 04/06/22, 13:53
1. was available for a while on the ux team demo 2. structured content was involved, offered to change the authors name to theirs - was not importent to them 3. quality issues 1. different border radius is intended its getting smaller inwards so look more harmonic 2. delete button was discussed and the decision was made by the ux team to remove it 3. no evelvation for disabled elements and grid cells - also intended 4. patch was adapted to avoid general changes to concepts like the large buttons that we dont have anywhere else and the removal of labels were also rejected 5. centered buttons were a request from the ux team not getting the problem, except "i don`t like it" i agree that the commit message could be more expressive. -
core-ci voted on patch set 1 V -1 04/06/22, 13:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25644
-
Annett Jähnichen commented on patch set 1 V -1 04/06/22, 13:53
The Patch was created basing on the Structured Content Initiative Page Pilot Project.
-
Annett Jähnichen wrote 04/06/22, 13:54
Removed Verified-1 by Annett Jähnichen <mcmietz@web.de> -
Georg Ringer voted on patch set 1 V +1 CR +1 04/06/22, 13:54
-
Christian Kuhn voted on patch set 1 V +1 CR +1 04/06/22, 14:01
-
Anja Leichsenring commented on patch set 1 V +1 CR +1 04/06/22, 14:02
hiding the delete button is not good way to teach editors to keep a clean house. Strongly disagree with this decision. -
core-ci voted on patch set 1 V +1 04/06/22, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25644
-
Lidia Demin commented on patch set 1 04/06/22, 14:07
Unresolved
While creating the original page pilot, we discussed a lot of these issues already. Thus, the decisions on UI changes were made with careful consideration. The pilot was available for testing a long time and the community feedback was very positive. There was even a test on a real-life project and the client was happy. So obviously, people don't hate the new look and feel. -
Lidia Demin voted on patch set 1 V -1 04/06/22, 14:07
-
Andreas Kienast commented on patch set 1 04/06/22, 14:12
Just my 2ct as I merged the original patch. Anything that happened here was decided and tested by the UX team. It's the task of the UX team to take these decisions, even if they are invasive, that's why this change came into 12.*0*. Honestly, if profound decisions made by the UX team are nulled and voided, we can also disband it right now. -
Georg Ringer commented on patch set 1 04/06/22, 14:20
Reply
@Andreas: I guess it is more about how this has been done, providing an issue with 0 information and a commit with 0 information. *Everybody* likes evelovment and is happy to get the UX team on board -
Annett Jähnichen commented on patch set 1 04/06/22, 14:57
Here you can find a valid description why we as UX Initiative propose to move the delete button to the context menu. https://forge.typo3.org/issues/95247#note-4 and also the other forge ticket related to that changes https://forge.typo3.org/issues/94629 -
Oliver Hader commented on patch set 1 04/06/22, 15:02
Based on what I read here, I'm pretty much convinced that this is an ongoing process. BNF already pointed out some specific aspects in the original change (https://review.typo3.org/c/Packages/TYPO3.CMS/+/74182/7#message-90a8cf0db7fa2b21da075da2978c34013f49e6f9) which might be tackled in the future. Further details on the scope/vision on UX changes for v12 in general, corresponding references to Google Docs and news articles on typo3.org can be added to issue #97306. -
Helmut Hummel commented on patch set 1 V 0 CR 0 04/06/22, 15:26
Based on the context, that is now provided to the referenced forge ticket, I'm fine with keeping the change merged and not doing a revert. -
Stefan Bürk commented on patch set 1 04/06/22, 16:10
Not looked into everything, but moving the content element delete to the context menu will create "hate state" on ~100editors of 5 customers on our side. It's there daily buisness to add, modify and delete content elements. I know that they want the delete button directly back and out of the context menu. I talked with the lead editors of the customers about it, not talking with them from smaller customers. For them this would be a v12 upgrade blocker if there is no solution to get the delete button back. -
Stefan Bürk voted on patch set 1 V +1 CR +1 04/06/22, 16:12
-
Georg Ringer voted on patch set 1 V 0 CR 0 04/06/22, 16:17
-
Christian Kuhn commented on patch set 1 04/06/22, 16:24
Reply
agreed georg. this is not about abandoning work or teams. the page module is *the most important* backend module for editors. communication on this patch was non existant to the core team, and the patch went in far too quickly. especially the critical ux decisions should have been done in standalone patches which would have relaxed the situation a lot. -
Mathias Schreiber commented on patch set 1 V +1 CR +1 04/07/22, 17:09
My analysis so far after a lot of talks which I honestly enjoyed because they uncovered some issues that, once solved, make us all a stronger team than before. This patch needs to be reverted because of the commit message and the fast-merge; there's no question about it, and from all the talks I had with people, EVERYONE agreed. I'd like to stress that this revert is done because of the commit message and the merging process that got broken (out of good, but unfortunately wrong intentions). The new patchset will hit Gerrit asap. I am thankful that we were able to get this resolved rather painlessly and want to express my sincere thanks to everybody involved. :) -
Benjamin Franzke uploaded patch set 2 04/07/22, 17:20
-
Benjamin Franzke commented on patch set 2 04/07/22, 17:22
Reply
Ack. Updated the revert commit message to be reflect and limit the reasons to that argumentation. -
Mathias Schreiber commented on patch set 2 V +1 CR +1 04/07/22, 17:24
Reply
Also: This is about the revert and the revert only. Please keep feedback on the changes with the new patchset so we don't mix the two. This creates a lot of friction, friction leads to anger, anger leads to hate and hate leads to writing Cobol. ;-) -
Stefan Bürk voted on patch set 2 V +1 CR +1 04/07/22, 17:26
-
core-ci voted on patch set 2 V +1 04/07/22, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25781
-
Lidia Demin voted on patch set 2 V +1 04/08/22, 07:09
-
Andreas Kienast voted on patch set 2 V +2 CR +2 04/08/22, 08:32
-
Andreas Kienast merged patch set 3 04/08/22, 08:32