Review main Merged

74203[TASK] Polish SvgTree component styling

Benjamin Kott CR +2 V +2 Hard +426 −315 updated 05/06/22, 14:37

Commit message

This patch is cleaning up a lot of loose ends in the svg tree component.
It aims to make the component look more clean and polished.

- Unify focus styling with selected, hover and versioning
- Ensure the whole node looks focused instead of only some text
- Replace expand icon to match core icon styling
- Hide expand icon if page tree is stopped
- Move trigger to enter stopped pagetree to the front
- Remove blurry lines for background borders
- Make the edit input fields use as much space as is available
- Load common icons always on setup to avoid node refresh on initial loads
- Reposition the locked icon (another editor is editing)
- Correct keyboard navigation behaviour and focus setting
- Keep focus after leaving the edit mode without changes
- Adjust positioning to rely on calculation instead of hardcoded values
- Align drag delete target
- Make drag positions more visible to the user when moving a page
- Improve styling of tooltips when dragging elements
- Add border to select tree component to make scroll boundaries visible

Affected Areas:
- PageTree
- FileTree
- SelectTree

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 3958

Show 1933 earlier messages
  1. Benjamin Kott uploaded patch set 1 04/06/22, 18:25

  2. core-ci voted on patch set 1 V -1 04/06/22, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25697

  3. Benjamin Kott uploaded patch set 2 04/07/22, 10:25

  4. core-ci voted on patch set 2 V -1 04/07/22, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25725

  5. Benjamin Kott uploaded patch set 3 04/07/22, 12:38

  6. core-ci voted on patch set 3 V -1 04/07/22, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25742

  7. Benjamin Kott uploaded patch set 4 04/07/22, 13:53

  8. Benjamin Kott marked it ready for review 04/07/22, 13:54

  9. Benjamin Kott rebased onto patch set 5 04/07/22, 13:55

  10. Benjamin Kott uploaded patch set 6 04/07/22, 14:03

  11. core-ci voted on patch set 4 V -1 04/07/22, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25754

  12. core-ci voted on patch set 5 V -1 04/07/22, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25755

  13. core-ci voted on patch set 6 V -1 04/07/22, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25757

  14. Benjamin Kott uploaded patch set 7 04/07/22, 14:26

  15. core-ci voted on patch set 7 V -1 04/07/22, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25760

  16. Benjamin Kott uploaded patch set 8 04/07/22, 14:42

  17. core-ci voted on patch set 8 V -1 04/07/22, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25761

  18. Benjamin Kott uploaded patch set 9 04/07/22, 15:08

  19. core-ci voted on patch set 9 V -1 04/07/22, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25762

  20. Benjamin Franzke wrote 04/07/22, 17:47

    Topic set to ui
  21. Benjamin Kott uploaded patch set 10 04/08/22, 07:06

  22. core-ci voted on patch set 10 V -1 04/08/22, 07:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25806

  23. Benjamin Kott uploaded patch set 11 04/08/22, 08:20

  24. core-ci voted on patch set 11 V -1 04/08/22, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25812

  25. Benjamin Kott uploaded patch set 12 04/08/22, 09:29

  26. core-ci voted on patch set 12 V -1 04/08/22, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25821

  27. Benjamin Kott uploaded patch set 13 04/08/22, 10:45

  28. core-ci voted on patch set 13 V -1 04/08/22, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25828

  29. Benjamin Kott uploaded patch set 14 04/08/22, 11:06

  30. core-ci voted on patch set 14 V -1 04/08/22, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25830

  31. Benjamin Kott uploaded patch set 15 04/08/22, 12:34

  32. Benjamin Kott uploaded patch set 16 04/08/22, 12:36

  33. Benjamin Kott updated the commit message in patch set 17 04/08/22, 12:42

  1. core-ci voted on patch set 15 V +1 04/08/22, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25835

  2. core-ci voted on patch set 16 V -1 04/08/22, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25836

  3. core-ci voted on patch set 17 V +1 04/08/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25837

  4. Oliver Hader commented on patch set 17 04/08/22, 13:33

    file-storage-browser.ts:39

    Is this not required/used anymore?
  5. Simon Schaufelberger commented on patch set 17 CR -1 04/08/22, 22:30

    It feels a bit strange to have a blue first item selected as keyboard selection which doesn't change when you hover over other elements. I would expect that hover changes the selected/active element as well.
  6. Simon Schaufelberger commented on patch set 17 04/08/22, 22:32

    The blue color is very inconsistent with the selection of an entry in the list view which is green. Can we unify that?
  7. Simon Schaufelberger commented on patch set 17 04/08/22, 22:37

    When I drag a page in the page tree somewhere else, the pagetree is reloaded and the highlighted active page focus is gone -> no more blue border.
  8. Simon Schaufelberger commented on patch set 17 04/08/22, 22:40

    When I hover over a page, the "|-" becomes a bit lighter which looks a bit strange for me. I would expect that the color stays the same, like the arrow color when you hover it.
  9. Simon Schaufelberger commented on patch set 17 04/08/22, 22:44

    Reply

    this was the case before the patch.
  10. Benjamin Kott commented on patch set 17 04/09/22, 13:18

    Reply

    in its current state it would need a major rework. it now gets overlayed and shines through the background best case without rework.

    Reply

    the blue styling reflects the :focus of the element. since you do not change the :focus there is no change.

    file-storage-browser.ts:39 Reply

    I preloaded some icons, so fetching is not nessesary anymore.
  11. Benjamin Franzke uploaded patch set 18 05/04/22, 13:56

  12. Benjamin Franzke commented on patch set 18 V +1 CR +1 05/04/22, 14:08

    Reply

    True, but not an issue of this patch. This has existed before. (It's only more visible due to the better active-styling)

    Reply

    I agree, but I guess this is part of the UX-teams design overhaul, and it's fine to do one component after another. (note that the context menu already got that updated color scheme).

    Reply

    I'd love if we could simply `mix-blend-mode: multiply`, but unfortunately that blurs the stroke. We'd basically need to split node-bg-background and node-bg-border into two layers, I'd say that's fine for a separate patch.

    Reply

    Ack with Benji, removing active state only because of hover on other elements isn't user friendly.

    file-storage-browser.ts:39 Reply

    Ack

    SelectPagetreeWithKeyboardCest.php:161 Reply

    Ack
  13. core-ci voted on patch set 18 V +1 05/04/22, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26824

  14. Oli Bartsch voted on patch set 18 V +1 CR +1 05/04/22, 16:06

  15. Simon Schaufelberger commented on patch set 18 05/04/22, 16:33

    Reply

    How did it work before this patch? Before, the "tree" is not blurred.
  16. Benjamin Franzke commented on patch set 18 05/04/22, 16:44

    Reply

    It didn't use mix-blend-mode before (although there was blurring, but for other reasons, that this patch fixes) The tree-lines "worked" because the background was positioned under the tree-lines. That didn't cause a visual clash as the highlight-color and the tree-line-color were the same. Now when highlight-stroke-color is blue, the gray tree lines would create "holes" in the blue highlight stroke. Therefore this patch moved the highlight-stroke above the tree lines.
  17. Jonas Eberle voted on patch set 18 V +1 05/04/22, 17:11

  18. Rachel Foucard voted on patch set 18 V +1 05/04/22, 17:16

  19. Georg Ringer voted on patch set 18 V +1 05/04/22, 19:18

  20. Georg Ringer commented on patch set 18 05/05/22, 08:12

    before merging: wanna check out the discussion in #cig-ux about spacing
  21. Georg Ringer voted on patch set 18 V +2 CR +2 05/06/22, 14:13

  22. Benjamin Franzke uploaded patch set 19 05/06/22, 14:17

    Resolve Merge Conflict
  23. core-ci voted on patch set 19 V +1 05/06/22, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26921

  24. Georg Ringer voted on patch set 19 V +2 CR +2 05/06/22, 14:37

  25. Georg Ringer merged patch set 20 05/06/22, 14:37