74203[TASK] Polish SvgTree component styling
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Georg Ringer +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 24
- Build/Sources/Sass/component/_svgtree.scss+138 −134
- Build/Sources/TypeScript/backend/form-engine/element/select-tree.ts+11 −3
- Build/Sources/TypeScript/backend/page-tree/page-tree-element.ts+28 −16
- Build/Sources/TypeScript/backend/page-tree/page-tree.ts+25 −23
- Build/Sources/TypeScript/backend/tree/drag-drop.ts+3 −3
- Build/Sources/TypeScript/backend/tree/file-storage-browser.ts3+0 −2
- Build/Sources/TypeScript/backend/tree/file-storage-tree-container.ts+1 −1
- Build/Sources/TypeScript/backend/tree/file-storage-tree.ts+1 −1
- Build/Sources/TypeScript/backend/tree/page-browser.ts+1 −3
- Build/Sources/TypeScript/backend/tree/tree-node.ts+1 −0
- Build/Sources/TypeScript/backend/svg-tree.ts+193 −109
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-tree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/page-tree/page-tree-element.js+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/page-tree/page-tree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/drag-drop.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/file-storage-browser.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/file-storage-tree-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/file-storage-tree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-browser.js+2 −2
Show 4 more files
- typo3/sysext/backend/Resources/Public/JavaScript/svg-tree.js+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileStorageTreeFilterCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/PageTree/KeyboardAccess/SelectPagetreeWithKeyboardCest.php2+6 −2
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+2 −2
Review log 3958
Show 1933 earlier messages
-
Benjamin Kott uploaded patch set 1 04/06/22, 18:25
-
core-ci voted on patch set 1 V -1 04/06/22, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25697
-
Benjamin Kott uploaded patch set 2 04/07/22, 10:25
-
core-ci voted on patch set 2 V -1 04/07/22, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25725
-
Benjamin Kott uploaded patch set 3 04/07/22, 12:38
-
core-ci voted on patch set 3 V -1 04/07/22, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25742
-
Benjamin Kott uploaded patch set 4 04/07/22, 13:53
-
Benjamin Kott marked it ready for review 04/07/22, 13:54
-
Benjamin Kott rebased onto patch set 5 04/07/22, 13:55
-
Benjamin Kott uploaded patch set 6 04/07/22, 14:03
-
core-ci voted on patch set 4 V -1 04/07/22, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25754
-
core-ci voted on patch set 5 V -1 04/07/22, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25755
-
core-ci voted on patch set 6 V -1 04/07/22, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25757
-
Benjamin Kott uploaded patch set 7 04/07/22, 14:26
-
core-ci voted on patch set 7 V -1 04/07/22, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25760
-
Benjamin Kott uploaded patch set 8 04/07/22, 14:42
-
core-ci voted on patch set 8 V -1 04/07/22, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25761
-
Benjamin Kott uploaded patch set 9 04/07/22, 15:08
-
core-ci voted on patch set 9 V -1 04/07/22, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25762
-
Benjamin Franzke wrote 04/07/22, 17:47
Topic set to ui -
Benjamin Kott uploaded patch set 10 04/08/22, 07:06
-
core-ci voted on patch set 10 V -1 04/08/22, 07:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25806
-
Benjamin Kott uploaded patch set 11 04/08/22, 08:20
-
core-ci voted on patch set 11 V -1 04/08/22, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25812
-
Benjamin Kott uploaded patch set 12 04/08/22, 09:29
-
core-ci voted on patch set 12 V -1 04/08/22, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25821
-
Benjamin Kott uploaded patch set 13 04/08/22, 10:45
-
core-ci voted on patch set 13 V -1 04/08/22, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25828
-
Benjamin Kott uploaded patch set 14 04/08/22, 11:06
-
core-ci voted on patch set 14 V -1 04/08/22, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25830
-
Benjamin Kott uploaded patch set 15 04/08/22, 12:34
-
Benjamin Kott uploaded patch set 16 04/08/22, 12:36
-
Benjamin Kott updated the commit message in patch set 17 04/08/22, 12:42
-
core-ci voted on patch set 15 V +1 04/08/22, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25835
-
core-ci voted on patch set 16 V -1 04/08/22, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25836
-
core-ci voted on patch set 17 V +1 04/08/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25837
-
Oliver Hader commented on patch set 17 04/08/22, 13:33
file-storage-browser.ts:39Is this not required/used anymore?SelectPagetreeWithKeyboardCest.php:161Nice, this identifies and fixes a regression in the tests! (orig https://review.typo3.org/c/Packages/TYPO3.CMS/+/68151/6/typo3/sysext/core/Tests/Acceptance/Backend/PageTree/KeyboardAccess/SelectPagetreeWithKeyboardCest.php#170) -
Simon Schaufelberger commented on patch set 17 CR -1 04/08/22, 22:30
It feels a bit strange to have a blue first item selected as keyboard selection which doesn't change when you hover over other elements. I would expect that hover changes the selected/active element as well. -
Simon Schaufelberger commented on patch set 17 04/08/22, 22:32
The blue color is very inconsistent with the selection of an entry in the list view which is green. Can we unify that? -
Simon Schaufelberger commented on patch set 17 04/08/22, 22:37
When I drag a page in the page tree somewhere else, the pagetree is reloaded and the highlighted active page focus is gone -> no more blue border. -
Simon Schaufelberger commented on patch set 17 04/08/22, 22:40
When I hover over a page, the "|-" becomes a bit lighter which looks a bit strange for me. I would expect that the color stays the same, like the arrow color when you hover it. -
Simon Schaufelberger commented on patch set 17 04/08/22, 22:44
Reply
this was the case before the patch. -
Benjamin Kott commented on patch set 17 04/09/22, 13:18
Reply
in its current state it would need a major rework. it now gets overlayed and shines through the background best case without rework.Reply
the blue styling reflects the :focus of the element. since you do not change the :focus there is no change.file-storage-browser.ts:39ReplyI preloaded some icons, so fetching is not nessesary anymore. -
Benjamin Franzke uploaded patch set 18 05/04/22, 13:56
-
Benjamin Franzke commented on patch set 18 V +1 CR +1 05/04/22, 14:08
Reply
True, but not an issue of this patch. This has existed before. (It's only more visible due to the better active-styling)Reply
I agree, but I guess this is part of the UX-teams design overhaul, and it's fine to do one component after another. (note that the context menu already got that updated color scheme).Reply
I'd love if we could simply `mix-blend-mode: multiply`, but unfortunately that blurs the stroke. We'd basically need to split node-bg-background and node-bg-border into two layers, I'd say that's fine for a separate patch.Reply
Ack with Benji, removing active state only because of hover on other elements isn't user friendly.file-storage-browser.ts:39ReplyAckSelectPagetreeWithKeyboardCest.php:161ReplyAck -
core-ci voted on patch set 18 V +1 05/04/22, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26824
-
Oli Bartsch voted on patch set 18 V +1 CR +1 05/04/22, 16:06
-
Simon Schaufelberger commented on patch set 18 05/04/22, 16:33
Reply
How did it work before this patch? Before, the "tree" is not blurred. -
Benjamin Franzke commented on patch set 18 05/04/22, 16:44
Reply
It didn't use mix-blend-mode before (although there was blurring, but for other reasons, that this patch fixes) The tree-lines "worked" because the background was positioned under the tree-lines. That didn't cause a visual clash as the highlight-color and the tree-line-color were the same. Now when highlight-stroke-color is blue, the gray tree lines would create "holes" in the blue highlight stroke. Therefore this patch moved the highlight-stroke above the tree lines. -
Jonas Eberle voted on patch set 18 V +1 05/04/22, 17:11
-
Rachel Foucard voted on patch set 18 V +1 05/04/22, 17:16
-
Georg Ringer voted on patch set 18 V +1 05/04/22, 19:18
-
Georg Ringer commented on patch set 18 05/05/22, 08:12
before merging: wanna check out the discussion in #cig-ux about spacing -
Georg Ringer voted on patch set 18 V +2 CR +2 05/06/22, 14:13
-
Benjamin Franzke uploaded patch set 19 05/06/22, 14:17
Resolve Merge Conflict -
core-ci voted on patch set 19 V +1 05/06/22, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26921
-
Georg Ringer voted on patch set 19 V +2 CR +2 05/06/22, 14:37
-
Georg Ringer merged patch set 20 05/06/22, 14:37