74205[!!!][TASK] Remove eval=int from type=datetime
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 27
- Build/Sources/TypeScript/backend/form-engine-validation.ts+0 −1
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php5+7 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+3 −9
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+24 −18
- typo3/sysext/core/Configuration/TCA/be_users.php+0 −3
- typo3/sysext/core/Configuration/TCA/pages.php+0 −4
- typo3/sysext/core/Configuration/TCA/sys_category.php+0 −2
- typo3/sysext/core/Configuration/TCA/sys_file_collection.php+0 −2
- typo3/sysext/core/Configuration/TCA/sys_news.php+0 −3
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97358-RemovedEvalintFromTCATypeDatetime.rstnew+76 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97232-NewTCATypeDatetime.rst+5 −5
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputDateCest.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+4 −21
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+84 −2
- typo3/sysext/dashboard/Configuration/TCA/be_dashboards.php+0 −2
- typo3/sysext/extensionmanager/Configuration/TCA/tx_extensionmanager_domain_model_extension.php+0 −1
- typo3/sysext/filemetadata/Configuration/TCA/Overrides/sys_file_metadata.php+0 −2
- typo3/sysext/frontend/Configuration/TCA/fe_users.php+0 −3
Show 7 more files
- typo3/sysext/frontend/Configuration/TCA/sys_template.php+0 −2
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+0 −3
- typo3/sysext/indexed_search/Configuration/TCA/index_config.php+0 −3
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+2 −10
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/redirects/Configuration/TCA/sys_redirect.php+0 −4
- typo3/sysext/workspaces/Configuration/TCA/sys_workspace.php+0 −1
Review log 2638
Show 713 earlier messages
-
Oli Bartsch uploaded patch set 1 04/06/22, 22:29
-
core-ci voted on patch set 1 V -1 04/06/22, 22:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25703
-
Oli Bartsch uploaded patch set 2 04/07/22, 10:07
-
core-ci voted on patch set 2 V -1 04/07/22, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25724
-
Oli Bartsch rebased onto patch set 3 04/07/22, 12:13
-
core-ci voted on patch set 3 V -1 04/07/22, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25736
-
Oli Bartsch uploaded patch set 4 04/07/22, 18:31
-
core-ci voted on patch set 4 V -1 04/07/22, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25789
-
Oli Bartsch uploaded patch set 5 04/08/22, 22:33
-
core-ci voted on patch set 5 V -1 04/08/22, 22:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25870
-
Oli Bartsch uploaded patch set 6 04/08/22, 23:15
-
core-ci voted on patch set 6 V -1 04/08/22, 23:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25871
-
Oli Bartsch uploaded patch set 7 04/11/22, 09:28
-
core-ci voted on patch set 7 V +1 04/11/22, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25924
-
Oli Bartsch uploaded patch set 8 04/11/22, 11:05
-
core-ci voted on patch set 8 V +1 04/11/22, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25925
-
Oli Bartsch updated the commit message in patch set 9 04/11/22, 15:21
-
core-ci voted on patch set 9 V +1 04/11/22, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25928
-
Benni Mack voted on patch set 9 V +1 CR +1 04/11/22, 18:32
-
Nikita Hovratov uploaded patch set 10 04/12/22, 07:23
-
Nikita Hovratov voted on patch set 10 V +1 CR +1 04/12/22, 07:26
-
core-ci voted on patch set 10 V +1 04/12/22, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25942
-
Georg Ringer voted on patch set 10 V +1 CR +1 04/12/22, 07:36
-
Oli Bartsch voted on patch set 10 CR -1 04/12/22, 08:28
-
Oli Bartsch uploaded patch set 11 04/12/22, 12:18
-
core-ci voted on patch set 11 V +1 04/12/22, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25950
-
Oli Bartsch updated the commit message in patch set 12 04/12/22, 12:49
-
core-ci voted on patch set 12 V +1 04/12/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25955
-
Nikita Hovratov voted on patch set 12 V +1 CR +1 04/12/22, 13:53
-
Stefan Bürk voted on patch set 12 CR -1 04/12/22, 16:07
-
Susi Moog commented on patch set 12 04/12/22, 16:08
-
Stefan Bürk commented on patch set 12 V +1 CR +1 04/12/22, 16:23
DatetimeElement.php:133ReplyInteger eval is 'integer'. And from the commit message: ``` - in case no native type is used - the `eval=int` option is removed and the value is always handled as integer. ``` and also the comment states it so, and the whol removing of 'int' i would say it's correct to use integer here. would be weired why should be 'int' here, if it got filter out and removed through the patch. -
Oli Bartsch commented on patch set 12 04/12/22, 16:23
DatetimeElement.php:133Reply"int" is removed with this patch. The "integer" eval is only internal handling for form engine, see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74205/12/Build/Sources/TypeScript/backend/form-engine-validation.ts#b475 "integer" has been introduced with TCA type "number". -
Susi Moog commented on patch set 12 04/12/22, 16:52
DatetimeElement.php:133Replyah, so I'm just old ;) Thanks for the explanation, I'll try to keep up more in the future. -
Nikita Hovratov commented on patch set 12 04/12/22, 17:02
DatetimeElement.php:133ReplyThis just got changed a week ago or so ;) -
Benni Mack voted on patch set 12 V +1 CR +1 04/12/22, 18:53
-
Oli Bartsch voted on patch set 12 V +2 CR +2 04/12/22, 19:36
-
Oli Bartsch merged patch set 13 04/12/22, 19:36
DatetimeElement.php:133