Review main Merged Breaking

74205[!!!][TASK] Remove eval=int from type=datetime

Oli Bartsch CR +2 V +2 Hard +209 −106 updated 04/12/22, 19:36

Commit message

TCA type "datetime" allowed the value to be a native
type (with `dbType`), a int with `eval=int` or a
simple string. Since the value is always a timestamp
- in case no native type is used - the `eval=int`
option is removed and the value is always handled
as integer.

Note: Due to various problems with migration of existing
fields, this patch does not yet enforce the database
field to be of type "integer". This will be done step
by step in further patches, e.g.
https://review.typo3.org/c/Packages/TYPO3.CMS/+/74281

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 27

Show 7 more files

Review log 2638

Show 713 earlier messages
  1. Oli Bartsch uploaded patch set 1 04/06/22, 22:29

  2. core-ci voted on patch set 1 V -1 04/06/22, 22:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25703

  3. Oli Bartsch uploaded patch set 2 04/07/22, 10:07

  4. core-ci voted on patch set 2 V -1 04/07/22, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25724

  5. Oli Bartsch rebased onto patch set 3 04/07/22, 12:13

  6. core-ci voted on patch set 3 V -1 04/07/22, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25736

  7. Oli Bartsch uploaded patch set 4 04/07/22, 18:31

  8. core-ci voted on patch set 4 V -1 04/07/22, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25789

  9. Oli Bartsch uploaded patch set 5 04/08/22, 22:33

  10. core-ci voted on patch set 5 V -1 04/08/22, 22:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25870

  11. Oli Bartsch uploaded patch set 6 04/08/22, 23:15

  12. core-ci voted on patch set 6 V -1 04/08/22, 23:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25871

  13. Oli Bartsch uploaded patch set 7 04/11/22, 09:28

  1. core-ci voted on patch set 7 V +1 04/11/22, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25924

  2. Oli Bartsch uploaded patch set 8 04/11/22, 11:05

  3. core-ci voted on patch set 8 V +1 04/11/22, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25925

  4. Oli Bartsch updated the commit message in patch set 9 04/11/22, 15:21

  5. core-ci voted on patch set 9 V +1 04/11/22, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25928

  6. Benni Mack voted on patch set 9 V +1 CR +1 04/11/22, 18:32

  7. Nikita Hovratov uploaded patch set 10 04/12/22, 07:23

  8. Nikita Hovratov voted on patch set 10 V +1 CR +1 04/12/22, 07:26

  9. core-ci voted on patch set 10 V +1 04/12/22, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25942

  10. Georg Ringer voted on patch set 10 V +1 CR +1 04/12/22, 07:36

  11. Oli Bartsch voted on patch set 10 CR -1 04/12/22, 08:28

  12. Oli Bartsch uploaded patch set 11 04/12/22, 12:18

  13. core-ci voted on patch set 11 V +1 04/12/22, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25950

  14. Oli Bartsch updated the commit message in patch set 12 04/12/22, 12:49

  15. core-ci voted on patch set 12 V +1 04/12/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25955

  16. Nikita Hovratov voted on patch set 12 V +1 CR +1 04/12/22, 13:53

  17. Stefan Bürk voted on patch set 12 CR -1 04/12/22, 16:07

  18. Susi Moog commented on patch set 12 04/12/22, 16:08

    DatetimeElement.php:133

    shouldn't this be "int"?
  19. Stefan Bürk commented on patch set 12 V +1 CR +1 04/12/22, 16:23

    DatetimeElement.php:133 Reply

    Integer eval is 'integer'. And from the commit message: ``` - in case no native type is used - the `eval=int` option is removed and the value is always handled as integer. ``` and also the comment states it so, and the whol removing of 'int' i would say it's correct to use integer here. would be weired why should be 'int' here, if it got filter out and removed through the patch.
  20. Oli Bartsch commented on patch set 12 04/12/22, 16:23

    DatetimeElement.php:133 Reply

    "int" is removed with this patch. The "integer" eval is only internal handling for form engine, see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74205/12/Build/Sources/TypeScript/backend/form-engine-validation.ts#b475 "integer" has been introduced with TCA type "number".
  21. Susi Moog commented on patch set 12 04/12/22, 16:52

    DatetimeElement.php:133 Reply

    ah, so I'm just old ;) Thanks for the explanation, I'll try to keep up more in the future.
  22. Nikita Hovratov commented on patch set 12 04/12/22, 17:02

    DatetimeElement.php:133 Reply

    This just got changed a week ago or so ;)
  23. Benni Mack voted on patch set 12 V +1 CR +1 04/12/22, 18:53

  24. Oli Bartsch voted on patch set 12 V +2 CR +2 04/12/22, 19:36

  25. Oli Bartsch merged patch set 13 04/12/22, 19:36