Review main Merged

74212[FEATURE] Add link to backend in admin panel

Susi Moog CR +2 V +2 Normal +101 −19 updated 04/08/22, 04:27

Commit message

Thanks to backend routing, we are now able to provide a
direct link to the currently rendered backend page via
the admin panel.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1115

  1. Susi Moog uploaded patch set 1 04/07/22, 08:17

  2. core-ci voted on patch set 1 V +1 04/07/22, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25717

  3. Andreas Kienast uploaded patch set 2 04/07/22, 10:43

  4. core-ci voted on patch set 2 V -1 04/07/22, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25726

  5. Susi Moog uploaded patch set 3 04/07/22, 11:46

  6. Susi Moog marked it ready for review 04/07/22, 11:50

  7. core-ci voted on patch set 3 V -1 04/07/22, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25730

  8. Benjamin Franzke commented on patch set 3 CR -1 04/07/22, 12:07

    on it, will push an update.

    adminpanel.scss:235

    There results in 2px border between "open page in backend", and the menu toggle has a right border, while the typo3-icon (on the very left) doesn't have a left border.

    MainController.php:151

    UriBuilder is already injected, no need for makeInstance.
  9. Benjamin Franzke uploaded patch set 4 04/07/22, 12:19

  10. Benjamin Franzke commented on patch set 4 04/07/22, 12:19

    Issue number incorrect. Adapted to #97326 RST was alrighty correct.

    adminpanel.scss:235 Reply

    Done

    MainController.php:151 Reply

    Done

    backend.js:15 Unresolved

    What issue does this address? Did you face any wrong `window.name` override? I'm asking because I'd like to whether we could drop `window.name = ''` at some point, so I'm interested in cases where this can actually be driven into problems.
  11. core-ci voted on patch set 4 V +1 04/07/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25737

  12. Susi Moog commented on patch set 4 04/07/22, 14:21

    @Benjamin Thanks a lot!
  13. Stefan Bürk voted on patch set 4 V +1 CR +1 04/07/22, 22:08

  14. Benjamin Franzke voted on patch set 4 V +2 CR +2 04/08/22, 04:27

  15. Benjamin Franzke merged patch set 5 04/08/22, 04:27