74212[FEATURE] Add link to backend in admin panel
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/Sass/adminpanel.scss2+10 −4
- typo3/sysext/adminpanel/Classes/Controller/MainController.php2+16 −0
- typo3/sysext/adminpanel/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/adminpanel/Resources/Private/Templates/Main.html+43 −13
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/backend.js1+3 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97326-OpenBackendPageFromAdminPanel.rstnew+25 −0
Review log 1115
-
Susi Moog uploaded patch set 1 04/07/22, 08:17
-
core-ci voted on patch set 1 V +1 04/07/22, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25717
-
Andreas Kienast uploaded patch set 2 04/07/22, 10:43
-
core-ci voted on patch set 2 V -1 04/07/22, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25726
-
Susi Moog uploaded patch set 3 04/07/22, 11:46
-
Susi Moog marked it ready for review 04/07/22, 11:50
-
core-ci voted on patch set 3 V -1 04/07/22, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25730
-
Benjamin Franzke commented on patch set 3 CR -1 04/07/22, 12:07
on it, will push an update.adminpanel.scss:235There results in 2px border between "open page in backend", and the menu toggle has a right border, while the typo3-icon (on the very left) doesn't have a left border.MainController.php:151UriBuilder is already injected, no need for makeInstance. -
Benjamin Franzke uploaded patch set 4 04/07/22, 12:19
-
Benjamin Franzke commented on patch set 4 04/07/22, 12:19
Issue number incorrect. Adapted to #97326 RST was alrighty correct.adminpanel.scss:235ReplyDoneMainController.php:151ReplyDonebackend.js:15UnresolvedWhat issue does this address? Did you face any wrong `window.name` override? I'm asking because I'd like to whether we could drop `window.name = ''` at some point, so I'm interested in cases where this can actually be driven into problems. -
core-ci voted on patch set 4 V +1 04/07/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25737
-
Susi Moog commented on patch set 4 04/07/22, 14:21
@Benjamin Thanks a lot! -
Stefan Bürk voted on patch set 4 V +1 CR +1 04/07/22, 22:08
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 04/08/22, 04:27
-
Benjamin Franzke merged patch set 5 04/08/22, 04:27