Review main Merged

74213[BUGFIX] Add missing translation default in About module

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 04/07/22, 12:16

Commit message

Modules can use static strings instead of locallang
labels. Therefore, all usages must also define the
value as "default" to prevent a RuntimeException.

This is now fixed in the About module.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oli Bartsch uploaded patch set 1 04/07/22, 09:41

  2. core-ci voted on patch set 1 V +1 04/07/22, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25723

  3. Benjamin Franzke voted on patch set 1 V +1 CR +1 04/07/22, 11:36

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 04/07/22, 12:15

  5. Andreas Kienast merged patch set 2 04/07/22, 12:16