Review 11.5 Merged

74214[BUGFIX] Fix duration determination in Notification.showMessage()

Benjamin Franzke CR +2 V +2 Easy +5 −4 updated 04/07/22, 12:27

Commit message

The determination of the duration used in Notification.showMessage() now
takes `SeverityEnum.error` into account and sets the duration to 0,
which is the same behavior when using `Notification.error()`.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 23

  1. Benjamin Franzke uploaded patch set 1 04/07/22, 11:49

  2. core-ci voted on patch set 1 V +1 04/07/22, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25731

  3. Benjamin Franzke merged patch set 2 04/07/22, 12:27