Review main Abandoned

74219[WIP][TASK] Connect label and legend with form fields

Michael Telgkamp CR 0 V 0 Hard +601 −130 updated 06/26/23, 17:36

Commit message

* Concerns form engine only
* Deprecate rendering the label by the
  PaletteAndSingleContainer class
* Use fieldset/legend for grouping elements only
* Use label with for attribute for other elements
* remove SingleFieldContainer and move functionality to
  PaletteAndSingleContainer

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 35

Show 15 more files

Review log 2337

Show 812 earlier messages
  1. Michael Telgkamp uploaded patch set 1 04/07/22, 16:49

  2. core-ci voted on patch set 1 V -1 04/07/22, 17:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25778

  3. Michael Telgkamp uploaded patch set 2 04/09/22, 13:30

  4. Michael Telgkamp wrote 04/09/22, 13:39

    Topic set to accessibility-10.4
  5. Michael Telgkamp wrote 04/09/22, 13:39

    Topic accessibility-10.4 removed
  6. Michael Telgkamp wrote 04/09/22, 13:40

    Topic set to accessibility
  7. core-ci voted on patch set 2 V -1 04/09/22, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25882

  8. Michael Telgkamp uploaded patch set 3 04/09/22, 14:13

  9. core-ci voted on patch set 3 V -1 04/09/22, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25883

  10. Michael Telgkamp uploaded patch set 4 05/21/22, 15:15

  11. core-ci voted on patch set 4 V -1 05/21/22, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27381

  12. Oliver Klee commented on patch set 4 05/21/22, 16:13

    UserSysFileStorageIsPublicElement.php:127

    I'd like to propose marking these comments with an @deprecated annotation so we can later search for that annotation to find stuff to remove.
  1. Michael Telgkamp uploaded patch set 5 05/21/22, 16:43

  2. Michael Telgkamp commented on patch set 5 CR -1 05/21/22, 16:52

    UserSysFileStorageIsPublicElement.php:127 Reply

    Thank you for your comment. I am happy to adjust the comments. Do you think this would be fine: `// @deprecated this value is only required until all labels are handled by the Elements. The functionality of labels being added by the container will be removed in v13, than this key needs to be removed` This patch will probably need more adjustments than this. I just added a patch for an error, but did not change the suggestion yet. I try to have the patch in a status that first reviews can be done. (Maybe I should have kept the WIP label?)
  3. core-ci voted on patch set 5 V -1 05/21/22, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27384

  4. Oliver Klee commented on patch set 5 05/21/22, 17:26

    UserSysFileStorageIsPublicElement.php:127 Reply

    Yes, thanks, that’s perfectly fine for this purpose! (And, yes, please do switch to WIP as long as the change is not ready for reviews yet.)
  5. Michael Telgkamp rebased onto patch set 6 06/17/22, 12:36

  6. core-ci voted on patch set 6 V -1 06/17/22, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28143

  7. Michael Telgkamp uploaded patch set 7 06/17/22, 13:13

  8. Michael Telgkamp uploaded patch set 8 06/17/22, 13:18

  9. core-ci voted on patch set 7 V -1 06/17/22, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28146

  10. core-ci voted on patch set 8 V -1 06/17/22, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28150

  11. Michael Telgkamp uploaded patch set 9 09/23/22, 14:36

  12. Michael Telgkamp uploaded patch set 10 09/23/22, 14:41

  13. Michael Telgkamp uploaded patch set 11 09/23/22, 14:46

  14. core-ci voted on patch set 9 V -1 09/23/22, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31481

  15. core-ci voted on patch set 10 V -1 09/23/22, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31482

  16. core-ci voted on patch set 11 V -1 09/23/22, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31483

  17. Michael Telgkamp uploaded patch set 12 09/23/22, 15:46

  18. core-ci voted on patch set 12 V -1 09/23/22, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31487

  19. Michael Telgkamp uploaded patch set 13 10/22/22, 13:34

  20. core-ci voted on patch set 13 V -1 10/22/22, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32618

  21. Stefan Bürk commented on patch set 13 10/22/22, 21:38

    UserSysFileStorageIsPublicElement.php:127 Reply

    We normally use more following syntax for deprecations: ``` // @deprecated since v12, will be removed with v13. // @deprecated since v12, will be removed with v13. <short explanation why/depending> // @deprecated since v12, will be removed with v13 if/after <short explanation why/depending>.... ```
  22. Michael Telgkamp uploaded patch set 14 10/23/22, 11:56

  23. core-ci voted on patch set 14 V -1 10/23/22, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32655

  24. Christian Kuhn commented on patch set 14 06/26/23, 17:36

    hey. we'll use https://review.typo3.org/c/Packages/TYPO3.CMS/+/79492 as new patch to solve the issue. i'll abandon here.
  25. Christian Kuhn abandoned the change 06/26/23, 17:36