Review main Merged

74220[BUGFIX] Prevent duplicate contextmenu in page tree nodes

Benjamin Franzke CR +2 V +2 Easy +2 −1 updated 04/07/22, 21:44

Commit message

The pagetree contextmenu click (right click) on node
backgrounds must not trigger both, the system
contextmenu and the TYPO3 context menu.
This has already been done for node-texts, but
the default event prevention was missing for
node backgrounds.
Therefore the native contextmenu is now also prevented
whenever the custom context menu is triggered.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Benjamin Franzke uploaded patch set 1 04/07/22, 17:08

  2. Benjamin Franzke wrote 04/07/22, 17:10

    Topic set to ui
  3. core-ci voted on patch set 1 V +1 04/07/22, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25780

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 04/07/22, 17:44

  5. Björn Jacob updated the commit message in patch set 2 04/07/22, 19:36

  6. Björn Jacob commented on patch set 2 04/07/22, 19:37

    Fixed a small typo in the commit message. Hope you don't mind.
  7. core-ci voted on patch set 2 V +1 04/07/22, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25792

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 04/07/22, 20:00

  9. Stefan Bürk voted on patch set 2 V +1 CR +1 04/07/22, 21:41

  10. Benjamin Franzke commented on patch set 2 V +2 CR +2 04/07/22, 21:44

    Reply

    nope, thx!
  11. Benjamin Franzke merged patch set 3 04/07/22, 21:44