Review main Merged

74221[BUGFIX] Restore "required" handling in SiteConfigurationController

Oli Bartsch CR +2 V +2 Normal +33 −20 updated 04/07/22, 21:32

Commit message

The SiteConfigurationController does its own evaluation
of field values based on the "fake" TCA. With #97035,
the required flag was added, which replaces the
corresponding "eval" option.

This patch adjusts the SiteConfigurationController
to handle the new option accordingly.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 04/07/22, 17:40

  2. core-ci voted on patch set 1 V +1 04/07/22, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25782

  3. Benjamin Franzke commented on patch set 1 V +1 CR +1 04/07/22, 18:02

    Tested by removing required=true from site-configuration, then opening the UI, adding the required=true, and submitting the form. Works 👍
  4. Oli Bartsch commented on patch set 1 04/07/22, 18:10

    Reply

    For other reviewers: It's also possible to just remove the "has-error" class from a required field (after removing the value).
  5. Benni Mack voted on patch set 1 V +1 CR +1 04/07/22, 21:00

  6. Stefan Bürk voted on patch set 1 V +1 CR +1 04/07/22, 21:24

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 04/07/22, 21:32

  8. Oli Bartsch merged patch set 2 04/07/22, 21:32