74221[BUGFIX] Restore "required" handling in SiteConfigurationController
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 78
-
Oli Bartsch uploaded patch set 1 04/07/22, 17:40
-
core-ci voted on patch set 1 V +1 04/07/22, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25782
-
Benjamin Franzke commented on patch set 1 V +1 CR +1 04/07/22, 18:02
Tested by removing required=true from site-configuration, then opening the UI, adding the required=true, and submitting the form. Works 👍 -
Oli Bartsch commented on patch set 1 04/07/22, 18:10
Reply
For other reviewers: It's also possible to just remove the "has-error" class from a required field (after removing the value). -
Benni Mack voted on patch set 1 V +1 CR +1 04/07/22, 21:00
-
Stefan Bürk voted on patch set 1 V +1 CR +1 04/07/22, 21:24
-
Oli Bartsch voted on patch set 1 V +2 CR +2 04/07/22, 21:32
-
Oli Bartsch merged patch set 2 04/07/22, 21:32