Review main Merged

74231[TASK] Inform about invalid content_from_pid

Oli Bartsch CR +2 V +2 Easy +18 −8 updated 04/11/22, 07:15

Commit message

The page module displays an information on pages,
which use the content_from_pid ("Show Content from Page")
feature. However, if the referenced page is invalid,
e.g. because it does no longer exist, the infobox
now informs the user accordingly like it's already
done for invalid shortcut configurations.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 04/08/22, 09:54

  2. core-ci voted on patch set 1 V +1 04/08/22, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25823

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 04/08/22, 20:53

  4. Georg Ringer voted on patch set 1 V +1 CR +1 04/09/22, 19:07

  5. Stefan Bürk commented on patch set 1 V +1 CR +1 04/09/22, 20:29

    Having this info is nice. However - maybe we should look into it, if we can have some info on the edit form of the page settings for the field also. It's not obious that there is something invalid set. But not for this patch, just as a reminder.
  6. Oli Bartsch voted on patch set 1 V +2 CR +2 04/11/22, 07:15

  7. Oli Bartsch merged patch set 2 04/11/22, 07:15