Review main Merged

74254[FEATURE] Refresh the look of pagemodule

Annett Jähnichen CR +2 V +2 Hard +428 −439 updated 11/28/22, 11:59

Commit message

The patch simplifies and optimizes the readability of the page module
interface. It is based on the UX Team's concept of improving user
experience for editors:
https://typo3.org/article/structured-content-initiative-feedback-wanted

Included changes:

* refactored and optimised underlying CSS for future adaptions
* visually simplified content element boxes and their header buttons
* visually differenciated hidden content elements with better opacity
  and dotted border
* placed the "new content element" buttons centered in preparation
  for further concept implementations in dedicated patches
* added a new button for content element context menu in the content
  element header right button bar

This patch was initiated by the UX Team and implemented by Benjamin
Kott.

Review

  • Code review CR +2 Done
    • Annett Jähnichen +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Annett Jähnichen +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 3

Files 20

Review log 4157

Show 2132 earlier messages
  1. Annett Jähnichen uploaded patch set 1 04/08/22, 11:04

  2. core-ci voted on patch set 1 V -1 04/08/22, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25829

  3. Annett Jähnichen uploaded patch set 2 04/08/22, 11:28

  4. core-ci voted on patch set 2 V -1 04/08/22, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25831

  5. Annett Jähnichen uploaded patch set 3 04/08/22, 12:17

  6. core-ci voted on patch set 3 V +1 04/08/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25833

  7. André Kraus voted on patch set 3 V +1 04/08/22, 12:38

  8. Benjamin Franzke uploaded patch set 4 04/08/22, 12:46

  9. core-ci voted on patch set 4 V +1 04/08/22, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25838

  10. Benjamin Franzke uploaded patch set 5 04/08/22, 13:00

  11. André Kraus voted on patch set 5 V +1 04/08/22, 13:08

  12. core-ci voted on patch set 5 V +1 04/08/22, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25839

  13. Lidia Demin voted on patch set 5 V +1 04/08/22, 13:38

  14. Benjamin Franzke uploaded patch set 6 04/08/22, 14:50

  15. Benjamin Franzke commented on patch set 6 04/08/22, 14:50

    I've rearranged the variables as var(--pagemodule-grid-spacing) had been used both for inner and outer cell spacings and we (or integrators) may want to increase the inner spacing at some point, and having distinct variables will ease that. Also I've added the element border radius to the dropzone as I think that a rounded element should be dropped into a rounded drop zone. Other than that there are no visual changes. Hope that's fine. BTW, I'd love if we could rethink the shadows at some point (it blurs on that gray background and white background already express elevation) – we could use use real rounded corners in material 3 style. So, adding a bit of breathing space and brave rounded corners let the new interface look even fresher (in my opinion). Try: :root { --pagemodule-grid-inner-spacing: 1.375rem; --pagemodule-grid-cell-header-size: 1.2em; --pagemodule-grid-cell-border-radius: 12px; --pagemodule-element-border-radius: 6px; --pagemodule-element-box-shadow: none; } See https://bnf.dev/~ben/uploads/073b8/typo3-page-refresh-the-look-with-shadows.png versus https://bnf.dev/~ben/uploads/c0b0e/typo3-page-refresh-the-look-more-spacing.png
  16. core-ci voted on patch set 6 V -1 04/08/22, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25845

  17. core-ci voted on patch set 6 V +1 04/08/22, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25845

  18. Stefan Bürk updated the commit message in patch set 7 04/08/22, 21:24

  19. core-ci voted on patch set 7 V -1 04/08/22, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25869

  20. core-ci voted on patch set 7 V +1 04/08/22, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25869

  21. Anja Leichsenring commented on patch set 7 04/09/22, 09:48

    still not happy with the move of delete button to the context menu. Reasons given beforehand.
  22. Georg Ringer voted on patch set 7 V +1 CR +1 04/09/22, 10:42

  23. Stefan Bürk commented on patch set 7 04/09/22, 10:47

    Reply

    Same to me. Not happy with delete button removal, and slipping in with other things which are good. Reason beforehand communicated. At least, it should be a dedicated patch only for the delete button.
  24. Oli Bartsch commented on patch set 7 04/11/22, 09:01

    Header.html:21

    Hi, one question from my side. There had been a similar patch, where we already improved this place (Using <button>, removing unused getters in the Grid*.php classes, etc.). Could we apply the corresponding improvements to this patch as well?
  25. Oli Bartsch commented on patch set 7 04/11/22, 09:01

    Header.html:21 Reply

  26. Rachel Foucard commented on patch set 7 04/12/22, 15:53

    Header.html:21 Reply

  27. Benni Mack commented on patch set 7 04/14/22, 20:33

    how about we do the "remove the delete button" in a separate followup change, so less things to discuss about?
  28. Annett Jähnichen uploaded patch set 8 04/19/22, 15:47

  29. core-ci voted on patch set 8 V +1 04/19/22, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26191

  30. Annett Jähnichen uploaded patch set 9 04/19/22, 16:13

  31. core-ci voted on patch set 9 V +1 04/19/22, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26193

  32. Annett Jähnichen commented on patch set 9 04/19/22, 16:45

    Reply

    Hi Benjamin, Thank you for your adjustments. That was great. Thanks also for your suggestions about the shadows on the content elements and the more rounded corners. We have taken a look at that. However, we would like to postpone these changes until a later date, when we have a better picture of the overall look and then see whether your suggestions fit in. But we will keep the suggestions in mind.

    Reply

    Hi Benni, We are currently waiting for some internal decisions.

    Header.html:21 Reply

    Hi Oliver, I have tried to make the changes. I'm not quite sure if that's what you meant.
  1. Oli Bartsch commented on patch set 9 04/19/22, 21:49

    Header.html:21 Reply

    Thanks for the adjustments. Actually, the related methods in the GridItem still exist. However, since this template might be overriden in custom extension code, I'm fine with keeping them for now.
  2. Benjamin Franzke uploaded patch set 10 04/20/22, 07:10

  3. Benjamin Franzke commented on patch set 10 04/20/22, 07:10

    Reply

    Ack.

    Header.html:21 Reply

    One additional note: So the button is using "btn-borderless btn-default" as class now, while the two other ones still use the "new" btn-invisible class. So it seems we could drop btn-invisible. One question remains: Do we want a border/background on hover? (or in other words: Just use "btn-borderless" or "btn-default btn-borderless" together?) If streamlined to use "btn-default btn-borderless" consequently and dropped btn-invisible. Feel free to remove btn-default again and just use btn-borderless if hover/focus-decoration was dropped on purpose.
  4. core-ci voted on patch set 10 V +1 04/20/22, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26217

  5. Simon Schaufelberger commented on patch set 10 04/30/22, 09:34

    would someone please extract the delete button change into a separate patch, so we can move forward here? I guess this is the only stopper right now.
  6. Annett Jähnichen commented on patch set 10 05/01/22, 12:40

    Reply

    I would like to get the expertise of the accessibility team again regarding the button classes and styling. Regarding the delete button, I want to coordinate with the UX team next week. Please give me the week. Then I will try to implement the changes
  7. Michael Telgkamp commented on patch set 10 V -1 05/03/22, 09:04

    Header.html:21

    The new button needs to have a label or text-content inside the button to describe the functionality. (e.g. Context menu)
  8. Annett Jähnichen uploaded patch set 11 05/03/22, 09:42

  9. Annett Jähnichen commented on patch set 11 05/03/22, 09:47

    Reply

    In order to make faster progress here, the UX team has decided to roll back the change for now.

    Reply

    We have refactored the button classes after consultation with Michael Telgkamp. The change to "remove the delete button" has been removed for now.

    Header.html:21 Reply

    For now we have used the following as aria-label LLL:EXT:backend/Resources/Private/Language/locallang_layout.xlf:advancedFunctions
  10. core-ci voted on patch set 11 V -1 05/03/22, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26763

  11. Annett Jähnichen uploaded patch set 12 05/03/22, 10:04

  12. core-ci voted on patch set 12 V +1 05/03/22, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26765

  13. Annett Jähnichen wrote 05/03/22, 13:09

    Removed reviewer Lidia Demin.
  14. Annett Jähnichen wrote 05/03/22, 13:09

    Removed reviewer André Kraus.
  15. Benjamin Franzke uploaded patch set 13 05/03/22, 19:29

  16. Benjamin Franzke commented on patch set 13 05/03/22, 19:29

    PageLayoutView.php:379

    PageLayoutView is deprecated and subject for removal, so I'd also be fine if we didn't touch it at all. But don't care much, so fine for me as is.
  17. core-ci voted on patch set 13 V -1 05/03/22, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26775

  18. Benjamin Franzke uploaded patch set 14 05/03/22, 19:51

  19. core-ci voted on patch set 14 V +1 05/03/22, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26776

  20. Georg Ringer voted on patch set 14 V +1 CR +1 05/03/22, 20:53

  21. Michael Telgkamp commented on patch set 14 V +1 CR +1 05/04/22, 07:08

    Thank you for the improvements. In terms of accessibility the newly added content is fine, for the existing parts there are still some issues, but they need to be handled by additional issues.
  22. Annett Jähnichen voted on patch set 14 V +2 CR +2 05/04/22, 07:25

  23. Annett Jähnichen merged patch set 15 05/04/22, 07:25

  24. Riny van Tiggelen commented on patch set 15 11/23/22, 20:04

    This patch removed the `t3-page-ce-warning` class which is used to highlight content elements within the "Inconsistent content detected in language ...." check: https://git.typo3.org/typo3/typo3/-/blob/main/typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php#L108-110
  25. Annett Jähnichen commented on patch set 15 11/28/22, 11:59

    Reply

    I created a forgeticket for the issue and would create another patch for the changes. https://forge.typo3.org/issues/99210