Review main Merged

74256[TASK] Add username to password recovery email salutation

Patrick Lenk CR +2 V +2 Easy +3 −3 updated 05/05/22, 16:25

Commit message

Currently, a user can reset their password, but never gets the information what their username is.
Many users forget their login username and reset their password using their email address.
This patch adds the username in brackets after the first and last name to the salutation in the recovery email.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Patrick Lenk uploaded patch set 1 04/08/22, 13:45

  2. core-ci voted on patch set 1 V -1 04/08/22, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25840

  3. Anja Leichsenring uploaded patch set 2 04/10/22, 07:54

  4. Anja Leichsenring commented on patch set 2 04/10/22, 07:56

    Hi Patrick, thank you for your patch. I adjusted the tests and moved the addition around, so it is only applied if a display name can actually be constructed. Also, I removed 10.4 from the releases line, because this is no critical bugfix.
  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 04/10/22, 07:56

  6. core-ci voted on patch set 2 V -1 04/10/22, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25898

  7. core-ci voted on patch set 2 V +1 04/10/22, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25898

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 04/10/22, 19:44

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 05/05/22, 16:18

  10. Stefan Bürk merged patch set 3 05/05/22, 16:25