74257[FEATURE] Allow keyboard navigation in live search
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/Sass/component/_autocomplete.scss+27 −6
- Build/Sources/Sass/scaffold/_toolbar.scss+18 −0
- Build/Sources/TypeScript/backend/toolbar/live-search.ts2+66 −64
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/LiveSearchToolbarItem.html+0 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/live-search.js+14 −12
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97347-LiveSearchKeyboardNavigation.rstnew+21 −0
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/SearchCest.php+12 −10
Review log 2841
Show 1016 earlier messages
-
Jochen Roth uploaded patch set 1 04/08/22, 14:20
-
Jochen Roth uploaded patch set 2 04/08/22, 14:25
-
core-ci voted on patch set 1 V -1 04/08/22, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25841
-
core-ci voted on patch set 2 V -1 04/08/22, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25842
-
Jochen Roth uploaded patch set 3 04/09/22, 11:57
-
core-ci voted on patch set 3 V +1 04/09/22, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25878
-
Jochen Roth rebased onto patch set 4 04/09/22, 12:19
-
core-ci voted on patch set 4 V +1 04/09/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25880
-
Jochen Roth uploaded patch set 5 04/10/22, 14:09
-
core-ci voted on patch set 5 V +1 04/10/22, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25902
-
Jochen Roth uploaded patch set 6 04/10/22, 20:58
-
Susi Moog commented on patch set 6 V +1 04/12/22, 15:54
Works nicely. If possible, it would be cool if there was some way to reach the "show all" button with the keyboard, too - but no blocker, this is already an improvement. (Cannot competently review scss though, so no vote on code) -
Stefan Bürk commented on patch set 6 04/12/22, 17:30
working - but some remarks. nice (love it). No blocker, but same as Susanne Moog wrote: reaching the show all button would be lovely. Using "tab" not working at it triggers the same as enter key on a selection (see comment)fixed - so [BUGFI] ? On the otherhand - it's more a [FEATURE] or not ?selecting with arrow keys and using "tab" does the same - intended ? -
Benni Mack commented on patch set 6 04/12/22, 18:53
live-search.ts:111seems like a div too much? -
Jochen Roth uploaded patch set 7 04/13/22, 08:56
-
core-ci voted on patch set 7 V +1 04/13/22, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25969
-
Jochen Roth uploaded patch set 8 04/13/22, 15:22
-
Jochen Roth commented on patch set 8 04/13/22, 15:25
Thanks everyone for the feedback. "Show all" is now reachable using the up/down arrow keys.Reply
AckReply
This was not intended. But could not find a way to configure this behavior. Seems a bit unnatural to me.live-search.ts:111ReplyDone -
core-ci voted on patch set 8 V -1 04/13/22, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25986
-
Jochen Roth uploaded patch set 9 04/14/22, 10:37
-
core-ci voted on patch set 9 V -1 04/14/22, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26014
-
Jochen Roth uploaded patch set 10 04/14/22, 10:55
-
core-ci voted on patch set 10 V +1 04/14/22, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26015
-
Jochen Roth uploaded patch set 11 04/14/22, 11:13
-
Benni Mack commented on patch set 11 04/14/22, 11:13
isn't this a feature? -
Jochen Roth updated the commit message in patch set 12 04/14/22, 11:16
-
Jochen Roth commented on patch set 12 04/14/22, 11:18
Reply
Yes, sort of. Change commit message to [FEATURE]Reply
Done -
Stefan Bürk commented on patch set 12 04/14/22, 11:19
Reply
FEATURE -> v12 only + Feature ReST file ? -
core-ci voted on patch set 12 V +1 04/14/22, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26017
-
Jochen Roth uploaded patch set 13 04/14/22, 11:39
-
Jochen Roth updated the commit message in patch set 14 04/14/22, 11:43
-
core-ci voted on patch set 13 V -1 04/14/22, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26018
-
Jochen Roth uploaded patch set 15 04/14/22, 11:53
-
core-ci voted on patch set 14 V -1 04/14/22, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26019
-
core-ci voted on patch set 15 V +1 04/14/22, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26021
-
Susi Moog commented on patch set 15 V +1 04/14/22, 12:12
lovely. -
Benni Mack voted on patch set 15 CR +1 04/14/22, 20:28
-
Benni Mack voted on patch set 15 V +1 04/16/22, 11:11
-
Stefan Bürk voted on patch set 15 V +1 CR +1 04/16/22, 15:03
-
Benni Mack voted on patch set 15 V +2 CR +2 04/16/22, 18:35
-
Benni Mack merged patch set 16 04/16/22, 18:35