Review main Merged

74257[FEATURE] Allow keyboard navigation in live search

Jochen Roth CR +2 V +2 Hard +159 −95 updated 04/16/22, 18:35

Commit message

Currently it's not possible to select a suggestion
of the live search.

This has been changed to add a highlight style and
load the content on "enter/tab"-key pressed.

This also tries to simplify the entire structure
which used to be a combination of bootstraps dropdown
and autocomplete which had to be in sync to show
and hide which turned out to be simply a mess.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2841

Show 1016 earlier messages
  1. Jochen Roth uploaded patch set 1 04/08/22, 14:20

  2. Jochen Roth uploaded patch set 2 04/08/22, 14:25

  3. core-ci voted on patch set 1 V -1 04/08/22, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25841

  4. core-ci voted on patch set 2 V -1 04/08/22, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25842

  5. Jochen Roth uploaded patch set 3 04/09/22, 11:57

  6. core-ci voted on patch set 3 V +1 04/09/22, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25878

  7. Jochen Roth rebased onto patch set 4 04/09/22, 12:19

  8. core-ci voted on patch set 4 V +1 04/09/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25880

  9. Jochen Roth uploaded patch set 5 04/10/22, 14:09

  10. core-ci voted on patch set 5 V +1 04/10/22, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25902

  11. Jochen Roth uploaded patch set 6 04/10/22, 20:58

  12. Susi Moog commented on patch set 6 V +1 04/12/22, 15:54

    Works nicely. If possible, it would be cool if there was some way to reach the "show all" button with the keyboard, too - but no blocker, this is already an improvement. (Cannot competently review scss though, so no vote on code)
  13. Stefan Bürk commented on patch set 6 04/12/22, 17:30

    working - but some remarks. nice (love it). No blocker, but same as Susanne Moog wrote: reaching the show all button would be lovely. Using "tab" not working at it triggers the same as enter key on a selection (see comment)
    fixed - so [BUGFI] ? On the otherhand - it's more a [FEATURE] or not ?
    selecting with arrow keys and using "tab" does the same - intended ?
  14. Benni Mack commented on patch set 6 04/12/22, 18:53

    live-search.ts:111

    seems like a div too much?
  15. Jochen Roth uploaded patch set 7 04/13/22, 08:56

  16. core-ci voted on patch set 7 V +1 04/13/22, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25969

  1. Jochen Roth uploaded patch set 8 04/13/22, 15:22

  2. Jochen Roth commented on patch set 8 04/13/22, 15:25

    Thanks everyone for the feedback. "Show all" is now reachable using the up/down arrow keys.

    Reply

    Ack

    Reply

    This was not intended. But could not find a way to configure this behavior. Seems a bit unnatural to me.

    live-search.ts:111 Reply

    Done
  3. core-ci voted on patch set 8 V -1 04/13/22, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25986

  4. Jochen Roth uploaded patch set 9 04/14/22, 10:37

  5. core-ci voted on patch set 9 V -1 04/14/22, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26014

  6. Jochen Roth uploaded patch set 10 04/14/22, 10:55

  7. core-ci voted on patch set 10 V +1 04/14/22, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26015

  8. Jochen Roth uploaded patch set 11 04/14/22, 11:13

  9. Benni Mack commented on patch set 11 04/14/22, 11:13

    isn't this a feature?
  10. Jochen Roth updated the commit message in patch set 12 04/14/22, 11:16

  11. Jochen Roth commented on patch set 12 04/14/22, 11:18

    Reply

    Yes, sort of. Change commit message to [FEATURE]

    Reply

    Done
  12. Stefan Bürk commented on patch set 12 04/14/22, 11:19

    Reply

    FEATURE -> v12 only + Feature ReST file ?
  13. core-ci voted on patch set 12 V +1 04/14/22, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26017

  14. Jochen Roth uploaded patch set 13 04/14/22, 11:39

  15. Jochen Roth updated the commit message in patch set 14 04/14/22, 11:43

  16. core-ci voted on patch set 13 V -1 04/14/22, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26018

  17. Jochen Roth uploaded patch set 15 04/14/22, 11:53

  18. core-ci voted on patch set 14 V -1 04/14/22, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26019

  19. core-ci voted on patch set 15 V +1 04/14/22, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26021

  20. Susi Moog commented on patch set 15 V +1 04/14/22, 12:12

    lovely.
  21. Benni Mack voted on patch set 15 CR +1 04/14/22, 20:28

  22. Benni Mack voted on patch set 15 V +1 04/16/22, 11:11

  23. Stefan Bürk voted on patch set 15 V +1 CR +1 04/16/22, 15:03

  24. Benni Mack voted on patch set 15 V +2 CR +2 04/16/22, 18:35

  25. Benni Mack merged patch set 16 04/16/22, 18:35