74258[BUGFIX] Prevent duplicate page tree items when entry points intersect
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Silvia Bigler +1
-
Verified V +2 Done
- Stefan Bürk +2
- Silvia Bigler +1
- core-ci +1 CI
Issues 3
Files 5
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php+5 −0
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+2 −50
- typo3/sysext/backend/Tests/Functional/Tree/Repository/Fixtures/Tree/NormalizeTreeTrait.phpnew+68 −0
- typo3/sysext/backend/Tests/Functional/Tree/Repository/Fixtures/PageTree.csv2new+9 −0
- typo3/sysext/backend/Tests/Functional/Tree/Repository/PageTreeRepositoryTest.php2new+240 −0
Review log 2130
Show 35 earlier messages
-
Nikita Hovratov uploaded patch set 1 04/08/22, 15:51
-
core-ci voted on patch set 1 V -1 04/08/22, 16:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25847
-
Nikita Hovratov uploaded patch set 2 04/08/22, 16:29
-
core-ci voted on patch set 2 V +1 04/08/22, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25849
-
Stefan Bürk rebased onto patch set 3 07/07/22, 21:25
-
core-ci voted on patch set 3 V +1 07/07/22, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28732
-
Nikita Hovratov commented on patch set 3 07/07/22, 21:47
thanks for rebasing -
Simon Schaufelberger commented on patch set 3 07/08/22, 02:15
NormalizeTreeTrait.php:12annotations can be dropped if they don't add any meaningful information -
Nikita Hovratov uploaded patch set 4 07/08/22, 05:32
-
Nikita Hovratov commented on patch set 4 07/08/22, 05:33
NormalizeTreeTrait.php:12ReplyDone -
core-ci voted on patch set 4 V +1 07/08/22, 05:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28738
-
Stefan Bürk commented on patch set 4 07/08/22, 20:45
PageTree.csv:3Can we use "real world" sorting values for pages fixture, instead of "simplified" sortings ? -
Simon Schaufelberger wrote 07/08/22, 20:57
Removed cc Simon Schaufelberger. -
Nikita Hovratov uploaded patch set 5 07/09/22, 17:11
-
Nikita Hovratov commented on patch set 5 07/09/22, 17:11
PageTree.csv:3ReplyDone -
core-ci voted on patch set 5 V +1 07/09/22, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28824
-
Stefan Bürk commented on patch set 5 CR -1 07/09/22, 19:14
On it ...Let's add 10.4 - patch applies without hassle, and so people can at least use composer patches until a new 10.4 release is published. It's also lightweight enough.NormalizeTreeTrait.php:4MIssing File header...NormalizeTreeTrait.php:5"Fixture" classes should resists under a "Fixture" folder to have a separation from pure test case files.PageTreeRepositoryTest.php:4Missing file header ... -
Stefan Bürk uploaded patch set 6 07/09/22, 19:41
-
Stefan Bürk commented on patch set 6 07/09/22, 19:42
Reply
DoneNormalizeTreeTrait.php:4ReplyDoneNormalizeTreeTrait.php:5ReplyDonePageTreeRepositoryTest.php:4ReplyDone -
core-ci voted on patch set 6 V -1 07/09/22, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28825
-
core-ci voted on patch set 6 V +1 07/09/22, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28825
-
Stefan Bürk voted on patch set 6 V +1 CR +1 07/09/22, 20:00
-
Stefan Bürk rebased onto patch set 7 07/18/22, 21:54
-
core-ci voted on patch set 7 V -1 07/18/22, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29342
-
Nikita Hovratov uploaded patch set 8 07/19/22, 07:14
-
core-ci voted on patch set 8 V +1 07/19/22, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29349
-
Stefan Bürk voted on patch set 8 V +1 CR +1 07/19/22, 07:53
-
Silvia Bigler voted on patch set 8 V +1 CR +1 07/20/22, 09:35
-
Stefan Bürk voted on patch set 8 V +2 CR +2 07/25/22, 21:14
-
Stefan Bürk merged patch set 9 07/25/22, 21:14