Review main Merged

74259[BUGFIX] Responsive form actions for column selector

Nikita Hovratov CR +2 V +2 Easy +8 −11 updated 04/19/22, 09:50

Commit message

The CSS attribute "position: fixed" is replaced by
"position: sticky", which does not get completely
removed from the layout flow, while keeping the
sticky behaviour. The sticky attribute is well
adapted in most modern browsers and is therefore
safe to use.

The fixed width is also removed, enabling the
content to wrap on smaller devices.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1217

  1. Nikita Hovratov uploaded patch set 1 04/08/22, 19:08

  2. core-ci voted on patch set 1 V +1 04/08/22, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25855

  3. Oli Bartsch uploaded patch set 2 04/08/22, 19:23

  4. Oli Bartsch commented on patch set 2 V +1 CR +1 04/08/22, 19:23

    Thanks!
  5. core-ci voted on patch set 2 V -1 04/08/22, 19:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25858

  6. Oli Bartsch uploaded patch set 3 04/08/22, 19:45

  7. core-ci voted on patch set 3 V +1 04/08/22, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25859

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 04/08/22, 20:04

  9. Benni Mack commented on patch set 3 04/17/22, 12:00

    Care to rebase?
  10. Nikita Hovratov uploaded patch set 4 04/17/22, 12:17

  11. core-ci voted on patch set 4 V +1 04/17/22, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26104

  12. Stefan Bürk commented on patch set 4 V +1 CR +1 04/17/22, 17:13

    Some notes: * could not reproduce this on monorepo/main - neighter with "chrome/linux" nor "firefox/linux" -> maybe due not able to get language packs installed and switch backend user to a language e.g. german (other issue, maybe related to not done settings for crowdin yet etc) * reproduced on v11 monorepo, but only with firefox/linux. on chrome/linux there was no two lines for the sticky bar / filter bar. anyhow, patch fixes it where I could reproduce it it. And from my side it seems to be a legit fix for this kind of issue.
  13. Benni Mack uploaded patch set 5 04/18/22, 13:47

  14. core-ci voted on patch set 5 V +1 04/18/22, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26146

  15. Stefan Bürk voted on patch set 5 V +1 CR +1 04/18/22, 15:59

  16. Oli Bartsch voted on patch set 5 V +2 CR +2 04/19/22, 09:50

  17. Oli Bartsch merged patch set 6 04/19/22, 09:50