74260[BUGFIX] Converting Queries ignores offset and limit
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1014
-
Christian Seyfferth uploaded patch set 1 04/08/22, 20:07
-
Stefan Bürk updated the commit message in patch set 2 04/08/22, 20:55
-
Stefan Bürk commented on patch set 2 04/08/22, 21:00
Removed 9.5 from releases. This version is not supported anymore by the community . Backports only to activly supported branches. And for branches in security bugfix mode (10.4) only for hard bugfixes and security related patches. Not sure yet about 10.4. This changes a long standing method people may have already worked around successfully. Maybe not worth to change it for v10 then. However, we should add tests for this to cover it. -
core-ci voted on patch set 1 V -1 04/08/22, 21:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25860
-
core-ci voted on patch set 2 V -1 04/08/22, 21:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25863
-
Stefan Bürk commented on patch set 2 04/09/22, 10:51
Unresolved
Oversaw that it was your first patch. Thanks for it anyway. There are things which needs to be addressed. Let me/us know if you need some help with it how to get this patch moved further. Eithere here or in the Typo3 slack in the #typo3-cms-coredev channel. -
Christian Seyfferth commented on patch set 3 04/09/22, 19:24
Published edit on patch set 2. -
core-ci voted on patch set 3 V -1 04/09/22, 20:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25885
-
Stefan Bürk uploaded patch set 4 04/11/22, 20:33
-
Stefan Bürk commented on patch set 4 CR -1 04/11/22, 20:38
Unresolved
Okay, I think we have a little problem here. I can understand why this patch/change has been created. But this change has broader influence than maybe initial visible. The convert method is also used by another method, which is deeply used in extbase repositories. And thus changing behaviours of them and the core provided QueryPaginator for example. I have adjusted the unit tests, but failing functionals shows the side-effects. So I doubt that we can do this in this form as "bugfix". So putting -1 for now on it. Need deeper investivate this the next days. -
core-ci voted on patch set 4 V -1 04/11/22, 20:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25936
-
Benni Mack commented on patch set 4 04/14/23, 10:03
any update here? As v10.4 will soon be out of our support, we should adapt or abandon this change. -
Benni Mack updated the commit message in patch set 5
CR -1V -105/03/23, 09:45 -
Benni Mack abandoned the change 07/07/23, 14:32
abandoning this change for the time being, due to lack of feedback. can be restored later