Review main Merged

74261[BUGFIX] Translate additional scheduler field labels in controller

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 04/08/22, 21:00

Commit message

The "langLabel" field might be already translated
instead of a "LLL-string". This causes the
TranslateViewHelper to throw an exception, because
it doesn't know what to do.

The better way is to translate this field already
in the controller, where LanguageService can be used
directly, without failing if no extension key can
be found.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Nikita Hovratov uploaded patch set 1 04/08/22, 20:08

  2. Oli Bartsch commented on patch set 1 04/08/22, 20:11

    IMO the better way would be to use the "default" argument (or tag content).
  3. Nikita Hovratov commented on patch set 1 04/08/22, 20:19

    Reply

    Default would work, but seems more like a misuse to me. Any strong argument to not translate it with LanguageService directly?
  4. core-ci voted on patch set 1 V +1 04/08/22, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25861

  5. Oli Bartsch commented on patch set 1 V +1 CR +1 04/08/22, 20:23

    Reply

    Sure, both ways work. No strong argument, just my personal preference. Therefore, I'm fine if you want to keep it this way. Thanks for fixing.
  6. Stefan Bürk voted on patch set 1 V +1 CR +1 04/08/22, 20:53

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 04/08/22, 21:00

  8. Oli Bartsch merged patch set 2 04/08/22, 21:00