74261[BUGFIX] Translate additional scheduler field labels in controller
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 2
Review log 78
-
Nikita Hovratov uploaded patch set 1 04/08/22, 20:08
-
Oli Bartsch commented on patch set 1 04/08/22, 20:11
IMO the better way would be to use the "default" argument (or tag content). -
Nikita Hovratov commented on patch set 1 04/08/22, 20:19
Reply
Default would work, but seems more like a misuse to me. Any strong argument to not translate it with LanguageService directly? -
core-ci voted on patch set 1 V +1 04/08/22, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25861
-
Oli Bartsch commented on patch set 1 V +1 CR +1 04/08/22, 20:23
Reply
Sure, both ways work. No strong argument, just my personal preference. Therefore, I'm fine if you want to keep it this way. Thanks for fixing. -
Stefan Bürk voted on patch set 1 V +1 CR +1 04/08/22, 20:53
-
Oli Bartsch voted on patch set 1 V +2 CR +2 04/08/22, 21:00
-
Oli Bartsch merged patch set 2 04/08/22, 21:00