Review main Merged

74262[FOLLOWUP] Remove visible field value in ColorElement

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 04/09/22, 09:45

Commit message

Like for all other elements using the visible / hidden
input field strategy, the visible field is initialized with
an empty string. The $itemValue is only added to the
hidden field.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oli Bartsch uploaded patch set 1 04/08/22, 23:40

  2. core-ci voted on patch set 1 V +1 04/08/22, 23:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25872

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 04/09/22, 08:38

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 04/09/22, 09:45

  5. Anja Leichsenring merged patch set 2 04/09/22, 09:45