74265[TASK] Deprecate ExpressionBuilder methods andX() and orX()
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php+10 −10
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+4 −4
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-97354-ExpressionBuilderMethodsAndXAndOrX.rstnew+76 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+14 −0
Review log 2027
Show 2 earlier messages
-
core-ci voted on patch set 1 V +1 04/09/22, 23:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25890
-
core-ci voted on patch set 2 V +1 04/09/22, 23:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25891
-
Stefan Bürk wrote 04/10/22, 01:24
Topic set to doctrine/dbal -
Nikita Hovratov uploaded patch set 3 04/10/22, 07:50
-
core-ci voted on patch set 3 V +1 04/10/22, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25897
-
Nikita Hovratov voted on patch set 3 V +1 CR +1 04/11/22, 14:58
-
Oliver Klee commented on patch set 3 04/12/22, 19:08
Please also let’s add @deprecated annotations to the deprecated methods so IDEs like PhpStorm can visually warn when a dev is writing a call to one of the deprecated methods. -
Nikita Hovratov commented on patch set 3 V 0 CR 0 04/12/22, 19:15
Reply
good point -
Stefan Bürk uploaded patch set 4 04/12/22, 20:34
-
Stefan Bürk commented on patch set 4 04/12/22, 20:35
Reply
Ack. Good point. -
Stefan Bürk commented on patch set 4 04/12/22, 20:36
Reply
Done. -
core-ci voted on patch set 4 V +1 04/12/22, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25961
-
Oliver Klee voted on patch set 4 CR +1 04/12/22, 21:09
-
Oli Bartsch uploaded patch set 5 04/12/22, 22:16
-
Oli Bartsch voted on patch set 5 V +1 CR +1 04/12/22, 22:16
-
core-ci voted on patch set 5 V +1 04/12/22, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25964
-
Oliver Klee voted on patch set 5 CR +1 04/12/22, 22:51
-
Oli Bartsch uploaded patch set 6 04/13/22, 06:51
-
Oli Bartsch voted on patch set 6 V +1 CR +1 04/13/22, 06:51
-
core-ci voted on patch set 6 V -1 04/13/22, 06:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25968
-
core-ci voted on patch set 6 V +1 04/13/22, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25968
-
Nikita Hovratov voted on patch set 6 V +1 CR +1 04/13/22, 07:18
-
Oliver Klee voted on patch set 6 CR +1 04/13/22, 08:06
-
Oli Bartsch voted on patch set 6 V +2 CR +2 04/13/22, 09:43
-
Oli Bartsch merged patch set 7 04/13/22, 09:43