Review main Merged

74265[TASK] Deprecate ExpressionBuilder methods andX() and orX()

Stefan Bürk CR +2 V +2 Normal +104 −14 updated 04/13/22, 09:43

Commit message

doctrine/dbal has deprecated multiple methods in the
class 'ExpressionBuilder'. Luckily, the core already
implements a facade of this class and the proper
forward-compatible implementation has been provided
with #97081 to pave a seamless migration path for
extension developers, which have to support
multi-core versions without deprecation messages.

Core usages have been replaced with #97110.
Additionally, usages in typo3/cms-styleguide have
been properly replaced as a preparation for the
deprecation with:
https://github.com/TYPO3/styleguide/pull/303

This patch finally deprecates these methods to avoid
further usage.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 2027

Show 2 earlier messages
  1. Stefan Bürk uploaded patch set 1 04/09/22, 23:19

  2. Stefan Bürk updated the commit message in patch set 2 04/09/22, 23:30

  1. core-ci voted on patch set 1 V +1 04/09/22, 23:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25890

  2. core-ci voted on patch set 2 V +1 04/09/22, 23:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25891

  3. Stefan Bürk wrote 04/10/22, 01:24

    Topic set to doctrine/dbal
  4. Nikita Hovratov uploaded patch set 3 04/10/22, 07:50

  5. core-ci voted on patch set 3 V +1 04/10/22, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25897

  6. Nikita Hovratov voted on patch set 3 V +1 CR +1 04/11/22, 14:58

  7. Oliver Klee commented on patch set 3 04/12/22, 19:08

    Please also let’s add @deprecated annotations to the deprecated methods so IDEs like PhpStorm can visually warn when a dev is writing a call to one of the deprecated methods.
  8. Nikita Hovratov commented on patch set 3 V 0 CR 0 04/12/22, 19:15

    Reply

    good point
  9. Stefan Bürk uploaded patch set 4 04/12/22, 20:34

  10. Stefan Bürk commented on patch set 4 04/12/22, 20:35

    Reply

    Ack. Good point.
  11. Stefan Bürk commented on patch set 4 04/12/22, 20:36

    Reply

    Done.
  12. core-ci voted on patch set 4 V +1 04/12/22, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25961

  13. Oliver Klee voted on patch set 4 CR +1 04/12/22, 21:09

  14. Oli Bartsch uploaded patch set 5 04/12/22, 22:16

  15. Oli Bartsch voted on patch set 5 V +1 CR +1 04/12/22, 22:16

  16. core-ci voted on patch set 5 V +1 04/12/22, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25964

  17. Oliver Klee voted on patch set 5 CR +1 04/12/22, 22:51

  18. Oli Bartsch uploaded patch set 6 04/13/22, 06:51

  19. Oli Bartsch voted on patch set 6 V +1 CR +1 04/13/22, 06:51

  20. core-ci voted on patch set 6 V -1 04/13/22, 06:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25968

  21. core-ci voted on patch set 6 V +1 04/13/22, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25968

  22. Nikita Hovratov voted on patch set 6 V +1 CR +1 04/13/22, 07:18

  23. Oliver Klee voted on patch set 6 CR +1 04/13/22, 08:06

  24. Oli Bartsch voted on patch set 6 V +2 CR +2 04/13/22, 09:43

  25. Oli Bartsch merged patch set 7 04/13/22, 09:43