Review main Merged

74271[TASK] Additionally removes dangling docker volumes with runTests.sh -u

Stefan Bürk CR +2 V +2 Easy +12 −4 updated 04/20/22, 20:18

Commit message

Over time dangling local anonymous docker volumes
pollutes local docker environments and consuming
space on core contributors discs.

This patch additionally removes dangling, unused
anonymous local docker volumes when updating core
testing images are requested with:

> Build/Scripts/runTests.sh -u

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2434

Show 59 earlier messages
  1. Stefan Bürk uploaded patch set 1 04/11/22, 20:00

  2. core-ci voted on patch set 1 V -1 04/11/22, 20:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25935

  3. core-ci voted on patch set 1 V +1 04/11/22, 20:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25935

  4. Stefan Bürk commented on patch set 1 CR -1 04/11/22, 21:53

    will make some further tests with/against .ddev ....
  5. Stefan Bürk uploaded patch set 2 04/15/22, 10:43

  6. Stefan Bürk commented on patch set 2 04/15/22, 10:45

    Reply

    Played arround with ddev. started/stopped, poweroff .... using this change to remove dangling, unused local volumes do not destroy projects. At least on my side. But I'm not a ddev user.
  7. core-ci voted on patch set 2 V +1 04/15/22, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26049

  8. Stefan Bürk uploaded patch set 3 04/15/22, 18:55

  9. core-ci voted on patch set 3 V +1 04/15/22, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26057

  1. Oli Bartsch uploaded patch set 4 04/15/22, 19:54

  2. Oli Bartsch commented on patch set 4 V +1 CR +1 04/15/22, 19:55

    Thanks a lot!
  3. core-ci voted on patch set 4 V +1 04/15/22, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26058

  4. Nikita Hovratov commented on patch set 4 04/16/22, 20:09

    > prune unused, dangling local volumes => 1910 lines wow, that's a lot :)
  5. Nikita Hovratov voted on patch set 4 V +1 04/16/22, 20:20

  6. Oliver Klee voted on patch set 4 V +1 04/20/22, 19:36

  7. Oliver Klee commented on patch set 4 04/20/22, 19:37

    Would it make sense to move this to (or also trigger this by) the clean command from https://review.typo3.org/c/Packages/TYPO3.CMS/+/74267?
  8. Jochen Roth commented on patch set 4 04/20/22, 19:40

    Shouldn't it be "pollutes"?
  9. Stefan Bürk updated the commit message in patch set 5 04/20/22, 19:41

  10. Jochen Roth commented on patch set 4 04/20/22, 19:42

    "unused"

    runTests.sh:195

    IMO should be "latest"
  11. Stefan Bürk commented on patch set 5 04/20/22, 19:45

    Reply

    The "clean" command was more meant for files only. Maybe "-s clean" may be added to some ci operations, and removing docker volumes there may have some sideeffects I wanted to kept separated.

    Reply

    Ack
  12. Oliver Klee voted on patch set 5 V +1 04/20/22, 19:47

  13. Stefan Bürk commented on patch set 6 04/20/22, 19:47

    Published edit on patch set 5.
  14. Stefan Bürk updated the commit message in patch set 7 04/20/22, 19:48

  15. Oliver Klee voted on patch set 7 V +1 04/20/22, 19:48

  16. Stefan Bürk commented on patch set 7 04/20/22, 19:51

    Reply

    Done

    runTests.sh:195 Reply

    Done
  17. Jochen Roth voted on patch set 7 V +1 CR +1 04/20/22, 19:54

  18. core-ci voted on patch set 5 V -1 04/20/22, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26243

  19. Oli Bartsch voted on patch set 7 V +1 CR +1 04/20/22, 20:00

  20. core-ci voted on patch set 5 V +1 04/20/22, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26243

  21. core-ci voted on patch set 6 V +1 04/20/22, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26245

  22. core-ci voted on patch set 7 V -1 04/20/22, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26246

  23. core-ci voted on patch set 7 V +1 04/20/22, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26246

  24. Oli Bartsch voted on patch set 7 V +2 CR +2 04/20/22, 20:18

  25. Oli Bartsch merged patch set 8 04/20/22, 20:18