74271[TASK] Additionally removes dangling docker volumes with runTests.sh -u
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2434
Show 59 earlier messages
-
Stefan Bürk uploaded patch set 1 04/11/22, 20:00
-
core-ci voted on patch set 1 V -1 04/11/22, 20:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25935
-
core-ci voted on patch set 1 V +1 04/11/22, 20:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25935
-
Stefan Bürk commented on patch set 1 CR -1 04/11/22, 21:53
will make some further tests with/against .ddev .... -
Stefan Bürk uploaded patch set 2 04/15/22, 10:43
-
Stefan Bürk commented on patch set 2 04/15/22, 10:45
Reply
Played arround with ddev. started/stopped, poweroff .... using this change to remove dangling, unused local volumes do not destroy projects. At least on my side. But I'm not a ddev user. -
core-ci voted on patch set 2 V +1 04/15/22, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26049
-
Stefan Bürk uploaded patch set 3 04/15/22, 18:55
-
core-ci voted on patch set 3 V +1 04/15/22, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26057
-
Oli Bartsch uploaded patch set 4 04/15/22, 19:54
-
Oli Bartsch commented on patch set 4 V +1 CR +1 04/15/22, 19:55
Thanks a lot! -
core-ci voted on patch set 4 V +1 04/15/22, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26058
-
Nikita Hovratov commented on patch set 4 04/16/22, 20:09
> prune unused, dangling local volumes => 1910 lines wow, that's a lot :) -
Nikita Hovratov voted on patch set 4 V +1 04/16/22, 20:20
-
Oliver Klee voted on patch set 4 V +1 04/20/22, 19:36
-
Oliver Klee commented on patch set 4 04/20/22, 19:37
Would it make sense to move this to (or also trigger this by) the clean command from https://review.typo3.org/c/Packages/TYPO3.CMS/+/74267? -
Jochen Roth commented on patch set 4 04/20/22, 19:40
Shouldn't it be "pollutes"? -
Stefan Bürk updated the commit message in patch set 5 04/20/22, 19:41
-
Jochen Roth commented on patch set 4 04/20/22, 19:42
"unused"runTests.sh:195IMO should be "latest" -
Stefan Bürk commented on patch set 5 04/20/22, 19:45
Reply
The "clean" command was more meant for files only. Maybe "-s clean" may be added to some ci operations, and removing docker volumes there may have some sideeffects I wanted to kept separated.Reply
Ack -
Oliver Klee voted on patch set 5 V +1 04/20/22, 19:47
-
Stefan Bürk commented on patch set 6 04/20/22, 19:47
Published edit on patch set 5. -
Stefan Bürk updated the commit message in patch set 7 04/20/22, 19:48
-
Oliver Klee voted on patch set 7 V +1 04/20/22, 19:48
-
Jochen Roth voted on patch set 7 V +1 CR +1 04/20/22, 19:54
-
core-ci voted on patch set 5 V -1 04/20/22, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26243
-
Oli Bartsch voted on patch set 7 V +1 CR +1 04/20/22, 20:00
-
core-ci voted on patch set 5 V +1 04/20/22, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26243
-
core-ci voted on patch set 6 V +1 04/20/22, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26245
-
core-ci voted on patch set 7 V -1 04/20/22, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26246
-
core-ci voted on patch set 7 V +1 04/20/22, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26246
-
Oli Bartsch voted on patch set 7 V +2 CR +2 04/20/22, 20:18
-
Oli Bartsch merged patch set 8 04/20/22, 20:18