Review main Merged

74276[DOCS] Rename undeclared argument "length" to "maxCharacters"

TYPO3com CR +2 V +2 Easy +1 −1 updated 04/12/22, 15:46

Commit message

The CropViewHelper does not have a "length" argument, but the
"maxCharacters" argument is mandatory. From the context it is clear that
the wrong argument was accidentally used here and that this needs to be
renamed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. TYPO3com uploaded patch set 1 04/12/22, 10:01

  2. core-ci voted on patch set 1 V +1 04/12/22, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25947

  3. Oliver Klee voted on patch set 1 CR +1 04/12/22, 10:26

  4. Oli Bartsch updated the commit message in patch set 2 04/12/22, 15:15

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 04/12/22, 15:15

  6. core-ci voted on patch set 2 V +1 04/12/22, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25956

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 04/12/22, 15:45

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 04/12/22, 15:46

  9. Oli Bartsch merged patch set 3 04/12/22, 15:46