Review main Abandoned

74278[TASK] Rename undeclared argument "length" to "maxCharacters"

TYPO3com CR 0 V 0 Easy +1 −1 updated 04/14/22, 18:28

Commit message

The CropViewHelper does not have a "length" argument, but the
"maxCharacters" argument is mandatory. From the context it is clear that
the wrong argument was accidentally used here and that this needs to be
renamed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 35

  1. TYPO3com uploaded patch set 1 04/12/22, 12:29

  2. core-ci voted on patch set 1 V +1 04/12/22, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25951

  3. Simon Schaufelberger voted on patch set 1 V +1 CR +1 04/12/22, 13:30

  4. Oli Bartsch abandoned the change 04/12/22, 15:10

  5. Simon Schaufelberger wrote 04/14/22, 18:28

    Removed reviewer Simon Schaufelberger with the following votes: * Verified+1 by Simon Schaufelberger * Code-Review+1 by Simon Schaufelberger