Review main Merged

74284[BUGFIX] Prevent PHP warnings in PageRouter

Oli Bartsch CR +2 V +2 Easy +7 −2 updated 04/14/22, 11:43

Commit message

In some situations, "_page" might not be set
in the Route. This patch prevents undefined
array key warnings and also makes the code
more readable.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 04/13/22, 10:38

  2. Oliver Klee commented on patch set 1 CR +1 04/13/22, 10:44

    Neat!
  3. core-ci voted on patch set 1 V +1 04/13/22, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25975

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 04/13/22, 13:27

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 04/13/22, 17:49

  6. Benni Mack voted on patch set 1 V +1 CR +1 04/14/22, 11:17

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 04/14/22, 11:43

  8. Oli Bartsch merged patch set 2 04/14/22, 11:43