Review main Abandoned

74285[WIP][TASK] TypoScript parser

Christian Kuhn CR 0 V 0 Hard +243 −57 updated 08/19/22, 13:06

Commit message

* todo: implement function value modifier hook/event
* maybe rename page.cache.<pid> syntax, since that is constant
  aware for identifiers and that's something we shouldn't support?
* {$foo} = bar needs hardening and should explode with good message,
  look up tests for current state
* foo < {$bar} needs hardening and should explode with good message,
  look up tests for current state
* cache behavior: changes on sys_template rows are transparent, changes
  on include files are not.
* docs reminder: a new condition after existing condition auto-closes
  existing condition, even if there is no [end]

Review

  • Code review CR 0
  • Verified V 0

Files 7

Review log 147257

Show 133232 earlier messages
  1. Christian Kuhn uploaded patch set 1 04/13/22, 11:01

  2. Christian Kuhn marked it work in progress 04/13/22, 11:01

  3. Christian Kuhn rebased onto patch set 2 04/13/22, 11:02

  4. core-ci voted on patch set 1 V -1 04/13/22, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25976

  5. core-ci voted on patch set 2 V -1 04/13/22, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25977

  6. Christian Kuhn uploaded patch set 3 04/13/22, 12:07

  7. core-ci voted on patch set 3 V -1 04/13/22, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25978

  8. Christian Kuhn uploaded patch set 4 04/19/22, 13:51

  9. core-ci voted on patch set 4 V +1 04/19/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26190

  10. Christian Kuhn uploaded patch set 5 04/20/22, 13:38

  11. core-ci voted on patch set 5 V +1 04/20/22, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26231

  12. crell commented on patch set 5 04/20/22, 17:43

    Token.php:23

    All of these can be made public readonly, and eliminate the methods. That's less code, less typing, and a very slight performance increase. (No method calls, which are more expensive than property reads.)

    TokenEnum.php:22

    The convention (that will become a FIG recommendation sooner or later) is to not ALL_CAPS enums. They should be CamelCase. I realize that's contrary to the typical token strategy, though, so I'm not sure if this is a justified exception. I'm honestly leaning no, but it's debatable.

    Tokenizer.php:77

    I'm really not a fan of massive-switch structures. While they can certainly pass tests, they're harder to read and harder to maintain. It also took me multiple scans through to realize that this method is not all one giant switch, but sometimes continues, has other branches, and maintains a lot of important state, so it's not simply a matter of inlinine a big flat branch list. There are better ways to structure this code.

    Tokenizer.php:736

    Shouldn't this conditional be the other way around?
  13. Christian Kuhn commented on patch set 5 04/21/22, 08:24

    This change is ready for review.

    Token.php:23 Reply

    I'll probably keep the getters - that's more flexible in case we need to migrate later. not 100% sure, though.

    TokenEnum.php:22 Reply

    Ah, good point. those where constants in my first implementations, i may rename that.

    Tokenizer.php:77 Reply

    I've read through your chapter about "functional monadic state machine". I didn't fully understand all details, though. We might be able to implement this approach later and swapping in a different solution: The test coverage is there now, so if something different passes tests and is performance wise similar, it's of course an option. At the moment I'll continue with AST creation and evaluation of the token stream, though.

    Tokenizer.php:736 Reply

    dots in T_IDENTIFIER need to be quoted again when untokenizing.
  14. Christian Kuhn marked it work in progress 04/21/22, 08:24

  15. Christian Kuhn uploaded patch set 6 04/21/22, 08:39

  16. core-ci voted on patch set 6 V +1 04/21/22, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26265

  17. Simon Schaufelberger commented on patch set 6 04/24/22, 00:37

    did you have a look at how nikic/php-parser works?
  18. Simon Schaufelberger wrote 04/24/22, 00:37

    Removed cc Simon Schaufelberger.
  19. Christian Kuhn uploaded patch set 7 04/24/22, 19:38

  20. Christian Kuhn updated the commit message in patch set 8 04/24/22, 19:40

  21. Christian Kuhn commented on patch set 7 04/24/22, 19:47

    This change is ready for review.

    Reply

    i looked at various parsers: the nikic parser for instance does not need to tokenize because it uses php's token_get_all(). token_get_all() however is "old" and returns a funny structure. the implementation of "my" tokenizer is a bit more modern (it for instance *always* returns tokens objects and not just strings, which token_get_all() does for things like assignments for instance). nikic is interesting for the AST-builder part, which is heavily semantical-driven. the TS-syntax AST part can be more slim, so the AST parsing code of nikic can be used only as inspiration but not as a 'how-to-solve-it'.
  22. Christian Kuhn marked it ready for review 04/24/22, 19:47

  23. Christian Kuhn marked it work in progress 04/24/22, 19:47

  24. core-ci voted on patch set 7 V +1 04/24/22, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26378

  25. core-ci voted on patch set 8 V +1 04/24/22, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26379

  26. Christian Kuhn uploaded patch set 9 04/25/22, 09:58

  27. core-ci voted on patch set 9 V -1 04/25/22, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26389

  28. Christian Kuhn uploaded patch set 10 04/25/22, 10:41

  29. core-ci voted on patch set 10 V +1 04/25/22, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26392

  30. Christian Kuhn uploaded patch set 11 04/25/22, 14:51

  31. core-ci voted on patch set 11 V +1 04/25/22, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26402

  32. Christian Kuhn uploaded patch set 12 04/25/22, 21:02

  33. core-ci voted on patch set 12 V +1 04/25/22, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26431

  34. Christian Kuhn uploaded patch set 13 04/25/22, 21:20

  35. core-ci voted on patch set 13 V +1 04/25/22, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26433

  36. Christian Kuhn uploaded patch set 14 04/26/22, 09:27

  37. Christian Kuhn uploaded patch set 15 04/26/22, 09:29

  38. core-ci voted on patch set 14 V +1 04/26/22, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26442

  39. core-ci voted on patch set 15 V +1 04/26/22, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26443

  40. Christian Kuhn uploaded patch set 16 04/27/22, 11:37

  41. core-ci voted on patch set 16 V -1 04/27/22, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26504

  42. Christian Kuhn uploaded patch set 17 04/28/22, 13:11

  43. core-ci voted on patch set 17 V -1 04/28/22, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26587

  44. Christian Kuhn uploaded patch set 18 04/29/22, 19:41

  45. core-ci voted on patch set 18 V -1 04/29/22, 19:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26685

  46. Christian Kuhn uploaded patch set 19 05/10/22, 11:19

  47. core-ci voted on patch set 19 V -1 05/10/22, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27093

  48. Christian Kuhn uploaded patch set 20 05/11/22, 08:48

  49. core-ci voted on patch set 20 V -1 05/11/22, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27113

  50. Christian Kuhn uploaded patch set 21 05/12/22, 13:21

  51. core-ci voted on patch set 21 V -1 05/12/22, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27143

  52. Christian Kuhn uploaded patch set 22 05/13/22, 22:46

  53. core-ci voted on patch set 22 V -1 05/13/22, 22:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27192

  54. Christian Kuhn uploaded patch set 23 05/13/22, 23:03

  55. core-ci voted on patch set 23 V -1 05/13/22, 23:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27193

  56. Christian Kuhn uploaded patch set 24 05/14/22, 00:15

  57. Christian Kuhn uploaded patch set 25 05/14/22, 00:16

  58. Christian Kuhn uploaded patch set 26 05/14/22, 00:18

  59. core-ci voted on patch set 24 V -1 05/14/22, 00:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27195

  60. core-ci voted on patch set 25 V -1 05/14/22, 00:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27196

  61. core-ci voted on patch set 26 V -1 05/14/22, 00:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27197

  62. Christian Kuhn uploaded patch set 27 05/14/22, 08:10

  63. core-ci voted on patch set 27 V +1 05/14/22, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27206

  64. Christian Kuhn uploaded patch set 28 05/15/22, 09:24

  65. core-ci voted on patch set 28 V +1 05/15/22, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27222

  66. Christian Kuhn uploaded patch set 29 05/15/22, 14:38

  67. core-ci voted on patch set 29 V +1 05/15/22, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27229

  68. Christian Kuhn uploaded patch set 30 05/16/22, 23:21

  69. core-ci voted on patch set 30 V -1 05/16/22, 23:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27270

  70. Christian Kuhn uploaded patch set 31 05/17/22, 11:09

  71. core-ci voted on patch set 31 V +1 05/17/22, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27281

  72. Christian Kuhn uploaded patch set 32 05/17/22, 15:18

  73. Christian Kuhn commented on patch set 32 05/17/22, 15:19

    https://review.typo3.org/c/Packages/TYPO3.CMS/+/74285/31..32 plays around on tokenizer performance. resetted for now.
  74. Christian Kuhn uploaded patch set 33 05/17/22, 15:21

  75. core-ci voted on patch set 33 V +1 05/17/22, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27285

  76. core-ci voted on patch set 32 V -1 05/17/22, 15:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27284

  77. Christian Kuhn uploaded patch set 34 05/19/22, 12:41

  78. core-ci voted on patch set 34 V +1 05/19/22, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27321

  79. Christian Kuhn uploaded patch set 35 05/19/22, 13:12

  80. core-ci voted on patch set 35 V +1 05/19/22, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27322

  81. Christian Kuhn uploaded patch set 36 05/19/22, 20:38

  82. core-ci voted on patch set 36 V +1 05/19/22, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27327

  83. Christian Kuhn uploaded patch set 37 05/20/22, 14:32

  84. core-ci voted on patch set 37 V +1 05/20/22, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27356

  85. Christian Kuhn updated the commit message in patch set 38 05/21/22, 08:19

  86. core-ci voted on patch set 38 V -1 05/21/22, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27368

  87. Christian Kuhn uploaded patch set 39 05/25/22, 11:05

  88. core-ci voted on patch set 39 V -1 05/25/22, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27445

  89. Christian Kuhn uploaded patch set 40 05/25/22, 13:31

  90. core-ci voted on patch set 40 V +1 05/25/22, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27459

  91. Christian Kuhn uploaded patch set 41 05/26/22, 02:30

  92. core-ci voted on patch set 41 V +1 05/26/22, 02:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27471

  93. Christian Kuhn uploaded patch set 42 05/27/22, 12:31

  94. core-ci voted on patch set 42 V +1 05/27/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27491

  95. Christian Kuhn uploaded patch set 43 05/28/22, 12:33

  96. core-ci voted on patch set 43 V -1 05/28/22, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27512

  97. core-ci voted on patch set 43 V +1 05/28/22, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27512

  98. Christian Kuhn uploaded patch set 44 05/28/22, 14:17

  99. core-ci voted on patch set 44 V +1 05/28/22, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27517

  100. Christian Kuhn uploaded patch set 45 05/28/22, 16:08

  101. core-ci voted on patch set 45 V +1 05/28/22, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27521

  102. Christian Kuhn uploaded patch set 46 05/28/22, 18:27

  103. Christian Kuhn uploaded patch set 47 05/28/22, 18:32

  104. core-ci voted on patch set 46 V -1 05/28/22, 18:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27523

  105. core-ci voted on patch set 47 V +1 05/28/22, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27524

  106. Christian Kuhn uploaded patch set 48 05/30/22, 12:20

  107. core-ci voted on patch set 48 V +1 05/30/22, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27584

  108. Christian Kuhn uploaded patch set 49 06/01/22, 12:00

  109. core-ci voted on patch set 49 V +1 06/01/22, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27620

  110. Christian Kuhn uploaded patch set 50 06/01/22, 13:30

  111. core-ci voted on patch set 50 V +1 06/01/22, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27621

  112. Christian Kuhn uploaded patch set 51 06/01/22, 14:55

  113. core-ci voted on patch set 51 V +1 06/01/22, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27628

  114. Christian Kuhn uploaded patch set 52 06/03/22, 17:00

  115. Christian Kuhn commented on patch set 52 06/03/22, 17:03

    This change is ready for review.
    set 52 brings main work triggered by object browser: * a general JS solution to trigger form submits for <a tags (thanks to oliver hader) * infrastructure for ast traversing and tokenizers and first usages in object browser. * object browser code still heavy-wip, but most of required infrastructure should be there now.
  116. Christian Kuhn marked it work in progress 06/03/22, 17:04

  117. core-ci voted on patch set 52 V -1 06/03/22, 17:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27690

  118. Christian Kuhn uploaded patch set 53 06/05/22, 09:06

  119. core-ci voted on patch set 53 V -1 06/05/22, 09:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27709

  120. Christian Kuhn uploaded patch set 54 06/06/22, 09:40

  121. core-ci voted on patch set 54 V -1 06/06/22, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27724

  122. Christian Kuhn uploaded patch set 55 06/06/22, 13:54

  123. core-ci voted on patch set 55 V -1 06/06/22, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27726

  124. Christian Kuhn uploaded patch set 56 06/06/22, 17:57

  125. core-ci voted on patch set 56 V -1 06/06/22, 18:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27733

  126. Christian Kuhn uploaded patch set 57 06/06/22, 20:15

  127. core-ci voted on patch set 57 V -1 06/06/22, 20:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27749

  128. Christian Kuhn uploaded patch set 58 06/07/22, 16:34

  129. core-ci voted on patch set 58 V -1 06/07/22, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27773

  130. Christian Kuhn uploaded patch set 59 06/08/22, 09:51

  131. core-ci voted on patch set 59 V -1 06/08/22, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27800

  132. Christian Kuhn uploaded patch set 60 06/08/22, 10:17

  133. core-ci voted on patch set 60 V -1 06/08/22, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27802

  134. Christian Kuhn uploaded patch set 61 06/10/22, 09:49

  135. core-ci voted on patch set 61 V -1 06/10/22, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27910

  136. Christian Kuhn uploaded patch set 62 06/10/22, 13:39

  137. Christian Kuhn commented on patch set 62 06/10/22, 13:40

    This change is ready for review.
    marker: bigger rewrite of tokenizer to be line based.
  138. Christian Kuhn marked it work in progress 06/10/22, 13:40

  139. core-ci voted on patch set 62 V -1 06/10/22, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27926

  140. Christian Kuhn uploaded patch set 63 06/12/22, 08:36

  141. Christian Kuhn commented on patch set 63 06/12/22, 08:37

    intermediate step with another huge rewrite of the tokenizer
  142. core-ci voted on patch set 63 V -1 06/12/22, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27988

  143. Christian Kuhn uploaded patch set 64 06/12/22, 14:09

  144. core-ci voted on patch set 64 V -1 06/12/22, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27992

  145. Christian Kuhn uploaded patch set 65 06/13/22, 14:39

  146. core-ci voted on patch set 65 V -1 06/13/22, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28020

  147. Christian Kuhn uploaded patch set 66 06/13/22, 18:56

  148. core-ci voted on patch set 66 V -1 06/13/22, 19:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28022

  149. Christian Kuhn uploaded patch set 67 06/13/22, 20:20

  150. core-ci voted on patch set 67 V -1 06/13/22, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28025

  151. Christian Kuhn uploaded patch set 68 06/13/22, 20:47

  152. Christian Kuhn uploaded patch set 69 06/13/22, 20:52

  153. core-ci voted on patch set 68 V -1 06/13/22, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28026

  154. core-ci voted on patch set 69 V -1 06/13/22, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28027

  155. Stefan Froemken commented on patch set 69 06/14/22, 08:35

    In general I prefer '/*' for method descriptions.
    something
    I remember things like LIT:1={$my.const} works. Can you describe your problem in more detail?
    For me it would be OK to never allow =< in conditions
    with
    Sure that this will not lead to any further problems?
    That OK for me

    AbstractNode.php:61

    Pretty cool. I love yield

    AstBuilder.php:149

    Single quotes not possible?

    AstBuilder.php:163

    Can we use simple comments here?

    AstBuilder.php:165

    too much spaces. Left align or enter empty line

    AstBuilder.php:167

    You're parsing a text file. Do we really need nullables here?

    AstBuilder.php:209

    add space: PHP 7

    AstBuilder.php:232

    If you cast these 3 variables to (string) you can remove the nullable from return value.

    AstTraverser.php:32

    This is a simple comment

    ObjectNode.php:36

    You write deep-copy. IMO with clone only the first object will be cloned, but not the child-objects.

    ObjectNode.php:71

    I don't see that we need that

    ObjectNode.php:73

    I prefer $this->value === null

    IncludeInterface.php:55

    getPid can be null?

    RootInclude.php:22

    Why "0"?

    TreeBuilder.php:357

    two dots. Same below

    TreeBuilder.php:398

    of
  156. Christian Kuhn uploaded patch set 70 06/15/22, 11:05

  157. core-ci voted on patch set 70 V -1 06/15/22, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28094

  158. Christian Kuhn commented on patch set 70 06/15/22, 11:32

    Reply

    Done

    Reply

    my tests showed you can't use constants in the constant section?! Have this in constants (v11): foo = fooValue bar = {$foo} Then in setup: myValue = {$bar} -> resolves to string {$foo} for myValue. Did I miss something?

    Reply

    foo =< {$bar} does *not* work (anymore). will have a detailed section in .rst later for this.

    Reply

    Done

    Reply

    pretty sure: utf-8 files should NOT have BOM - i looked that up. I think only old editors added these, no 'modern' editor (younger than 10 years) should do that anymore. we also have a core integrity test to verify this for core files, btw.

    Reply

    Done

    AbstractNode.php:61 Reply

    there are some other places where they might be used, but i'm not entirely sure yet since i tend to break early often and currently prefer while(true) loops at some places. that's a detail for a cleanup round, later to see if we can yield at some other places, too.

    AstBuilder.php:149 Reply

    Done

    AstBuilder.php:163 Reply

    core uses /** for methods.

    AstBuilder.php:165 Reply

    Done

    AstBuilder.php:167 Reply

    good catch. not 100% sure. could be a left over from my first implementation. will keep open and sort out details later.

    AstBuilder.php:209 Reply

    Done

    AstBuilder.php:232 Reply

    unsure. will keep open for now.

    AstTraverser.php:32 Reply

    nope.

    ObjectNode.php:36 Reply

    that's exactly why i implement __clone() here: it now clones children too.

    ObjectNode.php:71 Reply

    think i needed it at least in the first implementation. will look up details later again.

    ObjectNode.php:73 Reply

    Done

    IncludeInterface.php:55 Reply

    there was a reason i did that. will look up details later again and comment.

    RootInclude.php:22 Reply

    b/w compat reasons.

    TreeBuilder.php:357 Reply

    wanted to have 3 here to not confuse with 'path traversal' ".."

    TreeBuilder.php:398 Reply

    Done
  159. Christian Kuhn uploaded patch set 71 06/15/22, 11:33

  160. core-ci voted on patch set 71 V -1 06/15/22, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28095

  161. Simon Schaufelberger commented on patch set 71 06/15/22, 11:55

    Reply

    My understanding of constants is that they already have a value and should not recursively be replaced, otherwise you could do a recursive replacement loop which will be insane. one = value two = {$one} three = {$two} four = {$three} yes that is possible but this is crazy and should not be supported imho.
  162. Simon Schaufelberger commented on patch set 71 06/15/22, 11:57

    Reply

    [LIT:1={$my.const}] should indeed work. I'm making heavy use of that in my projects.
  163. Christian Kuhn commented on patch set 71 06/15/22, 12:07

    AstBuilder.php:167 Reply

    current solution is ok. if you do this: foo.bar = barValue you create a 'foo' node, which has null as value. so yes, values need to be nullable.
  164. Christian Kuhn uploaded patch set 72 06/15/22, 13:26

  165. Christian Kuhn commented on patch set 72 06/15/22, 13:28

    Reply

    constant substitution in conditions works.
  166. Christian Kuhn commented on patch set 72 06/15/22, 13:29

    Reply

    more precisely: constant substitution in *setup* conditions works. they're not resolved in constant conditions.
  167. Christian Kuhn commented on patch set 72 06/15/22, 13:31

    implemented $ast->toArray(), and constants in multiline value assignments are resolved now.
  168. core-ci voted on patch set 72 V -1 06/15/22, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28098

  169. Christian Kuhn uploaded patch set 73 06/15/22, 20:19

  170. Christian Kuhn commented on patch set 73 06/15/22, 20:19

    implement =<
  171. core-ci voted on patch set 73 V -1 06/15/22, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28106

  172. Christian Kuhn uploaded patch set 74 06/17/22, 13:30

  173. core-ci voted on patch set 74 V -1 06/17/22, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28151

  174. Christian Kuhn uploaded patch set 75 06/17/22, 18:31

  175. core-ci voted on patch set 75 V -1 06/17/22, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28160

  176. Christian Kuhn uploaded patch set 76 06/18/22, 16:08

  177. Christian Kuhn commented on patch set 76 06/18/22, 16:22

    first working FE with bootstrap_package.
  178. core-ci voted on patch set 76 V -1 06/18/22, 17:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28182

  179. Christian Kuhn uploaded patch set 77 06/18/22, 21:59

  180. core-ci voted on patch set 77 V -1 06/18/22, 22:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28192

  181. Christian Kuhn uploaded patch set 78 06/19/22, 10:11

  182. Christian Kuhn commented on patch set 78 06/19/22, 10:14

    Implement optimized query in TreeBuilder. Thanks to sbuerk!
  183. Christian Kuhn uploaded patch set 79 06/19/22, 10:47

  184. core-ci voted on patch set 78 V -1 06/19/22, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28219

  185. core-ci voted on patch set 79 V -1 06/19/22, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28220

  186. Christian Kuhn uploaded patch set 80 06/19/22, 14:40

  187. core-ci voted on patch set 80 V -1 06/19/22, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28222

  188. Christian Kuhn uploaded patch set 81 06/19/22, 20:12

  189. core-ci voted on patch set 81 V -1 06/19/22, 21:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28224

  190. Christian Kuhn uploaded patch set 82 06/19/22, 22:40

  191. core-ci voted on patch set 82 V -1 06/19/22, 23:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28229

  192. Christian Kuhn uploaded patch set 83 06/21/22, 08:05

  193. core-ci voted on patch set 83 V -1 06/21/22, 09:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28293

  194. Christian Kuhn uploaded patch set 84 06/21/22, 09:07

  195. core-ci voted on patch set 84 V -1 06/21/22, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28294

  196. Christian Kuhn uploaded patch set 85 06/21/22, 11:24

  197. core-ci voted on patch set 85 V -1 06/21/22, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28298

  198. Christian Kuhn uploaded patch set 86 06/21/22, 11:43

  199. core-ci voted on patch set 86 V +1 06/21/22, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28299

  200. Benni Mack commented on patch set 86 06/21/22, 12:44

    TypoScriptFrontendController.php:1339

    this is the stuff that should be moved to TemplateService->getTypoScriptForPage($pageId, $rootLine);
  201. Christian Kuhn commented on patch set 86 06/21/22, 13:25

    AstBuilder.php:232 Reply

    has to be kept nullable when the env var is not set. a test fails if changing this.

    IncludeInterface.php:55 Reply

    yes. it's null with extbase backend typoscript on root page and with pagets on root page.

    TypoScriptFrontendController.php:1339 Reply

    Unsure how to abstract that away currently. at least it will for sure not end up in TemplateService. But yeah, it will no stay here, this part is WIP and will of course change.
  202. Christian Kuhn commented on patch set 86 06/21/22, 13:29

    Reply

    we use /** for methods

    ObjectNode.php:71 Reply

    foo.bar { baz = bazValue } -> bar node is null.
  203. Benni Mack commented on patch set 86 06/21/22, 14:41

    TypoScriptFrontendController.php:1339 Reply

    A new class TypoScriptResolver and then we could slowly phase out $TSFE->tmpl would be my wish...
  204. Christian Kuhn uploaded patch set 87 06/21/22, 15:50

  205. Christian Kuhn commented on patch set 87 06/21/22, 15:52

    TypoScriptFrontendController.php:1339 Reply

    yeah. dropping TemplateService usages will be my next patches when the main api is in. it should be v12 goal to deprecate that class.
  206. core-ci voted on patch set 87 V +1 06/21/22, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28304

  207. Simon Schaufelberger wrote 06/21/22, 17:12

    Removed cc Simon Schaufelberger.
  208. Christian Kuhn uploaded patch set 88 06/21/22, 17:38

  209. core-ci voted on patch set 88 V +1 06/21/22, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28305

  210. Christian Kuhn uploaded patch set 89 06/21/22, 19:14

  211. Christian Kuhn uploaded patch set 90 06/21/22, 19:19

  212. core-ci voted on patch set 89 V +1 06/21/22, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28306

  213. core-ci voted on patch set 90 V +1 06/21/22, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28307

  214. Christian Kuhn uploaded patch set 91 06/21/22, 19:50

  215. core-ci voted on patch set 91 V +1 06/21/22, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28309

  216. Christian Kuhn uploaded patch set 92 06/21/22, 20:14

  217. core-ci voted on patch set 92 V -1 06/21/22, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28310

  218. Christian Kuhn uploaded patch set 93 06/22/22, 07:55

  219. core-ci voted on patch set 93 V +1 06/22/22, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28327

  220. Christian Kuhn uploaded patch set 94 06/23/22, 12:45

  221. Christian Kuhn commented on patch set 94 06/23/22, 12:46

    major class renaming finished.
  222. Christian Kuhn uploaded patch set 95 06/23/22, 12:52

  223. Christian Kuhn commented on patch set 95 06/23/22, 12:53

    Removed AstReferenceResolverVisitor and AstReferenceResolverVisitorTest This is solved differently since the approach is far to expensive. Marked here for reference in case COR->cObjGetSingle() and friends are later refactored to work on the AST tree directly, and not on the array.
  224. core-ci voted on patch set 95 V +1 06/23/22, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28350

  225. core-ci voted on patch set 94 V -1 06/23/22, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28349

  226. Christian Kuhn uploaded patch set 96 06/23/22, 13:33

  227. core-ci voted on patch set 96 V +1 06/23/22, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28352

  228. Christian Kuhn uploaded patch set 97 06/23/22, 13:58

  229. core-ci voted on patch set 97 V +1 06/23/22, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28353

  230. Christian Kuhn uploaded patch set 98 06/23/22, 14:22

  231. core-ci voted on patch set 98 V +1 06/23/22, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28354

  232. Christian Kuhn uploaded patch set 99 06/23/22, 16:27

  1. Christian Kuhn commented on patch set 98 06/23/22, 16:28

    Added some serialize() magic to IncludeTree, Token and Lines. This cuts the cached IncludeTree file size by half.
  2. core-ci voted on patch set 99 V +1 06/23/22, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28357

  3. Christian Kuhn uploaded patch set 100 06/23/22, 19:13

  4. Christian Kuhn commented on patch set 100 06/23/22, 19:14

    niftify include tree cache layer.
  5. Christian Kuhn uploaded patch set 101 06/23/22, 19:21

  6. core-ci voted on patch set 100 V -1 06/23/22, 19:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28363

  7. core-ci voted on patch set 101 V +1 06/23/22, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28366

  8. Christian Kuhn uploaded patch set 102 06/27/22, 11:30

  9. core-ci voted on patch set 102 V -1 06/27/22, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28436

  10. Christian Kuhn uploaded patch set 103 06/27/22, 14:32

  11. core-ci voted on patch set 103 V -1 06/27/22, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28437

  12. core-ci voted on patch set 103 V +1 06/27/22, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28437

  13. Christian Kuhn uploaded patch set 104 07/11/22, 11:06

  14. core-ci voted on patch set 104 V -1 07/11/22, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28879

  15. Andreas Kienast uploaded patch set 105 07/13/22, 08:24

  16. Andreas Kienast uploaded patch set 106 07/13/22, 08:30

  17. core-ci voted on patch set 105 V -1 07/13/22, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29040

  18. core-ci voted on patch set 106 V -1 07/13/22, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29041

  19. Christian Kuhn uploaded patch set 107 07/17/22, 11:35

  20. Christian Kuhn uploaded patch set 108 07/17/22, 11:39

  21. core-ci voted on patch set 107 V -1 07/17/22, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29314

  22. core-ci voted on patch set 108 V -1 07/17/22, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29315

  23. Christian Kuhn uploaded patch set 109 08/19/22, 12:59

  24. Christian Kuhn commented on patch set 109 08/19/22, 13:05

    abandoning here. this is being follow-upped with https://review.typo3.org/c/Packages/TYPO3.CMS/+/75522 and will be split into further single patches.
  25. Christian Kuhn abandoned the change 08/19/22, 13:06