74286[!!!][TASK] Add native types to CsvUtility
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 3
Files 6
- typo3/sysext/core/Classes/Utility/CsvUtility.php8+17 −23
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97210-TypesAddedToMethodSignaturesOrClassProperties.rst+1 −0
- typo3/sysext/core/Tests/Unit/Utility/CsvUtilityTest.php+2 −2
- typo3/sysext/frontend/Classes/DataProcessing/CommaSeparatedValueProcessor.php+1 −1
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+1 −1
- typo3/sysext/recordlist/Classes/Controller/RecordDownloadController.php+2 −2
Review log 2024
-
crell uploaded patch set 1 04/13/22, 15:37
-
Oliver Klee voted on patch set 1 CR +1 04/13/22, 15:45
-
core-ci voted on patch set 1 V +1 04/13/22, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25988
-
Nikita Hovratov commented on patch set 1 V +1 CR +1 04/14/22, 17:40
-
crell commented on patch set 1 04/18/22, 14:31
CsvUtility.php:117ReplyAck -
Simon Schaufelberger voted on patch set 1 V +1 CR +1 04/18/22, 19:51
-
Stefan Bürk commented on patch set 1 CR -1 04/18/22, 20:20
Is it really breaking ? If yes, should be added to collection breaking rst. Not checked if really breaking ...CsvUtility.php:125Can be changed to 'bool|int|float|string|null', as it is ensured through "assertCellValueType()" execution before calling this method.CsvUtility.php:139Can be changed to 'bool|int|float|string|null', as it is ensured through "assertCellValueType()" execution before calling this method.CsvUtility.php:169Can be changed to 'bool|int|float|string|null', as it is ensured through "assertCellValueType()" execution before calling this method. -
crell commented on patch set 1 04/19/22, 15:59
Reply
It adds types to a public method. So, hypothetically slightly breaking, although in practice likely not really. Same as all of these others. (It's already linked from the Forge issue to include in the RST file later.)CsvUtility.php:125ReplyDoneCsvUtility.php:139ReplyDoneCsvUtility.php:169ReplyDone -
crell uploaded patch set 2 04/19/22, 15:59
-
Oliver Klee voted on patch set 2 CR +1 04/19/22, 16:01
-
core-ci voted on patch set 2 V +1 04/19/22, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26192
-
Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/20/22, 14:54
-
Jörg Bösche voted on patch set 2 CR +1 04/27/22, 11:12
-
Oliver Hader commented on patch set 2 CR -1 05/02/22, 14:48
Euhm, what about adjusting the invocations? * CsvUtilityTest * QueryGenerator * RecordDownloadController -
crell commented on patch set 2 05/03/22, 17:06
Reply
We haven't been elsewhere, unless tests require it. I am very hesitant about scope creeping that on some patches but not others. -
Oliver Hader uploaded patch set 3 05/03/22, 17:30
-
Oliver Klee voted on patch set 3 CR +1 05/03/22, 17:34
-
core-ci voted on patch set 3 V +1 05/03/22, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26774
-
Nikita Hovratov uploaded patch set 4 05/06/22, 11:34
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 05/06/22, 11:35
-
core-ci voted on patch set 4 V +1 05/06/22, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26905
-
Oliver Klee voted on patch set 4 CR +1 05/06/22, 11:44
-
Stefan Bürk voted on patch set 4 V +2 CR +2 05/06/22, 13:13
-
Stefan Bürk merged patch set 5 05/06/22, 13:13
CsvUtility.php:117