Review main Merged Breaking

74286[!!!][TASK] Add native types to CsvUtility

crell CR +2 V +2 Normal +24 −29 updated 05/06/22, 13:13

Commit message

Also, first class callable syntax is added for the csvValues
method.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 2024

  1. crell uploaded patch set 1 04/13/22, 15:37

  2. Oliver Klee voted on patch set 1 CR +1 04/13/22, 15:45

  3. core-ci voted on patch set 1 V +1 04/13/22, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25988

  4. Nikita Hovratov commented on patch set 1 V +1 CR +1 04/14/22, 17:40

    CsvUtility.php:117

    Just a note: stream_get_contents can return false. But I think that won't ever happen here.
  5. crell commented on patch set 1 04/18/22, 14:31

    CsvUtility.php:117 Reply

    Ack
  6. Simon Schaufelberger voted on patch set 1 V +1 CR +1 04/18/22, 19:51

  7. Stefan Bürk commented on patch set 1 CR -1 04/18/22, 20:20

    Is it really breaking ? If yes, should be added to collection breaking rst. Not checked if really breaking ...

    CsvUtility.php:125

    Can be changed to 'bool|int|float|string|null', as it is ensured through "assertCellValueType()" execution before calling this method.

    CsvUtility.php:139

    Can be changed to 'bool|int|float|string|null', as it is ensured through "assertCellValueType()" execution before calling this method.

    CsvUtility.php:169

    Can be changed to 'bool|int|float|string|null', as it is ensured through "assertCellValueType()" execution before calling this method.
  8. crell commented on patch set 1 04/19/22, 15:59

    Reply

    It adds types to a public method. So, hypothetically slightly breaking, although in practice likely not really. Same as all of these others. (It's already linked from the Forge issue to include in the RST file later.)

    CsvUtility.php:125 Reply

    Done

    CsvUtility.php:139 Reply

    Done

    CsvUtility.php:169 Reply

    Done
  9. crell uploaded patch set 2 04/19/22, 15:59

  10. Oliver Klee voted on patch set 2 CR +1 04/19/22, 16:01

  11. core-ci voted on patch set 2 V +1 04/19/22, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26192

  12. Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/20/22, 14:54

  13. Jörg Bösche voted on patch set 2 CR +1 04/27/22, 11:12

  14. Oliver Hader commented on patch set 2 CR -1 05/02/22, 14:48

    Euhm, what about adjusting the invocations? * CsvUtilityTest * QueryGenerator * RecordDownloadController
  15. crell commented on patch set 2 05/03/22, 17:06

    Reply

    We haven't been elsewhere, unless tests require it. I am very hesitant about scope creeping that on some patches but not others.
  16. Oliver Hader uploaded patch set 3 05/03/22, 17:30

  17. Oliver Klee voted on patch set 3 CR +1 05/03/22, 17:34

  18. core-ci voted on patch set 3 V +1 05/03/22, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26774

  19. Nikita Hovratov uploaded patch set 4 05/06/22, 11:34

  20. Nikita Hovratov voted on patch set 4 V +1 CR +1 05/06/22, 11:35

  21. core-ci voted on patch set 4 V +1 05/06/22, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26905

  22. Oliver Klee voted on patch set 4 CR +1 05/06/22, 11:44

  23. Stefan Bürk voted on patch set 4 V +2 CR +2 05/06/22, 13:13

  24. Stefan Bürk merged patch set 5 05/06/22, 13:13