Review main Merged Breaking

74287[!!!][TASK] Add native types to DiffUtility

crell CR +2 V +2 Easy +14 −14 updated 07/22/22, 10:53

Commit message

'BackendUtility::getProcessedValue()' currently implicitly
returns mixed, whereas makeDiffDisplay() requires a string.
Using force-casting in '\TYPO3\CMS\Impexp\ImportExport' for
the value before passing it is the most straightforward fix
for now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1925

  1. crell uploaded patch set 1 04/13/22, 16:05

  2. core-ci voted on patch set 1 V +1 04/13/22, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25991

  3. Oliver Klee voted on patch set 1 CR +1 04/13/22, 16:18

  4. Simon Schaufelberger voted on patch set 1 V +1 CR +1 04/14/22, 18:31

  5. Benni Mack voted on patch set 1 V +2 CR +2 04/14/22, 20:26

  6. Benni Mack updated the commit message in patch set 2 04/14/22, 20:26

  7. core-ci voted on patch set 2 V +1 04/14/22, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26033

  8. Oliver Klee voted on patch set 2 CR +1 04/14/22, 20:58

  9. Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/14/22, 21:51

  10. Stefan Bürk updated the commit message in patch set 3 04/15/22, 16:01

  11. Oliver Klee voted on patch set 3 CR +1 04/15/22, 16:04

  12. core-ci voted on patch set 3 V -1 04/15/22, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26052

  13. core-ci voted on patch set 3 V +1 04/15/22, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26052

  14. Stefan Bürk commented on patch set 3 CR -1 04/16/22, 08:16

    on it
  15. Stefan Bürk uploaded patch set 4 04/16/22, 08:30

  16. Stefan Bürk voted on patch set 4 V +1 CR +1 04/16/22, 08:31

  17. Oliver Klee voted on patch set 4 CR +1 04/16/22, 08:32

  18. core-ci voted on patch set 4 V +1 04/16/22, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26087

  19. Stefan Bürk uploaded patch set 5 04/17/22, 21:41

  20. Stefan Bürk voted on patch set 5 V +1 CR +1 04/17/22, 21:42

  21. core-ci voted on patch set 5 V +1 04/17/22, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26126

  22. Oliver Klee voted on patch set 5 CR +1 04/17/22, 22:40

  23. Benni Mack voted on patch set 5 V +2 CR +2 04/18/22, 11:21

  24. Benni Mack merged patch set 6 04/18/22, 11:21

  25. Christian Kuhn commented on patch set 6 07/22/22, 10:53