74288[!!!][TASK] Add native types to ExtensionManagementUtility
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 3
Files 4
- Build/phpstan/phpstan-baseline.neon+0 −25
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php6+89 −140
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97210-TypesAddedToMethodSignaturesOrClassProperties.rst+1 −0
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php5+12 −108
Review log 2834
Show 89 earlier messages
-
crell uploaded patch set 1 04/13/22, 16:21
-
core-ci voted on patch set 1 V +1 04/13/22, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25993
-
Oliver Klee voted on patch set 1 CR +1 04/13/22, 19:16
-
Simon Schaufelberger commented on patch set 1 04/14/22, 23:17
What about the remaining methods? -
crell commented on patch set 1 04/14/22, 23:30
Reply
Did I miss any? I thought I got all the methods in this class that weren't already fully typed. If I missed one please call it out so I can fix it. -
Simon Schaufelberger commented on patch set 1 04/18/22, 20:32
Reply
ok, you skipped the deprecated ones. -
Simon Schaufelberger voted on patch set 1 V +1 CR +1 04/18/22, 20:33
-
Nikita Hovratov uploaded patch set 2 05/06/22, 12:50
-
Oliver Klee commented on patch set 2 05/06/22, 12:54
ExtensionManagementUtilityTest.php:38If we're mentioning which class the test is about (which is a good thing!), then please let's directly use this notation so that code coverage can recognize it: @covers \TYPO3\CMS\Core\Utility\ExtensionManagementUtility (The leading backslash is technically optional, but I strongly recommend having it for the benefit of the reader because the @covers annotation is not namespace-aware (which is not obvious).)ExtensionManagementUtilityTest.php:60This should be PackageManager&MockObject.
-
core-ci voted on patch set 2 V +1 05/06/22, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26911
-
Nikita Hovratov uploaded patch set 3 05/06/22, 14:48
-
Oliver Klee voted on patch set 3 CR +1 05/06/22, 14:54
-
Nikita Hovratov commented on patch set 3 05/06/22, 14:55
ExtensionManagementUtilityTest.php:38ReplyCool, didn't know this.ExtensionManagementUtilityTest.php:60ReplyAh nice, thanks! It's indeed an intersection type. -
Nikita Hovratov commented on patch set 3 05/06/22, 14:55
ExtensionManagementUtilityTest.php:60ReplyDone -
core-ci voted on patch set 3 V +1 05/06/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26923
-
Nikita Hovratov voted on patch set 3 V +1 CR +1 05/06/22, 15:05
-
Oliver Hader commented on patch set 3 CR -1 05/06/22, 21:35
ExtensionManagementUtility.php:664Now the `default` case results in an empty list, previously the `$insertionList` was appended (like mentioned in comment below) -
Nikita Hovratov uploaded patch set 4 05/07/22, 07:12
-
Nikita Hovratov uploaded patch set 5 05/07/22, 07:16
-
core-ci voted on patch set 4 V -1 05/07/22, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26949
-
Nikita Hovratov rebased onto patch set 6 05/07/22, 07:17
-
core-ci voted on patch set 5 V -1 05/07/22, 07:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26950
-
Nikita Hovratov commented on patch set 4 V +1 CR +1 05/07/22, 07:20
ExtensionManagementUtility.php:664ReplyNice catch, thanks! -
core-ci voted on patch set 6 V +1 05/07/22, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26951
-
Nikita Hovratov voted on patch set 6 V +1 CR +1 05/07/22, 07:26
-
Oliver Klee voted on patch set 6 CR +1 05/07/22, 08:21
-
Simon Schaufelberger commented on patch set 6 05/07/22, 10:49
ExtensionManagementUtility.php:1010what does nominally mean? -
Nikita Hovratov commented on patch set 6 05/07/22, 10:57
ExtensionManagementUtility.php:1010Reply"in name or thought but not in fact, or not as things really are" $type is in fact optional, but because of the order of the parameters, it isn't. -
Simon Schaufelberger commented on patch set 6 05/07/22, 11:04
ExtensionManagementUtility.php:1010Replyok, that word is definitely a bit hard to understand. -
Simon Schaufelberger voted on patch set 6 V +1 CR +1 05/07/22, 11:04
-
Nikita Hovratov commented on patch set 6 05/07/22, 11:09
ExtensionManagementUtility.php:1010ReplyFor us germans for sure :) -
Stefan Bürk voted on patch set 6 V +1 CR +1 05/07/22, 11:15
-
Nikita Hovratov voted on patch set 6 V +2 CR +2 05/07/22, 11:17
-
Nikita Hovratov merged patch set 7 05/07/22, 11:17