Review main Merged Breaking

74288[!!!][TASK] Add native types to ExtensionManagementUtility

crell CR +2 V +2 Hard +102 −273 updated 05/07/22, 11:17

Commit message

Also gets rid of some phpstan exceptions.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 2834

Show 89 earlier messages
  1. crell uploaded patch set 1 04/13/22, 16:21

  2. core-ci voted on patch set 1 V +1 04/13/22, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25993

  3. Oliver Klee voted on patch set 1 CR +1 04/13/22, 19:16

  4. Simon Schaufelberger commented on patch set 1 04/14/22, 23:17

    What about the remaining methods?
  5. crell commented on patch set 1 04/14/22, 23:30

    Reply

    Did I miss any? I thought I got all the methods in this class that weren't already fully typed. If I missed one please call it out so I can fix it.
  6. Simon Schaufelberger commented on patch set 1 04/18/22, 20:32

    Reply

    ok, you skipped the deprecated ones.
  7. Simon Schaufelberger voted on patch set 1 V +1 CR +1 04/18/22, 20:33

  8. Nikita Hovratov uploaded patch set 2 05/06/22, 12:50

  9. Oliver Klee commented on patch set 2 05/06/22, 12:54

    ExtensionManagementUtilityTest.php:38

    If we're mentioning which class the test is about (which is a good thing!), then please let's directly use this notation so that code coverage can recognize it: @covers \TYPO3\CMS\Core\Utility\ExtensionManagementUtility (The leading backslash is technically optional, but I strongly recommend having it for the benefit of the reader because the @covers annotation is not namespace-aware (which is not obvious).)

    ExtensionManagementUtilityTest.php:60

    This should be PackageManager&MockObject.
  1. core-ci voted on patch set 2 V +1 05/06/22, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26911

  2. Nikita Hovratov uploaded patch set 3 05/06/22, 14:48

  3. Oliver Klee voted on patch set 3 CR +1 05/06/22, 14:54

  4. Nikita Hovratov commented on patch set 3 05/06/22, 14:55

    ExtensionManagementUtilityTest.php:38 Reply

    Cool, didn't know this.

    ExtensionManagementUtilityTest.php:60 Reply

    Ah nice, thanks! It's indeed an intersection type.
  5. Nikita Hovratov commented on patch set 3 05/06/22, 14:55

    ExtensionManagementUtilityTest.php:60 Reply

    Done
  6. core-ci voted on patch set 3 V +1 05/06/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26923

  7. Nikita Hovratov voted on patch set 3 V +1 CR +1 05/06/22, 15:05

  8. Oliver Hader commented on patch set 3 CR -1 05/06/22, 21:35

    ExtensionManagementUtility.php:664

    Now the `default` case results in an empty list, previously the `$insertionList` was appended (like mentioned in comment below)
  9. Nikita Hovratov uploaded patch set 4 05/07/22, 07:12

  10. Nikita Hovratov uploaded patch set 5 05/07/22, 07:16

  11. core-ci voted on patch set 4 V -1 05/07/22, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26949

  12. Nikita Hovratov rebased onto patch set 6 05/07/22, 07:17

  13. core-ci voted on patch set 5 V -1 05/07/22, 07:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26950

  14. Nikita Hovratov commented on patch set 4 V +1 CR +1 05/07/22, 07:20

    ExtensionManagementUtility.php:664 Reply

    Nice catch, thanks!
  15. core-ci voted on patch set 6 V +1 05/07/22, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26951

  16. Nikita Hovratov voted on patch set 6 V +1 CR +1 05/07/22, 07:26

  17. Oliver Klee voted on patch set 6 CR +1 05/07/22, 08:21

  18. Simon Schaufelberger commented on patch set 6 05/07/22, 10:49

    ExtensionManagementUtility.php:1010

    what does nominally mean?
  19. Nikita Hovratov commented on patch set 6 05/07/22, 10:57

    ExtensionManagementUtility.php:1010 Reply

    "in name or thought but not in fact, or not as things really are" $type is in fact optional, but because of the order of the parameters, it isn't.
  20. Simon Schaufelberger commented on patch set 6 05/07/22, 11:04

    ExtensionManagementUtility.php:1010 Reply

    ok, that word is definitely a bit hard to understand.
  21. Simon Schaufelberger voted on patch set 6 V +1 CR +1 05/07/22, 11:04

  22. Nikita Hovratov commented on patch set 6 05/07/22, 11:09

    ExtensionManagementUtility.php:1010 Reply

    For us germans for sure :)
  23. Stefan Bürk voted on patch set 6 V +1 CR +1 05/07/22, 11:15

  24. Nikita Hovratov voted on patch set 6 V +2 CR +2 05/07/22, 11:17

  25. Nikita Hovratov merged patch set 7 05/07/22, 11:17