Review main Merged

74289[TASK] Add native types to HttpUtility

crell CR +2 V +2 Normal +67 −67 updated 04/16/22, 19:56

Commit message

Add return type declarations and explicitly define
public visibility for class constants.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1620

  1. crell uploaded patch set 1 04/13/22, 16:34

  2. Oliver Klee voted on patch set 1 CR +1 04/13/22, 16:43

  3. core-ci voted on patch set 1 V +1 04/13/22, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25994

  4. Benni Mack voted on patch set 1 V +1 CR +1 04/14/22, 20:32

  5. Benni Mack commented on patch set 1 V 0 CR 0 04/15/22, 20:19

    I don't think this change is actually breaking...
  6. Oliver Klee commented on patch set 1 CR 0 04/15/22, 20:43

    Indeed.
  7. Oliver Klee updated the commit message in patch set 2 04/15/22, 20:44

  8. Oliver Klee voted on patch set 2 CR +1 04/15/22, 20:44

  9. core-ci voted on patch set 2 V +1 04/15/22, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26061

  10. Oli Bartsch commented on patch set 2 04/15/22, 22:52

    This issue is no longer related. The class should not be added to the breaking RST.
  11. crell commented on patch set 2 04/15/22, 23:09

    Reply

    Relation deleted over in Forge.
  12. Benjamin Franzke uploaded patch set 3 04/16/22, 03:09

  13. Benjamin Franzke commented on patch set 3 04/16/22, 03:09

    Reply

    also needs to be adapted in the commit message. (done)
  14. core-ci voted on patch set 3 V -1 04/16/22, 03:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26086

  15. core-ci voted on patch set 3 V +1 04/16/22, 03:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26086

  16. Stefan Bürk voted on patch set 3 V +1 CR +1 04/16/22, 07:45

  17. Oliver Klee voted on patch set 3 CR +1 04/16/22, 08:13

  18. Benni Mack voted on patch set 3 V +2 CR +2 04/16/22, 19:48

  19. Benni Mack merged patch set 4 04/16/22, 19:48

  20. Nikita Hovratov commented on patch set 4 04/16/22, 19:56

    Reply

    Unless someone extended HttpUtility::buildUrl but that's unlikely.