74290[!!!][TASK] Add native types to MailUtility
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- core-ci +1 CI
Issues 3
Files 4
Review log 2633
Show 68 earlier messages
-
crell uploaded patch set 1 04/13/22, 16:45
-
crell updated the commit message in patch set 2 04/13/22, 16:47
-
Oliver Klee voted on patch set 2 CR +1 04/13/22, 16:52
-
core-ci voted on patch set 2 V +1 04/13/22, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25997
-
core-ci voted on patch set 1 V +1 04/13/22, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25996
-
Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/14/22, 18:30
-
Oliver Hader commented on patch set 2 CR -1 05/02/22, 09:41
-
crell uploaded patch set 3 05/02/22, 16:44
-
crell commented on patch set 2 05/02/22, 16:44
MailUtility.php:58ReplyAck -
core-ci voted on patch set 3 V +1 05/02/22, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26739
-
Oliver Klee commented on patch set 3 05/02/22, 17:50
MailUtility.php:58Please let’s make the check explicit: (is_string($name) && $name !== ‘’) (That is a slight change in behaviors as “0” now won’t be returned if it is set, but that’s acceptable as it’s more a bug fix IMHO.) -
Oliver Klee commented on patch set 3 05/02/22, 18:00
MailUtility.php:58ReplyAh, sorry, it’s the other way around. Anyway, please let’s make this explicit instead of relying on what a bool cast does. -
crell commented on patch set 3 05/02/22, 21:35
MailUtility.php:58ReplyIf we're going to make subtle behavior changes around falsey values, I'd prefer the original code (turn any non-string into null). I've been trying to avoid any behavior changes if I can help it, unless it's an obvious bug fix. -
Oliver Klee commented on patch set 3 05/02/22, 21:56
MailUtility.php:58ReplyWithout a behavior change, I’d propose this snippet to avoid the implicit bool cast: return (!empty($name) && is_string($name)) ? $name : null; -
crell uploaded patch set 4 05/03/22, 17:02
-
crell commented on patch set 3 05/03/22, 17:02
MailUtility.php:58ReplyDone -
Oliver Klee voted on patch set 4 CR +1 05/03/22, 17:03
-
core-ci voted on patch set 4 V +1 05/03/22, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26773
-
Nikita Hovratov uploaded patch set 5 05/06/22, 11:51
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 05/06/22, 11:53
-
Oliver Klee voted on patch set 5 CR +1 05/06/22, 11:57
-
core-ci voted on patch set 5 V +1 05/06/22, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26907
-
Stefan Bürk commented on patch set 5 CR -1 05/06/22, 13:46
MailUtility.php:32Was not part of this patch, but as this patch changes the docblock we should add a correct description, as there are two kind of array structures 1. string-key: email(-address) value: name 2. int-key: pos value: email(-address) 3. no-array: null (not configured)MailUtility.php:94Was not part of this patch, but as this patch changes the docblock we should add a correct description, as there are two kind of array items are possible 1. string-key: email(-address) value: name 2. int-key: pos value: email(-address) The "replyToName <replyTo@example.com>" is somehow misleading - or not ? -
Nikita Hovratov uploaded patch set 6 05/06/22, 14:06
-
Nikita Hovratov commented on patch set 5 V +1 CR +1 05/06/22, 14:08
MailUtility.php:94ReplyThanks for the hint. Adjusted the doc block message. Removed the misleading sentence, as well (maybe copy paste from the past?) -
Nikita Hovratov commented on patch set 6 05/06/22, 14:08
MailUtility.php:32ReplyDone -
Oliver Klee voted on patch set 6 CR +1 05/06/22, 14:13
-
core-ci voted on patch set 6 V +1 05/06/22, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26919
-
Nikita Hovratov uploaded patch set 7 05/07/22, 17:37
-
core-ci voted on patch set 7 V +1 05/07/22, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26972
-
Oliver Klee voted on patch set 7 V +1 CR +1 05/07/22, 17:55
-
Nikita Hovratov voted on patch set 7 V +2 CR +2 05/07/22, 18:08
-
Nikita Hovratov merged patch set 8 05/07/22, 18:08
MailUtility.php:58