Review main Merged Breaking

74312[!!!][TASK] Add native types to PathUtility

crell CR +2 V +2 Normal +40 −40 updated 04/22/22, 13:23

Commit message

I also changed the default value for pathinfo()'s $options
argument to match that of PHP's pathinfo(), as that eliminated
a null and simplified the code.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Jörg Bösche +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 911

  1. crell uploaded patch set 1 04/13/22, 17:29

  2. core-ci voted on patch set 1 V +1 04/13/22, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25999

  3. Oliver Klee voted on patch set 1 CR +1 04/13/22, 17:53

  4. crell uploaded patch set 2 04/13/22, 19:48

  5. core-ci voted on patch set 2 V +1 04/13/22, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26005

  6. Jörg Bösche voted on patch set 2 CR +1 04/14/22, 08:06

  7. Oliver Klee voted on patch set 2 CR +1 04/14/22, 09:31

  8. Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/20/22, 15:02

  9. Georg Ringer voted on patch set 2 V +2 CR +2 04/22/22, 11:47

  10. Georg Ringer merged patch set 3 04/22/22, 11:48

  11. Andreas Kienast commented on patch set 3 04/22/22, 13:23

    post -1 it's a breaking change but no rst changes were made