Review main Abandoned Breaking

74314[!!!][TASK] Add native typing to ResourceUtility

crell CR 0 V 0 Easy +7 −22 updated 05/07/22, 17:31

Commit message

Also, small refactoring to use ternary expression in the
nameCompareSortingHelper method.

Review

  • Code review CR 0
  • Verified V 0

Issues 3

Files 3

Review log 2326

Show 1 earlier messages
  1. crell uploaded patch set 1 04/13/22, 18:03

  1. core-ci voted on patch set 1 V +1 04/13/22, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26001

  2. Oliver Klee voted on patch set 1 CR +1 04/13/22, 19:16

  3. crell uploaded patch set 2 04/13/22, 19:43

  4. core-ci voted on patch set 2 V +1 04/13/22, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26004

  5. Oliver Klee voted on patch set 2 CR +1 04/13/22, 21:52

  6. Benni Mack voted on patch set 2 V +1 CR +1 04/14/22, 20:37

  7. Nikita Hovratov voted on patch set 2 CR +1 04/15/22, 16:57

  8. Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/18/22, 19:52

  9. Stefan Bürk commented on patch set 2 04/18/22, 20:23

    Should be added to corresponding Breaking ReST file.
  10. Simon Schaufelberger commented on patch set 2 04/18/22, 20:28

    Reply

    as mentioned in the slack channel, this will be done later.
  11. Simon Schaufelberger commented on patch set 2 04/18/22, 20:29

  12. Jörg Bösche voted on patch set 2 CR +1 04/27/22, 11:14

  13. Stefan Bürk commented on patch set 2 CR -1 04/27/22, 13:51

    Seems to be more a internal class. However, not marked as such. Breaking ReST file missing. (Either dedicated one or amending to a collection Breaking ReST file).
  14. Nikita Hovratov uploaded patch set 3 05/06/22, 12:05

  15. core-ci voted on patch set 3 V +1 05/06/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26908

  16. Nikita Hovratov commented on patch set 3 V -1 CR -1 05/06/22, 12:13

    This class is not used internally since TYPO3 7.2. See here: http://review.typo3.org/28560 I suggest to deprecate, or simply remove this utility, as Stefan said, it was only intended for internal usage and has been replaced as direct implementation in LocalDriver.
  17. Oliver Klee commented on patch set 3 05/06/22, 12:28

    Reply

    As the class is not marked as @internal or @deprecated, we cannot remove it yet (following or deprecation and removal policy). Short-term, I'd like to have this cleanup. Would you be okay with this change getting merged, and then deprecating the class in a difference changeset?
  18. Nikita Hovratov commented on patch set 3 05/06/22, 12:40

    Reply

    I'm ok with deprecating first. But why should we touch this class, if we are about to remove it anyway?
  19. Oliver Klee commented on patch set 3 05/06/22, 12:51

    Reply

    Mostly for two reasons: - We show that we value the work that Larry has put into this (and it doesn't hurt to merge this). - We hopefully avoid some new PHPStan warnings if/when we bump the PHPStan level before the class is removed.
  20. Nikita Hovratov commented on patch set 3 05/06/22, 13:00

    Reply

    We value his work of course, there is no doubt about that. However, this should never be a metric to decide, if a patch should get merged. About the PHPStan argument, I don't see a raise of the PHPStan level anytime soon in our over 1000 error big baseline file. And even if, this patch will likely not change anything, as it is not used in core core and thus PHPStan won't detect anything new.
  21. Oliver Klee commented on patch set 3 05/06/22, 13:11

    Reply Unresolved

    > We value his work of course, there is no doubt about that. However, this should never be a metric to decide, if a patch should get merged. This is the metric that I usually apply for my projects: If a change provides some benefit (or does no harm) and does not contradict the product's vision, then merge it. ("No harm" includes "does not increase the required maintenance work." I find this helpful for motivating contributors.
  22. Oliver Klee commented on patch set 3 05/06/22, 13:12

    What would be the harm in merging this? (This is a real question, not a rhetorical question, and I'm eager to hear your thoughts on this.)
  23. Nikita Hovratov commented on patch set 3 05/06/22, 13:36

    Reply

    unnecessary breaking change
  24. Oliver Klee commented on patch set 3 05/06/22, 13:49

    Reply

    Ack
  25. Nikita Hovratov abandoned the change 05/07/22, 17:31

    This class will be deprecated instead.