74317[!!!][TASK] Add native types to VersionNumberUtility
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/core/Classes/ExpressionLanguage/FunctionsProvider/DefaultFunctionsProvider.php4+3 −5
- typo3/sysext/core/Classes/Utility/VersionNumberUtility.php4+15 −19
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97210-TypesAddedToMethodSignaturesOrClassProperties.rst+1 −0
- typo3/sysext/core/Tests/Unit/Utility/VersionNumberUtilityTest.php+1 −1
Review log 2838
Show 1113 earlier messages
-
crell uploaded patch set 1 04/13/22, 20:21
-
core-ci voted on patch set 1 V -1 04/13/22, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26007
-
crell commented on patch set 1 04/15/22, 00:10
Hm, this is weird. The test failures are in the ConditionMatcherTest class, but... nothing in that routine calls VersionNumberUtility at all. It uses Symfony ExpressionLanguage, but not VersionNumberUtility. So why is it failing? -
Stefan Bürk commented on patch set 1 04/15/22, 09:14
Reply
Because default expression functions / registered condition function are executed along. It calls `[compatVersion(...)]` which is defined here: \TYPO3\CMS\Core\ExpressionLanguage\FunctionsProvider->getCompatVersionFunction(...) -
crell uploaded patch set 2 04/15/22, 14:56
-
core-ci voted on patch set 2 V +1 04/15/22, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26050
-
Oliver Klee voted on patch set 2 CR +1 04/15/22, 15:13
-
Stefan Bürk commented on patch set 2 04/15/22, 15:55
FYI: That comes from TypoScript parsing: compatVersion(7.1) -> float 7.1 compatVersion("7.1") -> string "7.1" compatVersion('7.1') -> string "7.1"DefaultFunctionsProvider.php:74Would suggest to avoid this for now. Should be handled prior in TypoScript parsing I think. Additional it's kind of confusing with '$strÄ as name to "type" float for it .... Beside's this, would not match the scheme for other usages here - would delay it. However - no blocking from my side if it stays. -
crell commented on patch set 2 04/15/22, 16:12
Reply
AckDefaultFunctionsProvider.php:74ReplyWe could also rename the variable and/or leave an additional comment for now. The irony is, I can see TypoScript parsing those values like that as the correct behavior over there, but it means the cast here becomes necessary to connect the two together. I don't know what else we could do without making either TypoScript or VersionNumberUtility technically wrong on their own. -
Stefan Bürk commented on patch set 2 04/19/22, 15:53
DefaultFunctionsProvider.php:74ReplyWould suggest to leave the type for the argument out. Simply/only do the string-cast in L77. Not that much important yet, and we have here kind of bridge between areas without strict-type ensuring (yet). So remove the float|string here for now. -
crell uploaded patch set 3 04/26/22, 18:06
-
crell commented on patch set 2 04/26/22, 18:06
DefaultFunctionsProvider.php:74ReplyDone -
crell updated the commit message in patch set 4 04/26/22, 18:07
-
crell commented on patch set 3 04/26/22, 18:07
Reply
Done -
core-ci voted on patch set 3 V +1 04/26/22, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26467
-
core-ci voted on patch set 4 V -1 04/26/22, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26468
-
Stefan Bürk commented on patch set 4 04/26/22, 18:32
breaking -> breaking rst + marked as breaking ([!!!]) rst missing. -
core-ci voted on patch set 4 V +1 04/26/22, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26468
-
Oliver Klee commented on patch set 4 04/27/22, 10:38
VersionNumberUtility.php:51We can drop this line.VersionNumberUtility.php:68We can drop this line. -
crell uploaded patch set 5 04/27/22, 15:34
-
crell commented on patch set 5 04/27/22, 15:35
Reply
VersionNumberUtility.php:51ReplyDoneVersionNumberUtility.php:68ReplyDone -
Oliver Klee voted on patch set 5 CR +1 04/27/22, 15:36
-
core-ci voted on patch set 5 V -1 04/27/22, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26523
-
crell rebased onto patch set 6 05/03/22, 22:46
-
core-ci voted on patch set 6 V +1 05/03/22, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26780
-
Oliver Klee voted on patch set 6 CR +1 05/04/22, 11:04
-
Nikita Hovratov uploaded patch set 7 05/06/22, 11:13
-
Nikita Hovratov voted on patch set 7 V +1 CR +1 05/06/22, 11:14
-
Oliver Klee voted on patch set 7 CR +1 05/06/22, 11:15
-
core-ci voted on patch set 7 V -1 05/06/22, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26903
-
core-ci voted on patch set 7 V +1 05/06/22, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26903
-
Stefan Bürk voted on patch set 7 CR -1 05/06/22, 11:41
-
Stefan Bürk uploaded patch set 8 05/06/22, 11:50
-
Nikita Hovratov voted on patch set 8 V +1 CR +1 05/06/22, 11:52
-
Oliver Klee voted on patch set 8 CR +1 05/06/22, 11:57
-
core-ci voted on patch set 8 V +1 05/06/22, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26906
-
Stefan Bürk voted on patch set 8 V +2 CR +2 05/06/22, 12:13
-
Stefan Bürk merged patch set 9 05/06/22, 12:13