Review main Merged Breaking

74317[!!!][TASK] Add native types to VersionNumberUtility

crell CR +2 V +2 Easy +20 −25 updated 05/06/22, 12:13

Commit message

Also, a little cleanup in DefaultFunctionsProvider.
The method getCompatVersionFunction() was
calling convertVersionNumberToInteger() with an inconsistent
type as a result of TypoScript parsing. We therefore need to
force-cast it to a string, which is what
convertVersionNumberToInteger() wants.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 2838

Show 1113 earlier messages
  1. crell uploaded patch set 1 04/13/22, 20:21

  2. core-ci voted on patch set 1 V -1 04/13/22, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26007

  3. crell commented on patch set 1 04/15/22, 00:10

    Hm, this is weird. The test failures are in the ConditionMatcherTest class, but... nothing in that routine calls VersionNumberUtility at all. It uses Symfony ExpressionLanguage, but not VersionNumberUtility. So why is it failing?
  4. Stefan Bürk commented on patch set 1 04/15/22, 09:14

    Reply

    Because default expression functions / registered condition function are executed along. It calls `[compatVersion(...)]` which is defined here: \TYPO3\CMS\Core\ExpressionLanguage\FunctionsProvider->getCompatVersionFunction(...)
  5. crell uploaded patch set 2 04/15/22, 14:56

  6. core-ci voted on patch set 2 V +1 04/15/22, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26050

  7. Oliver Klee voted on patch set 2 CR +1 04/15/22, 15:13

  8. Stefan Bürk commented on patch set 2 04/15/22, 15:55

    FYI: That comes from TypoScript parsing: compatVersion(7.1) -> float 7.1 compatVersion("7.1") -> string "7.1" compatVersion('7.1') -> string "7.1"

    DefaultFunctionsProvider.php:74

    Would suggest to avoid this for now. Should be handled prior in TypoScript parsing I think. Additional it's kind of confusing with '$strÄ as name to "type" float for it .... Beside's this, would not match the scheme for other usages here - would delay it. However - no blocking from my side if it stays.
  9. crell commented on patch set 2 04/15/22, 16:12

    Reply

    Ack

    DefaultFunctionsProvider.php:74 Reply

    We could also rename the variable and/or leave an additional comment for now. The irony is, I can see TypoScript parsing those values like that as the correct behavior over there, but it means the cast here becomes necessary to connect the two together. I don't know what else we could do without making either TypoScript or VersionNumberUtility technically wrong on their own.
  10. Stefan Bürk commented on patch set 2 04/19/22, 15:53

    DefaultFunctionsProvider.php:74 Reply

    Would suggest to leave the type for the argument out. Simply/only do the string-cast in L77. Not that much important yet, and we have here kind of bridge between areas without strict-type ensuring (yet). So remove the float|string here for now.
  11. crell uploaded patch set 3 04/26/22, 18:06

  12. crell commented on patch set 2 04/26/22, 18:06

    DefaultFunctionsProvider.php:74 Reply

    Done
  13. crell updated the commit message in patch set 4 04/26/22, 18:07

  1. crell commented on patch set 3 04/26/22, 18:07

    Reply

    Done
  2. core-ci voted on patch set 3 V +1 04/26/22, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26467

  3. core-ci voted on patch set 4 V -1 04/26/22, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26468

  4. Stefan Bürk commented on patch set 4 04/26/22, 18:32

    breaking -> breaking rst + marked as breaking ([!!!]) rst missing.
  5. core-ci voted on patch set 4 V +1 04/26/22, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26468

  6. Oliver Klee commented on patch set 4 04/27/22, 10:38

    VersionNumberUtility.php:51

    We can drop this line.

    VersionNumberUtility.php:68

    We can drop this line.
  7. crell uploaded patch set 5 04/27/22, 15:34

  8. crell commented on patch set 5 04/27/22, 15:35

    VersionNumberUtility.php:51 Reply

    Done

    VersionNumberUtility.php:68 Reply

    Done
  9. Oliver Klee voted on patch set 5 CR +1 04/27/22, 15:36

  10. core-ci voted on patch set 5 V -1 04/27/22, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26523

  11. crell rebased onto patch set 6 05/03/22, 22:46

  12. core-ci voted on patch set 6 V +1 05/03/22, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26780

  13. Oliver Klee voted on patch set 6 CR +1 05/04/22, 11:04

  14. Nikita Hovratov uploaded patch set 7 05/06/22, 11:13

  15. Nikita Hovratov voted on patch set 7 V +1 CR +1 05/06/22, 11:14

  16. Oliver Klee voted on patch set 7 CR +1 05/06/22, 11:15

  17. core-ci voted on patch set 7 V -1 05/06/22, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26903

  18. core-ci voted on patch set 7 V +1 05/06/22, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26903

  19. Stefan Bürk voted on patch set 7 CR -1 05/06/22, 11:41

  20. Stefan Bürk uploaded patch set 8 05/06/22, 11:50

  21. Nikita Hovratov voted on patch set 8 V +1 CR +1 05/06/22, 11:52

  22. Oliver Klee voted on patch set 8 CR +1 05/06/22, 11:57

  23. core-ci voted on patch set 8 V +1 05/06/22, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26906

  24. Stefan Bürk voted on patch set 8 V +2 CR +2 05/06/22, 12:13

  25. Stefan Bürk merged patch set 9 05/06/22, 12:13