Review main Merged

74319[FEATURE] Add TCA option nullable instead of eval=null

Nikita Hovratov CR +2 V +2 Hard +373 −132 updated 04/18/22, 10:11

Commit message

This patch replaces the "eval=null" option with the
direct option "nullable". The goal is to further
thin out "eval" and even remove it from some types
completely.

The TCA types password, datetime, link, number and
color now don't have the TCA option "eval" anymore.

A lot of code can now be simplified due to the
removed lookup into the eval list.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1822

  1. Nikita Hovratov uploaded patch set 1 04/14/22, 15:41

  2. core-ci voted on patch set 1 V -1 04/14/22, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26026

  3. Nikita Hovratov uploaded patch set 2 04/14/22, 16:08

  4. core-ci voted on patch set 2 V -1 04/14/22, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26027

  5. Nikita Hovratov uploaded patch set 3 04/14/22, 16:23

  6. core-ci voted on patch set 3 V +1 04/14/22, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26030

  7. Oli Bartsch commented on patch set 3 CR -1 04/14/22, 16:50

    TcaMigrationTest.php:1491

    We should not introduce cross dependencies. If we rely on transformation of "eval=>null" to "nullable=>true", the corresponding migration must take care of it. Otherwise it would depend on the order, which means, this test would fail if we would move the nullable migration.
  8. Nikita Hovratov commented on patch set 3 04/14/22, 17:21

    TcaMigrationTest.php:1491 Reply

    How would you do it? Just remove null from the test?
  9. Nikita Hovratov commented on patch set 3 04/14/22, 17:24

    TcaMigrationTest.php:1491 Reply

    This is done with required too btw
  10. Nikita Hovratov uploaded patch set 4 04/14/22, 19:19

  11. Nikita Hovratov commented on patch set 4 04/14/22, 19:19

    TcaMigrationTest.php:1491 Reply

    Done
  12. core-ci voted on patch set 4 V +1 04/14/22, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26032

  13. Benni Mack commented on patch set 4 CR +1 04/16/22, 19:53

    I'm very much in favor of also removing this from FormEngine "eval" and have a separate attribute "nullable" instead of the eval list, but I guess this could be done as a followup.
  14. Nikita Hovratov commented on patch set 4 04/16/22, 19:56

    Reply

    yep, followup it will be
  15. Stefan Bürk commented on patch set 4 04/17/22, 18:44

    Note: If this gets merged, we need a followup change in ext:styleguide to avoid TCA migration there, as this would fail in the github/nightly there then. And after doing that, update/raise it in core. Not checked if there are core tests testing this against styleguide some how. Just to note here needed follow up.
  16. Nikita Hovratov commented on patch set 4 04/17/22, 19:48

  17. Susi Moog voted on patch set 4 CR +1 04/17/22, 19:53

  18. Stefan Bürk voted on patch set 4 CR +1 04/17/22, 20:19

  19. Benni Mack voted on patch set 4 V +1 04/17/22, 20:24

  20. Stefan Bürk voted on patch set 4 V +1 04/17/22, 20:28

  21. Benni Mack voted on patch set 4 V +2 CR +2 04/18/22, 10:11

  22. Benni Mack merged patch set 5 04/18/22, 10:11