74319[FEATURE] Add TCA option nullable instead of eval=null
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 25
- Build/phpstan/phpstan-baseline.neon+1 −6
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+2 −4
- typo3/sysext/backend/Classes/Form/Element/ColorElement.php+5 −5
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+5 −5
- typo3/sysext/backend/Classes/Form/Element/EmailElement.php+5 −1
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+4 −0
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php+5 −5
- typo3/sysext/backend/Classes/Form/Element/NumberElement.php+5 −5
- typo3/sysext/backend/Classes/Form/Element/PasswordElement.php+5 −5
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+4 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowDefaultValues.php+2 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowDefaultValuesTest.php+3 −3
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+5 −5
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+64 −52
- typo3/sysext/core/Configuration/TCA/sys_file_reference.php+3 −3
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-97384-TCAOptionNullable.rstnew+60 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97013-NewTCATypeEmail.rst+2 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97104-NewTCATypePassword.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97159-NewTCATypeLink.rst+5 −5
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97193-NewTCATypeNumber.rst+1 −1
Show 5 more files
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97232-NewTCATypeDatetime.rst+2 −3
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97271-NewTCATypeColor.rst+2 −3
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97384-TCAOptionNullable.rstnew+37 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/AbstractActionTestCase.php+1 −1
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php4+144 −15
Review log 1822
-
Nikita Hovratov uploaded patch set 1 04/14/22, 15:41
-
core-ci voted on patch set 1 V -1 04/14/22, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26026
-
Nikita Hovratov uploaded patch set 2 04/14/22, 16:08
-
core-ci voted on patch set 2 V -1 04/14/22, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26027
-
Nikita Hovratov uploaded patch set 3 04/14/22, 16:23
-
core-ci voted on patch set 3 V +1 04/14/22, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26030
-
Oli Bartsch commented on patch set 3 CR -1 04/14/22, 16:50
-
Nikita Hovratov commented on patch set 3 04/14/22, 17:21
TcaMigrationTest.php:1491ReplyHow would you do it? Just remove null from the test? -
Nikita Hovratov commented on patch set 3 04/14/22, 17:24
TcaMigrationTest.php:1491ReplyThis is done with required too btw -
Nikita Hovratov uploaded patch set 4 04/14/22, 19:19
-
Nikita Hovratov commented on patch set 4 04/14/22, 19:19
TcaMigrationTest.php:1491ReplyDone -
core-ci voted on patch set 4 V +1 04/14/22, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26032
-
Benni Mack commented on patch set 4 CR +1 04/16/22, 19:53
I'm very much in favor of also removing this from FormEngine "eval" and have a separate attribute "nullable" instead of the eval list, but I guess this could be done as a followup. -
Nikita Hovratov commented on patch set 4 04/16/22, 19:56
Reply
yep, followup it will be -
Stefan Bürk commented on patch set 4 04/17/22, 18:44
Note: If this gets merged, we need a followup change in ext:styleguide to avoid TCA migration there, as this would fail in the github/nightly there then. And after doing that, update/raise it in core. Not checked if there are core tests testing this against styleguide some how. Just to note here needed follow up. -
Nikita Hovratov commented on patch set 4 04/17/22, 19:48
-
Susi Moog voted on patch set 4 CR +1 04/17/22, 19:53
-
Stefan Bürk voted on patch set 4 CR +1 04/17/22, 20:19
-
Benni Mack voted on patch set 4 V +1 04/17/22, 20:24
-
Stefan Bürk voted on patch set 4 V +1 04/17/22, 20:28
-
Benni Mack voted on patch set 4 V +2 CR +2 04/18/22, 10:11
-
Benni Mack merged patch set 5 04/18/22, 10:11
TcaMigrationTest.php:1491