74320[BUGFIX] Fix type annotation of HistoryService::differencesObject
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 910
-
Oliver Klee uploaded patch set 1 04/14/22, 16:24
-
Oli Bartsch commented on patch set 1 04/14/22, 16:43
-
core-ci voted on patch set 1 V +1 04/14/22, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26031
-
Oliver Klee commented on patch set 1 04/14/22, 16:45
HistoryService.php:43ReplyI'd like this change to get backported to 11.5 as well. So I'd like to be very conservative with the change here. (I have not objections against initializing the property in the constructor in a separate main-only changeset, though.) -
Oli Bartsch commented on patch set 1 04/14/22, 18:29
HistoryService.php:43ReplyAck -
Benni Mack voted on patch set 1 CR +1 04/14/22, 20:31
-
Oli Bartsch voted on patch set 1 V +1 CR +1 04/14/22, 20:36
-
Benni Mack voted on patch set 1 V +1 04/14/22, 20:36
-
Benni Mack voted on patch set 1 V +2 CR +2 04/14/22, 20:52
-
Benni Mack merged patch set 2 04/14/22, 20:52
HistoryService.php:43