Review main Merged

74320[BUGFIX] Fix type annotation of HistoryService::differencesObject

Oliver Klee CR +2 V +2 Easy +1 −6 updated 04/14/22, 20:52

Commit message

This field actually is nullable and needs to be annotated accordingly.

This change fixes a PHPStan warning.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 910

  1. Oliver Klee uploaded patch set 1 04/14/22, 16:24

  2. Oli Bartsch commented on patch set 1 04/14/22, 16:43

    HistoryService.php:43

    What do you think about initializing the property in the constructor instead? Actually, I don't see any reason for a class property at all, but this might be resolved in main only.
  3. core-ci voted on patch set 1 V +1 04/14/22, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26031

  4. Oliver Klee commented on patch set 1 04/14/22, 16:45

    HistoryService.php:43 Reply

    I'd like this change to get backported to 11.5 as well. So I'd like to be very conservative with the change here. (I have not objections against initializing the property in the constructor in a separate main-only changeset, though.)
  5. Oli Bartsch commented on patch set 1 04/14/22, 18:29

    HistoryService.php:43 Reply

    Ack
  6. Benni Mack voted on patch set 1 CR +1 04/14/22, 20:31

  7. Oli Bartsch voted on patch set 1 V +1 CR +1 04/14/22, 20:36

  8. Benni Mack voted on patch set 1 V +1 04/14/22, 20:36

  9. Benni Mack voted on patch set 1 V +2 CR +2 04/14/22, 20:52

  10. Benni Mack merged patch set 2 04/14/22, 20:52