Review main Abandoned

74321[TASK] Make session time of install tool overrideable

Simon Schaufelberger CR 0 V 0 Easy +8 −6 updated 10/23/23, 12:27

Commit message

Make it possible to XCLASS the SessionService and override the session
time in the install tool for local development environments

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 1824

  1. Simon Schaufelberger uploaded patch set 1 04/14/22, 23:02

  2. Simon Schaufelberger updated the commit message in patch set 2 04/14/22, 23:02

  3. Simon Schaufelberger updated the commit message in patch set 3 04/14/22, 23:04

  4. Simon Schaufelberger updated the commit message in patch set 4 04/14/22, 23:05

  5. Simon Schaufelberger commented on patch set 4 04/14/22, 23:08

    I don't conder this a feature as the SessionService is no public API
  6. Simon Schaufelberger commented on patch set 4 04/14/22, 23:08

    Reply

    *consider
  7. core-ci voted on patch set 3 V +1 04/14/22, 23:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26043

  8. core-ci voted on patch set 4 V +1 04/14/22, 23:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26044

  9. core-ci voted on patch set 2 V -1 04/14/22, 23:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26042

  10. core-ci voted on patch set 1 V +1 04/14/22, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26041

  11. Benjamin Franzke commented on patch set 4 CR -1 04/16/22, 03:58

    The SessionService isn't XCLASSable, as it is being instantiated with plain `new`. Use a composer-patch instead, or better: * use a password manager * use echo KEEP_FILE > public/typo3conf/ENABLE_INSTALL_TOOL for you development setup in order to opt-out from having to create the ENABLE_INSTALL_TOOL file over and over again.
  12. Oliver Klee commented on patch set 4 04/16/22, 08:14

    SessionService.php:55

    I propose we switch to native types for the two fields now so we don't need to have a breaking change with this later. (Now it won't be breaking yet.)
  13. Simon Schaufelberger uploaded patch set 5 04/18/22, 19:46

  14. Oliver Klee voted on patch set 5 CR +1 04/18/22, 19:57

  15. core-ci voted on patch set 5 V +1 04/18/22, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26167

  16. Stefan Bürk commented on patch set 5 CR -1 04/18/22, 20:09

    Reply Unresolved

    -1 from Benjamin still applies.
  17. Simon Schaufelberger uploaded patch set 6 04/18/22, 20:25

  18. Simon Schaufelberger commented on patch set 6 04/18/22, 20:26

    SessionService.php:55 Reply

    Done
  19. core-ci voted on patch set 6 V +1 04/18/22, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26170

  20. Oliver Klee voted on patch set 6 CR +1 04/18/22, 21:53

  21. Benjamin Franzke voted on patch set 6 CR -2 04/19/22, 08:40

  22. Simon Schaufelberger marked it work in progress 04/26/22, 19:36

  23. Christian Kuhn commented on patch set 6 10/23/23, 12:27

    Hey. It seems this patch won't find consensus. I agree to Benjamin that 'keep_file' / pw managers should be enough in this case, and that install tool should not be xclass'able, especially not in this security relevant area. If you still really need this, a local patch on your own risk could be a better approach. I hope it's ok to abandon.
  24. Christian Kuhn abandoned the change 10/23/23, 12:27