74324[TASK] Annotate nullable properties in workspaces extension as such
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 11
- Build/phpstan/phpstan-baseline.neon+0 −100
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php4+1 −1
- typo3/sysext/workspaces/Classes/DataHandler/CommandMap.php2+1 −1
- typo3/sysext/workspaces/Classes/Dependency/DependencyResolver.php2+2 −2
- typo3/sysext/workspaces/Classes/Dependency/ElementEntity.php+4 −4
- typo3/sysext/workspaces/Classes/Dependency/ElementEntityProcessor.php+1 −1
- typo3/sysext/workspaces/Classes/Domain/Model/DatabaseRecord.php+1 −1
- typo3/sysext/workspaces/Classes/Domain/Record/StageRecord.php+4 −4
- typo3/sysext/workspaces/Classes/Domain/Record/WorkspaceRecord.php+3 −3
- typo3/sysext/workspaces/Classes/Service/Dependency/CollectionService.php+2 −2
- typo3/sysext/workspaces/Classes/Service/GridDataService.php2+1 −1
Review log 78
-
Oliver Klee uploaded patch set 1 04/15/22, 16:09
-
core-ci voted on patch set 1 V +1 04/15/22, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26054
-
Stefan Bürk commented on patch set 1 04/15/22, 16:25
CommandMap.php:82Should we not make this created(inject in the constructor for now ? Leaving out the nullable union type here, and remove check and instantiating in the corresponding getter method ? Workspace can be sed even on injected method - or not ?DependencyResolver.php:31Should we not make this injected or at least created in the constructor for now ? Leaving out the nullable union type here, and remove check and instantiating in the corresponding getter method ?GridDataService.php:86Should we not make this injected or at least created in the constructor for now ? Leaving out the nullable union type here, and remove check and instantiating in the corresponding getter method ? -
Oliver Klee commented on patch set 1 04/15/22, 16:28
RemoteServer.php:69ReplyIt's the same as https://review.typo3.org/c/Packages/TYPO3.CMS/+/74320: :-) I'd like this fix to get backported to 11.5, which means we cannot have breaking or more disruptive changes here. This shouldn't stop us from clean this up further in main once the backportable changes are merged. That's currently my general approach to PHPStan fixes. Would that be okay with you? -
Oliver Klee commented on patch set 1 04/15/22, 16:29
RemoteServer.php:69ReplyAnd in my next changeset, I'll do my best to add a description/explanation of this approach to the commit message so reviewers don't need to spend time on pointing this out. :-) -
Stefan Bürk commented on patch set 1 V +1 CR +1 04/15/22, 17:40
RemoteServer.php:69ReplyI remember - one note to mention the approach would have been nice. And void the next person on the next patch to stumple over it.CommandMap.php:82Reply^ will be done dedicated to main in a follow up. See other comment for explanation.DependencyResolver.php:31Reply^ will be done dedicated to main in a follow up. See other comment for explanation.GridDataService.php:86Reply^ will be done dedicated to main in a follow up. See other comment for explanation. -
Benni Mack voted on patch set 1 V +2 CR +2 04/17/22, 10:37
-
Benni Mack merged patch set 2 04/17/22, 10:37
RemoteServer.php:69