Review main Merged

74324[TASK] Annotate nullable properties in workspaces extension as such

Oliver Klee CR +2 V +2 Normal +20 −120 updated 04/17/22, 10:37

Commit message

This fixes a whole bunch of PHPStan warnings.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 78

  1. Oliver Klee uploaded patch set 1 04/15/22, 16:09

  2. core-ci voted on patch set 1 V +1 04/15/22, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26054

  3. Stefan Bürk commented on patch set 1 04/15/22, 16:25

    RemoteServer.php:69

    Should we not make this injected or at least created in the constructor for now ? Leaving out the nullable union type here, and remove check and instantiating in the corresponding getter method ?

    CommandMap.php:82

    Should we not make this created(inject in the constructor for now ? Leaving out the nullable union type here, and remove check and instantiating in the corresponding getter method ? Workspace can be sed even on injected method - or not ?

    DependencyResolver.php:31

    Should we not make this injected or at least created in the constructor for now ? Leaving out the nullable union type here, and remove check and instantiating in the corresponding getter method ?

    GridDataService.php:86

    Should we not make this injected or at least created in the constructor for now ? Leaving out the nullable union type here, and remove check and instantiating in the corresponding getter method ?
  4. Oliver Klee commented on patch set 1 04/15/22, 16:28

    RemoteServer.php:69 Reply

    It's the same as https://review.typo3.org/c/Packages/TYPO3.CMS/+/74320: :-) I'd like this fix to get backported to 11.5, which means we cannot have breaking or more disruptive changes here. This shouldn't stop us from clean this up further in main once the backportable changes are merged. That's currently my general approach to PHPStan fixes. Would that be okay with you?
  5. Oliver Klee commented on patch set 1 04/15/22, 16:29

    RemoteServer.php:69 Reply

    And in my next changeset, I'll do my best to add a description/explanation of this approach to the commit message so reviewers don't need to spend time on pointing this out. :-)
  6. Stefan Bürk commented on patch set 1 V +1 CR +1 04/15/22, 17:40

    RemoteServer.php:69 Reply

    I remember - one note to mention the approach would have been nice. And void the next person on the next patch to stumple over it.

    CommandMap.php:82 Reply

    ^ will be done dedicated to main in a follow up. See other comment for explanation.

    DependencyResolver.php:31 Reply

    ^ will be done dedicated to main in a follow up. See other comment for explanation.

    GridDataService.php:86 Reply

    ^ will be done dedicated to main in a follow up. See other comment for explanation.
  7. Benni Mack voted on patch set 1 V +2 CR +2 04/17/22, 10:37

  8. Benni Mack merged patch set 2 04/17/22, 10:37