Review main Merged

74325[TASK] Raise PHPStan to version 1.5.6

Oliver Klee CR +2 V +2 Normal +39 −72 updated 04/16/22, 11:16

Commit message

The new version finds some new possible bugs and
removes some incorrect ones.

Also update phpstan/phpstan-phpunit.

Used commands:
> composer req --dev phpstan/phpstan:^1.5.6
> composer req --dev phpstan/phpstan-phpunit:^1.1.0
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Oliver Klee uploaded patch set 1 04/15/22, 16:18

  2. Oliver Klee uploaded patch set 2 04/15/22, 16:31

  3. core-ci voted on patch set 1 V +1 04/15/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26055

  4. core-ci voted on patch set 2 V +1 04/15/22, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26056

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 04/15/22, 17:42

  6. Benni Mack voted on patch set 2 V +2 CR +2 04/16/22, 11:16

  7. Benni Mack merged patch set 3 04/16/22, 11:16