74326[TASK] Apply quote coding standards to YAML files
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Jörg Bösche +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Tests/Functional/Controller/Page/Fixtures/PagesWithBEPermissions.yaml+5 −5
- typo3/sysext/core/Configuration/RTE/SysNews.yaml+3 −3
- typo3/sysext/core/Configuration/Services.yaml+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/Loader/Fixtures/Berta.yaml+1 −1
- typo3/sysext/extensionmanager/Configuration/Services.yaml2+2 −2
- typo3/sysext/form/Configuration/Yaml/FormSetup.yaml+48 −48
- typo3/sysext/rte_ckeditor/Configuration/RTE/Editor/Base.yaml+8 −8
- typo3/sysext/rte_ckeditor/Configuration/RTE/Editor/Plugins.yaml+5 −5
- typo3/sysext/rte_ckeditor/Configuration/RTE/Default.yaml+4 −4
- typo3/sysext/rte_ckeditor/Configuration/RTE/Full.yaml+11 −11
- typo3/sysext/rte_ckeditor/Configuration/RTE/Minimal.yaml+2 −2
Review log 1619
-
crell uploaded patch set 1 04/15/22, 21:07
-
core-ci voted on patch set 1 V -1 04/15/22, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26067
-
Oliver Klee commented on patch set 1 04/15/22, 21:58
-
crell commented on patch set 1 04/15/22, 22:26
Services.yaml:18ReplyIt is most definitely not... -
crell uploaded patch set 2 04/15/22, 22:27
-
core-ci voted on patch set 2 V +1 04/15/22, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26078
-
Oliver Klee wrote 04/16/22, 08:15
Removed cc Oliver Klee. -
Benni Mack voted on patch set 2 CR +1 04/16/22, 11:16
-
Stefan Bürk commented on patch set 2 04/16/22, 17:37
Please add a link to the coding style guidelines you are refering to. Would help to validate the statement. Are you refering to "https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/CodingGuidelines/CglYaml.html" ? I think, this "styleguide" is not correct at all and should be updated. But not part of this patch. In the end, it does not match when to use double quotes for a string-value instead of single quotes. As this is not explained in the styleguide, it should be explained with a small example here why to make it obvious why this change is "needed". (If need for special characters like line breaks are needed, double quotes has to be used - otherwise it will not be replaces properly). If you refer to another coding guidelines, and there it is explained properly, example can be ommited here. -
Susi Moog voted on patch set 2 CR +1 04/17/22, 19:55
-
crell updated the commit message in patch set 3 04/18/22, 14:19
-
crell commented on patch set 3 04/18/22, 14:19
Reply
Yes, that one. The linked Forge ticket has more context. I've also filed a related update for the CGL page here: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/1813 -
core-ci voted on patch set 3 V +1 04/18/22, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26151
-
Stefan Bürk commented on patch set 3 CR +1 04/18/22, 15:05
Reply
Done -
Simon Schaufelberger voted on patch set 3 V +1 CR +1 04/26/22, 20:26
-
Jörg Bösche voted on patch set 3 CR +1 04/27/22, 11:10
-
Stefan Bürk voted on patch set 3 V +1 04/27/22, 13:53
-
Benni Mack voted on patch set 3 V +2 CR +2 04/28/22, 16:05
-
Benni Mack merged patch set 4 04/28/22, 16:05
Services.yaml:18