Review main Merged

74326[TASK] Apply quote coding standards to YAML files

crell CR +2 V +2 Normal +90 −90 updated 04/28/22, 16:05

Commit message

Coding style guidelines say to favor single quotes unless
we actually want YAML interpolation.

This is a partner change with:

https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/1813

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Jörg Bösche +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1619

  1. crell uploaded patch set 1 04/15/22, 21:07

  2. core-ci voted on patch set 1 V -1 04/15/22, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26067

  3. Oliver Klee commented on patch set 1 04/15/22, 21:58

    Services.yaml:18

    This double single quote does not look right.
  4. crell commented on patch set 1 04/15/22, 22:26

    Services.yaml:18 Reply

    It is most definitely not...
  5. crell uploaded patch set 2 04/15/22, 22:27

  6. core-ci voted on patch set 2 V +1 04/15/22, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26078

  7. Oliver Klee wrote 04/16/22, 08:15

    Removed cc Oliver Klee.
  8. Benni Mack voted on patch set 2 CR +1 04/16/22, 11:16

  9. Stefan Bürk commented on patch set 2 04/16/22, 17:37

    Please add a link to the coding style guidelines you are refering to. Would help to validate the statement. Are you refering to "https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/CodingGuidelines/CglYaml.html"; ? I think, this "styleguide" is not correct at all and should be updated. But not part of this patch. In the end, it does not match when to use double quotes for a string-value instead of single quotes. As this is not explained in the styleguide, it should be explained with a small example here why to make it obvious why this change is "needed". (If need for special characters like line breaks are needed, double quotes has to be used - otherwise it will not be replaces properly). If you refer to another coding guidelines, and there it is explained properly, example can be ommited here.
  10. Susi Moog voted on patch set 2 CR +1 04/17/22, 19:55

  11. crell updated the commit message in patch set 3 04/18/22, 14:19

  12. crell commented on patch set 3 04/18/22, 14:19

    Reply

    Yes, that one. The linked Forge ticket has more context. I've also filed a related update for the CGL page here: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/1813
  13. core-ci voted on patch set 3 V +1 04/18/22, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26151

  14. Stefan Bürk commented on patch set 3 CR +1 04/18/22, 15:05

    Reply

    Done
  15. Simon Schaufelberger voted on patch set 3 V +1 CR +1 04/26/22, 20:26

  16. Jörg Bösche voted on patch set 3 CR +1 04/27/22, 11:10

  17. Stefan Bürk voted on patch set 3 V +1 04/27/22, 13:53

  18. Benni Mack voted on patch set 3 V +2 CR +2 04/28/22, 16:05

  19. Benni Mack merged patch set 4 04/28/22, 16:05