Review main Merged

74330[TASK] Update PHPUnit & friends

Oliver Klee CR +2 V +2 Normal +108 −101 updated 04/17/22, 10:35

Commit message

Used commands:
> composer req --dev -W phpunit/phpunit:^9.5.20
> composer req --dev -W phpspec/prophecy:^1.15.0
> composer req --dev -W phpspec/prophecy-phpunit:^2.0.1

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Oliver Klee uploaded patch set 1 04/16/22, 11:24

  2. core-ci voted on patch set 1 V -1 04/16/22, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26090

  3. Oliver Klee commented on patch set 1 04/16/22, 11:47

    The pipeline failure looks like a hiccup to me.
  4. Stefan Bürk commented on patch set 1 04/16/22, 12:36

    Reply

    yes. started retry
  5. core-ci voted on patch set 1 V +1 04/16/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26090

  6. Oliver Klee commented on patch set 1 04/16/22, 13:30

    Thanks, Stefan! <3
  7. Stefan Bürk voted on patch set 1 V +1 CR +1 04/16/22, 17:19

  8. Benni Mack voted on patch set 1 V +2 CR +2 04/17/22, 10:35

  9. Benni Mack merged patch set 2 04/17/22, 10:35