74331[DOCS] Document styling of current page in fluid_styled_content menu content elements
Commit message
Review
-
Code review CR +2 Done
- Lina Wolf +2
- Björn Jacob +1
- Jonas Eberle +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Lina Wolf +2
- Annett Jähnichen +1
- Björn Jacob +1
- Jonas Eberle +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
Lina Wolf uploaded patch set 1 04/17/22, 08:55
-
core-ci voted on patch set 1 V +1 04/17/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26096
-
Björn Jacob commented on patch set 1 04/17/22, 09:41
Index.rst:80This sentence is very difficult to read. I think mentioning the extension is not necessary. What do you think about this one? "If the current page is displayed within a menu the aria attribute :html:`aria-current="page"` is added to the a-tag of a menu-item."Index.rst:97I would also skip the extension stuff over here. > "The default styling of contains no style for the current page." -
Lina Wolf uploaded patch set 2 04/18/22, 09:05
-
Lina Wolf commented on patch set 2 04/18/22, 09:06
Index.rst:71ReplyDoneIndex.rst:80ReplyDoneIndex.rst:97ReplyDone -
core-ci voted on patch set 2 V +1 04/18/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26135
-
Björn Jacob commented on patch set 3 04/19/22, 06:55
Published edit on patch set 2. -
Björn Jacob commented on patch set 3 V +1 CR +1 04/19/22, 06:56
Thanks Lina for taking care! -
core-ci voted on patch set 3 V +1 04/19/22, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26174
-
Annett Jähnichen commented on patch set 3 V +1 04/19/22, 17:56
Hi Lina and Björn, Thx for your adjustments -
Jonas Eberle voted on patch set 3 V +1 CR +1 05/05/22, 09:34
-
Benni Mack voted on patch set 3 V +1 CR +1 05/05/22, 16:15
-
Stefan Bürk voted on patch set 3 V +1 CR +1 05/05/22, 17:23
-
Lina Wolf voted on patch set 3 V +2 CR +2 05/05/22, 18:52
-
Lina Wolf merged patch set 4 05/05/22, 18:52
Index.rst:71