Review main Merged

74331[DOCS] Document styling of current page in fluid_styled_content menu content elements

Lina Wolf CR +2 V +2 Easy +27 −0 updated 05/05/22, 18:52

Commit message

Document https://review.typo3.org/c/Packages/TYPO3.CMS/+/73048 in the extensions manual

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Björn Jacob +1
    • Jonas Eberle +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Annett Jähnichen +1
    • Björn Jacob +1
    • Jonas Eberle +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Lina Wolf uploaded patch set 1 04/17/22, 08:55

  2. core-ci voted on patch set 1 V +1 04/17/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26096

  3. Björn Jacob commented on patch set 1 04/17/22, 09:41

    Index.rst:71

    At first, I did not get what the whole thing is about. What do you think of this one: "Styling of the current page in a menu"

    Index.rst:80

    This sentence is very difficult to read. I think mentioning the extension is not necessary. What do you think about this one? "If the current page is displayed within a menu the aria attribute :html:`aria-current="page"` is added to the a-tag of a menu-item."

    Index.rst:97

    I would also skip the extension stuff over here. > "The default styling of contains no style for the current page."
  4. Lina Wolf uploaded patch set 2 04/18/22, 09:05

  5. Lina Wolf commented on patch set 2 04/18/22, 09:06

    Index.rst:71 Reply

    Done

    Index.rst:80 Reply

    Done

    Index.rst:97 Reply

    Done
  6. core-ci voted on patch set 2 V +1 04/18/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26135

  7. Björn Jacob commented on patch set 3 04/19/22, 06:55

    Published edit on patch set 2.
  8. Björn Jacob commented on patch set 3 V +1 CR +1 04/19/22, 06:56

    Thanks Lina for taking care!
  9. core-ci voted on patch set 3 V +1 04/19/22, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26174

  10. Annett Jähnichen commented on patch set 3 V +1 04/19/22, 17:56

    Hi Lina and Björn, Thx for your adjustments
  11. Jonas Eberle voted on patch set 3 V +1 CR +1 05/05/22, 09:34

  12. Benni Mack voted on patch set 3 V +1 CR +1 05/05/22, 16:15

  13. Stefan Bürk voted on patch set 3 V +1 CR +1 05/05/22, 17:23

  14. Lina Wolf voted on patch set 3 V +2 CR +2 05/05/22, 18:52

  15. Lina Wolf merged patch set 4 05/05/22, 18:52