Review 11.5 Merged

74333[TASK] Update PHPUnit & friends

Benni Mack CR +2 V +2 Normal +113 −106 updated 04/17/22, 18:53

Commit message

Used commands:
> composer req --dev -W phpunit/phpunit:^9.5.20
> composer req --dev -W phpspec/prophecy:^1.15.0
> composer req --dev -W phpspec/prophecy-phpunit:^2.0.1

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1419

  1. Benni Mack uploaded patch set 1 04/17/22, 10:36

  2. core-ci voted on patch set 1 V -1 04/17/22, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26098

  3. Oliver Klee commented on patch set 1 04/17/22, 11:31

    Ah well. How do we handle PHP-version-specific PHPStan warnings?
  4. Benni Mack commented on patch set 1 04/17/22, 11:34

    Reply

    I think this should be handled on phpstan side.
  5. Oliver Klee rebased onto patch set 2 04/17/22, 12:05

  6. core-ci voted on patch set 2 V -1 04/17/22, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26102

  7. core-ci commented on patch set 2 04/17/22, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26102

  8. Oliver Klee commented on patch set 2 04/17/22, 17:48

    I'm currently working on a changeset for cleaning up the type annotations for some image-related classes that should hopefully resolve one of the problems.
  9. Stefan Bürk commented on patch set 2 04/17/22, 18:03

    Reply

    Interesstingly I cannot reproduce this locally on 11.5 branch/monorepo ... even removed phpstan cache locally .... maybe it's kind of cache issue on the pipeline. But retry did not "solved" it yet. I have checked that locally before the vote on the main branch - so I'm a little bit puzzled about this. Maybe my check was not good enough - or missed something. We should avoid at all cost php version based scan's at all, specially maintainig rules by hand. If we really have no chance at some time, we have splitt the phpstan config along with the baseline file per php version. Which means, that on changes for v11 phpstan baseline has to be regenerated 3 times (for each version). This should be the absolute last thing to be done. Instead of handling it differently we should ensure that code is changed, if possible, to be green on phpstan on all versions. However - can you reproduce this locally @Oliver ? Still feels that we have some cache issues here - had that in the past from time to time. Will wait for changes from Oliver now.
  10. Oliver Klee commented on patch set 2 04/17/22, 18:07

    No, I cannot reproduce this locally either.
  11. Stefan Bürk uploaded patch set 3 04/17/22, 18:15

  12. Stefan Bürk uploaded patch set 4 04/17/22, 18:19

  13. core-ci voted on patch set 3 V +1 04/17/22, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26109

  14. core-ci voted on patch set 4 V +1 04/17/22, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26110

  15. Stefan Bürk commented on patch set 4 04/17/22, 18:33

    Look's like this was a cache issue. Had a feeling with phpstan on this already, this added a +1 on this feeling. Will discuss this with lolli along wiht some other points we wanted to discuss for the ci. However, this change should be okay.
  16. Stefan Bürk voted on patch set 4 V +1 CR +1 04/17/22, 18:33

  17. Oliver Klee commented on patch set 4 V +1 CR +1 04/17/22, 18:48

    Cool, thanks!
  18. Benni Mack voted on patch set 4 V +2 CR +2 04/17/22, 18:53

  19. Benni Mack merged patch set 5 04/17/22, 18:53