Review 11.5 Merged

74334[TASK] Annotate nullable properties in workspaces extension as such

Benni Mack CR +2 V +2 Normal +20 −120 updated 04/17/22, 12:35

Commit message

This fixes a whole bunch of PHPStan warnings.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 67

  1. Benni Mack uploaded patch set 1 04/17/22, 11:18

  2. Oliver Klee voted on patch set 1 V +1 CR +1 04/17/22, 11:26

  3. core-ci voted on patch set 1 V +1 04/17/22, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26099

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/17/22, 11:58

  5. Benni Mack merged patch set 2 04/17/22, 11:58

  6. Oliver Klee commented on patch set 2 04/17/22, 12:06

    Thanks for taking care of the backport, Benni!
  7. Benni Mack commented on patch set 2 04/17/22, 12:35

    yw!