74334[TASK] Annotate nullable properties in workspaces extension as such
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 11
- Build/phpstan/phpstan-baseline.neon+0 −100
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+1 −1
- typo3/sysext/workspaces/Classes/DataHandler/CommandMap.php+1 −1
- typo3/sysext/workspaces/Classes/Dependency/DependencyResolver.php+2 −2
- typo3/sysext/workspaces/Classes/Dependency/ElementEntity.php+4 −4
- typo3/sysext/workspaces/Classes/Dependency/ElementEntityProcessor.php+1 −1
- typo3/sysext/workspaces/Classes/Domain/Model/DatabaseRecord.php+1 −1
- typo3/sysext/workspaces/Classes/Domain/Record/StageRecord.php+4 −4
- typo3/sysext/workspaces/Classes/Domain/Record/WorkspaceRecord.php+3 −3
- typo3/sysext/workspaces/Classes/Service/Dependency/CollectionService.php+2 −2
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+1 −1
Review log 67
-
Benni Mack uploaded patch set 1 04/17/22, 11:18
-
Oliver Klee voted on patch set 1 V +1 CR +1 04/17/22, 11:26
-
core-ci voted on patch set 1 V +1 04/17/22, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26099
-
Benni Mack voted on patch set 1 V +2 CR +2 04/17/22, 11:58
-
Benni Mack merged patch set 2 04/17/22, 11:58
-
Oliver Klee commented on patch set 2 04/17/22, 12:06
Thanks for taking care of the backport, Benni! -
Benni Mack commented on patch set 2 04/17/22, 12:35
yw!