Review main Merged

74335[TASK] Migrate form-horizontal class to Bootstrap 5

Nikita Hovratov CR +2 V +2 Normal +57 −65 updated 04/17/22, 22:49

Commit message

This patch migrates the "form-horizontal" class from
Bootstrap 3 to the new style by using the "row" and
"col-form-label" classes.

Usages of form-group have also been replaced by the
utility "mb-3" class. This allowed to drop one Css
rule for removing the margin of the last element in
the LinkBrowser.

Places adjusted:
* Settings > Presets
* Form > Duplicate
* LinkBrowser
* ExtensionManager > Upload extension

Some places have already been migrated, but forgot
to remove the class.

In addition, the id "typo3-linkURL" has been removed
along the way, as the styling was removed in #71840
already.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 20

Review log 811

  1. Nikita Hovratov uploaded patch set 1 04/17/22, 11:34

  2. core-ci voted on patch set 1 V +1 04/17/22, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26100

  3. Nikita Hovratov uploaded patch set 2 04/17/22, 11:43

  4. core-ci voted on patch set 2 V +1 04/17/22, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26101

  5. Benni Mack commented on patch set 2 04/17/22, 12:00

    THANK you!

    Url.html:10

    I think we can remove "typo3-linkURL" as well now
  6. Nikita Hovratov uploaded patch set 3 04/17/22, 12:13

  7. Nikita Hovratov commented on patch set 3 04/17/22, 12:14

    Url.html:10 Reply

    Done
  8. core-ci voted on patch set 3 V +1 04/17/22, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26103

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 04/17/22, 21:54

  10. Benni Mack voted on patch set 3 V +2 CR +2 04/17/22, 22:49

  11. Benni Mack merged patch set 4 04/17/22, 22:49