Review main Merged

74336[BUGFIX] Fix an incorrect type annotation in the DataHandler

Oliver Klee CR +2 V +2 Easy +1 −6 updated 04/17/22, 19:10

Commit message

The corresponding parameter is used like an int, and only ints are
passed. So it needs to be an int instead of a string.

This change is non-breaking and hence backportable.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Oliver Klee uploaded patch set 1 04/17/22, 16:58

  2. Oliver Klee uploaded patch set 2 04/17/22, 17:01

  3. core-ci voted on patch set 1 V +1 04/17/22, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26107

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 04/17/22, 17:24

  5. core-ci voted on patch set 2 V +1 04/17/22, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26108

  6. Benni Mack voted on patch set 2 V +2 CR +2 04/17/22, 19:10

  7. Benni Mack merged patch set 3 04/17/22, 19:10